René's URL Explorer Experiment


Title: Write test to make sure imports stay silenced when using silent_imports + incremental. · Issue #2036 · python/mypy · GitHub

Open Graph Title: Write test to make sure imports stay silenced when using silent_imports + incremental. · Issue #2036 · python/mypy

X Title: Write test to make sure imports stay silenced when using silent_imports + incremental. · Issue #2036 · python/mypy

Description: I recently ran into a bug related to silenced modules sometimes being un-silenced and re-checked (?) when combining silent_imports and incremental mode and forcing an SCC to be rechecked (using commit fc03d438d61adf95e6a1aed6fb9fbdf986a9...

Open Graph Description: I recently ran into a bug related to silenced modules sometimes being un-silenced and re-checked (?) when combining silent_imports and incremental mode and forcing an SCC to be rechecked (using com...

X Description: I recently ran into a bug related to silenced modules sometimes being un-silenced and re-checked (?) when combining silent_imports and incremental mode and forcing an SCC to be rechecked (using com...

Opengraph URL: https://github.com/python/mypy/issues/2036

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Write test to make sure imports stay silenced when using silent_imports + incremental.","articleBody":"I recently ran into a bug related to silenced modules sometimes being un-silenced and re-checked (?) when combining silent_imports and incremental mode and forcing an SCC to be rechecked (using commit [fc03d438d61adf95e6a1aed6fb9fbdf986a90602](https://github.com/python/mypy/commit/fc03d438d61adf95e6a1aed6fb9fbdf986a90602), the latest version on master as of time of writing). \n\nWhile I was able to find a fix and will be submitting a pull request shortly, I wasn't able to write a test case. It would be nice to fix that, though it's challenging to do so for a few reasons. More details:\n\n---\n\nThis bug manifests after you...\n1. Make mypy run with silent_imports and incremental mode enabled with a cold cache.\n2. Re-run mypy to establish a baseline for what running mypy on a fully fresh cache should be. On large code-bases, this step should finish substantially faster then step 1.\n3. Make a harmless change to some file which happens to be importing some files not provided on the command line (eg are not being typechecked). This file may need to be a part of some odd import cycle shenanigans. \n4. Re-run mypy.\n5. Re-run mypy again.\n\nThe expected behavior is that on step 5, mypy should take about the same amount of time to complete as on step 2, since there was no change after step 4 finished. However, the actual behavior is that step 5 will take about the same amount of time to run as step 4. After examining the logs, it seems the reason why this is the case is because in step 4, mypy is treating the previously silenced imports from the modified file as unsilenced, which causes them to be rechecked.\n\nUnfortunately, I wasn't able to provide a test case because this problem seems to manifest mainly in larger code bases (with import cycles?) that are hard to simplify and after running incremental mode at least 3 times -- mypy's test suite can currently only run incremental two times.\n\nWhile I was able to reliably repro the issue against the large code-base and will be submitting a pull request with a fix momentarily, it would be nice if it were possible to add an actual test case for this bug. \n\nI'll try and working on adding a test case for this (probably after overhauling parts of the test framework), but I wanted to file an issue here in case this ends up dropping off my todo list.\n","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2016-08-18T02:07:12Z","url":"https://github.com/python/mypy/issues/2036"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:151cc6dc-00b8-0873-ab9f-c53f1e169bbf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDFE0:9E1B2:25DB898:3172CBD:6AFFF93E
html-safe-nonce8d2526439177ab602757b19e78eacc1648a1acd38c32981bfaad00ec23b1a2cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkUwOjlFMUIyOjI1REI4OTg6MzE3MkNCRDo2QUZGRjkzRSIsInZpc2l0b3JfaWQiOiI0ODk0NDMyMTIyNTY5MjI2NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac568b2600dfe3188d977247352171ad8c7c9041adc40043bcf477277102735803
hovercard-subject-tagissue:171802158
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2036/issue_layout
twitter:imagehttps://opengraph.githubassets.com/94cc6ee65165ef76f692ce1e8d40c5830eac6de973e321d84576ccff341b84ef/python/mypy/issues/2036
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94cc6ee65165ef76f692ce1e8d40c5830eac6de973e321d84576ccff341b84ef/python/mypy/issues/2036
og:image:altI recently ran into a bug related to silenced modules sometimes being un-silenced and re-checked (?) when combining silent_imports and incremental mode and forcing an SCC to be rechecked (using com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2036#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2036
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2036
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2036
Reloadhttps://github.com/python/mypy/issues/2036
Reloadhttps://github.com/python/mypy/issues/2036
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2036
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2036
Write test to make sure imports stay silenced when using silent_imports + incremental.https://github.com/python/mypy/issues/2036#top
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-import-cycleshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-import-cycles%22
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Aug 18, 2016https://github.com/python/mypy/issues/2036#issue-171802158
fc03d438d61adf95e6a1aed6fb9fbdf986a90602https://github.com/python/mypy/commit/fc03d438d61adf95e6a1aed6fb9fbdf986a90602
Michael0x2ahttps://github.com/Michael0x2a
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
topic-import-cycleshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-import-cycles%22
on Aug 18, 2016https://github.com/python/mypy/issues/2036#event-759340139
Michael0x2ahttps://github.com/Michael0x2a
on Aug 18, 2016https://github.com/python/mypy/issues/2036#event-759340219
Michael0x2ahttps://github.com/Michael0x2a
on Aug 18, 2016https://github.com/python/mypy/issues/2036#event-760574565
Michael0x2ahttps://github.com/Michael0x2a
on Aug 18, 2016https://github.com/python/mypy/issues/2036#event-760574603
https://github.com/timabbott
timabbotthttps://github.com/timabbott
on Oct 17, 2016https://github.com/python/mypy/issues/2036#issuecomment-254121278
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 17, 2016https://github.com/python/mypy/issues/2036#issuecomment-254227213
https://github.com/timabbott
timabbotthttps://github.com/timabbott
on Oct 17, 2016https://github.com/python/mypy/issues/2036#issuecomment-254326525
mypy-cache.tar.gzhttps://github.com/python/mypy/files/534661/mypy-cache.tar.gz
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 17, 2016https://github.com/python/mypy/issues/2036#issuecomment-254330721
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 17, 2016https://github.com/python/mypy/issues/2036#issuecomment-254336306
@timabbotthttps://github.com/timabbott
https://github.com/timabbott
timabbotthttps://github.com/timabbott
on Oct 18, 2016https://github.com/python/mypy/issues/2036#issuecomment-254377420
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 18, 2016https://github.com/python/mypy/issues/2036#issuecomment-254386314
#2271https://github.com/python/mypy/issues/2271
gvanrossumhttps://github.com/gvanrossum
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Jan 6, 2017https://github.com/python/mypy/issues/2036#event-914699397
gvanrossumhttps://github.com/gvanrossum
on Mar 29, 2017https://github.com/python/mypy/issues/2036#event-1021274391
msullivanhttps://github.com/msullivan
on Feb 28, 2018https://github.com/python/mypy/issues/2036#event-1495968864
Fix the missing_modules related failures.https://github.com/python/mypy/commit/7520f89dc4022d0f55c4237d42180e6be3d92cd8
7520f89https://github.com/python/mypy/commit/7520f89dc4022d0f55c4237d42180e6be3d92cd8
Optimize fine-grained update by using Graph as the cache (#4622)https://github.com/python/mypy/commit/3e1baaed031243efdb4a33f67654f6eb88568ff4
#4622https://github.com/python/mypy/pull/4622
3e1baaehttps://github.com/python/mypy/commit/3e1baaed031243efdb4a33f67654f6eb88568ff4
JukkaLhttps://github.com/JukkaL
Michael0x2ahttps://github.com/Michael0x2a
on Mar 8, 2018https://github.com/python/mypy/issues/2036#event-1511790206
yedpodtrzitkohttps://github.com/yedpodtrzitko
on Mar 15, 2018https://github.com/python/mypy/issues/2036#event-1523014527
Optimize fine-grained update by using Graph as the cache (python#4622)https://github.com/kiwicom/mypy/commit/f2bc3858c9f76ec761b3d58c667fb0e3c015569c
python#4622https://github.com/python/mypy/pull/4622
f2bc385https://github.com/kiwicom/mypy/commit/f2bc3858c9f76ec761b3d58c667fb0e3c015569c
ilevkivskyihttps://github.com/ilevkivskyi
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
on May 20, 2018https://github.com/python/mypy/issues/2036#event-1635801976
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Feb 12, 2026https://github.com/python/mypy/issues/2036#issuecomment-3892271874
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 12, 2026https://github.com/python/mypy/issues/2036#event-22742378179
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2036
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2036
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-import-cycleshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-import-cycles%22
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.