René's URL Explorer Experiment


Title: method descriptors aren't properly checked when assinging to a Protocol · Issue #19336 · python/mypy · GitHub

Open Graph Title: method descriptors aren't properly checked when assinging to a Protocol · Issue #19336 · python/mypy

X Title: method descriptors aren't properly checked when assinging to a Protocol · Issue #19336 · python/mypy

Description: Bug Report decorating methods with descriptors loses MyPy when checking against a Protocol. It ends up refusing the assignment because a method isn't Callable[...] but Descriptor I wasn't able this exact described behaviour in previous b...

Open Graph Description: Bug Report decorating methods with descriptors loses MyPy when checking against a Protocol. It ends up refusing the assignment because a method isn't Callable[...] but Descriptor I wasn't able this...

X Description: Bug Report decorating methods with descriptors loses MyPy when checking against a Protocol. It ends up refusing the assignment because a method isn't Callable[...] but Descriptor I wasn't a...

Opengraph URL: https://github.com/python/mypy/issues/19336

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"method descriptors aren't properly checked when assinging to a Protocol","articleBody":"\u003c!--\nIf you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form instead.\nPlease consider:\n\n- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\n- searching our issue tracker: https://github.com/python/mypy/issues to see if it's already been reported\n- asking on gitter chat: https://gitter.im/python/typing\n-->\n\n**Bug Report**\n\n\u003c!--\nIf you're reporting a problem with a specific library function, the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues\n\nIf the project you encountered the issue in is open source, please provide a link to the project.\n-->\n\ndecorating methods with descriptors loses MyPy when checking against a Protocol. It ends up refusing the assignment because a method isn't `Callable[...]` but `Descriptor` \n\nI wasn't able this exact described behaviour in previous bug reports. It does seem like mypy correctly assess the type of the described class fields and method in other cases.\n\n**To Reproduce**\n\n```python\nfrom collections.abc import Callable\nfrom typing import Concatenate, Generic, ParamSpec, Protocol, TypeVar\n\nP = ParamSpec(\"P\")\nOwner = TypeVar(\"Owner\")\nReturn = TypeVar(\"Return\")\n\n\nclass Runner(Generic[Owner, P, Return]):\n    def __init__(self, owner: Owner, func: Callable[Concatenate[Owner, P], Return]):\n        self.func = func\n        self.owner = owner\n\n    def __call__(self, *args: P.args, **kwargs: P.kwargs) -> Return:\n        return self.func(self.owner, *args, **kwargs)\n\n\nclass MyDescriptor(Generic[Owner, P, Return]):\n    def __init__(self, func: Callable[Concatenate[Owner, P], Return]):\n        self.func = func\n\n    def __get__(self, owner: Owner, type: type[Owner]) -> Runner[Owner, P, Return]:\n        return Runner(owner, self.func)\n\n\ndef with_descriptor(func: Callable[Concatenate[Owner, P], Return]) -> MyDescriptor[Owner, P, Return]:\n    return MyDescriptor(func)\n\n\nclass MyProtocol(Protocol):\n    def my_method(self, i: int) -> str: ...\n\n\nclass MyClass:\n    @with_descriptor\n    def my_method(self, i: int) -> str:\n        return f\"hello {i}\"\n\n\nconcrete_instance = MyClass()\n\nreveal_type(concrete_instance.my_method) # W: Type of \"concrete_instance.my_method\" is \"Runner[MyClass, (i: int), str]\"\nas_callable: Callable[[int], str] = concrete_instance.my_method # successful type checking\n\nmy_instance: MyProtocol = concrete_instance # type checking fails\nreveal_type(my_instance.my_method) # W: Type of \"my_instance.my_method\" is \"(i: int) -> str\"\n\n\nassert my_instance.my_method(8) == \"hello 8\"\n```\n[mypy playground](https://mypy-play.net/?mypy=1.16.1&python=3.12&gist=50b23b1b6948a46a5eb634646f09d1b3)\n\n**Expected Behavior**\n\n\u003c!--\nHow did you expect mypy to behave? It’s fine if you’re not sure your understanding is correct.\nWrite down what you thought would happen. If you expected no errors, delete this section.\n-->\nmypy should detect that the `__get__` method from the descriptor returns a compatible type for `Callable` (it has a compatible `__call__` method) and allow the assignment `my_instance: MyProtocol = MyClass()`\n\n**Actual Behavior**\n\nmypy correctly detects that the `concrete_instance.my_method` type is the one from the return of the `__get__` method from the descriptor. It also correctly asses that the type is compatible with `Callable[[int], str]` like the method of the protocol. \nHowever, it refuses to verify that this method is indeed compatible with the protocol's method when trying to assign the whole instance to a typed variable.\n\n\u003c!-- What went wrong? Paste mypy's output. -->\n\n```\nreproduce.py:42: note: Revealed type is \"reproduce.Runner[reproduce.MyClass, [i: builtins.int], builtins.str]\"\nreproduce.py:45: error: Incompatible types in assignment (expression has type \"MyClass\", variable has type \"MyProtocol\")  [assignment]\nreproduce.py:45: note: Following member(s) of \"MyClass\" have conflicts:\nreproduce.py:45: note:     my_method: expected \"Callable[[int], str]\", got \"MyDescriptor[MyClass, [int], str]\"\nreproduce.py:46: note: Revealed type is \"def (i: builtins.int) -> builtins.str\"\nFound 1 error in 1 file (checked 1 source file)\n```\n\n**Your Environment**\n\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\n\n- Mypy version used: 1.16.1 (compiled: yes)\n- Mypy command-line flags: none.\n- Mypy configuration options from `mypy.ini` (and other config files): `check_untyped_def=True`\n- Python version used: 3.12.3\n\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\n","author":{"url":"https://github.com/Floby","@type":"Person","name":"Floby"},"datePublished":"2025-06-24T19:09:05Z","url":"https://github.com/python/mypy/issues/19336"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e7412322-947e-561a-5eec-11ff6d6c848b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA734:3543F6:1006A91:1502BAF:6AFFF947
html-safe-nonce7941c2d869006b30854de5f0b92e797ced2fa711ad622ef6e08e2d3165e7ccaf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzM0OjM1NDNGNjoxMDA2QTkxOjE1MDJCQUY6NkFGRkY5NDciLCJ2aXNpdG9yX2lkIjoiODA1MTQzMzI0Nzc4NTA4OTM1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5db1edb38ac91033b836534a9a025fcaf50713b2a6da6443b9679f5979557046
hovercard-subject-tagissue:3173008184
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/19336/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e38ca107a911dff3d915ef006a976f67a7c3c4e1894feb2d685c43be1ea156f0/python/mypy/issues/19336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e38ca107a911dff3d915ef006a976f67a7c3c4e1894feb2d685c43be1ea156f0/python/mypy/issues/19336
og:image:altBug Report decorating methods with descriptors loses MyPy when checking against a Protocol. It ends up refusing the assignment because a method isn't Callable[...] but Descriptor I wasn't able this...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFloby
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/19336#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F19336
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F19336
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/19336
Reloadhttps://github.com/python/mypy/issues/19336
Reloadhttps://github.com/python/mypy/issues/19336
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/19336
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/19336
method descriptors aren't properly checked when assinging to a Protocolhttps://github.com/python/mypy/issues/19336#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/Floby
Flobyhttps://github.com/Floby
on Jun 24, 2025https://github.com/python/mypy/issues/19336#issue-3173008184
mypy playgroundhttps://mypy-play.net/?mypy=1.16.1&python=3.12&gist=50b23b1b6948a46a5eb634646f09d1b3
Flobyhttps://github.com/Floby
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Jun 24, 2025https://github.com/python/mypy/issues/19336#event-18300943640
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on Jun 24, 2025https://github.com/python/mypy/issues/19336#issuecomment-3001792791
#18943https://github.com/python/mypy/pull/18943
sterliakovhttps://github.com/sterliakov
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 24, 2025https://github.com/python/mypy/issues/19336#event-18302192952
https://github.com/Floby
Flobyhttps://github.com/Floby
on Jun 27, 2025https://github.com/python/mypy/issues/19336#issuecomment-3012362293
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/19336
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/19336
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.