René's URL Explorer Experiment


Title: Allow yielding result of function that returns None · Issue #1933 · python/mypy · GitHub

Open Graph Title: Allow yielding result of function that returns None · Issue #1933 · python/mypy

X Title: Allow yielding result of function that returns None · Issue #1933 · python/mypy

Description: UPDATE: see below for current status #1933 (comment) This is a spin-off from PR #1808. @ddfisher and I cannot agree on what the default type should be in the three methods get_generator_yield_type(), get_generator_receive_type(), get_gen...

Open Graph Description: UPDATE: see below for current status #1933 (comment) This is a spin-off from PR #1808. @ddfisher and I cannot agree on what the default type should be in the three methods get_generator_yield_type(...

X Description: UPDATE: see below for current status #1933 (comment) This is a spin-off from PR #1808. @ddfisher and I cannot agree on what the default type should be in the three methods get_generator_yield_type(...

Opengraph URL: https://github.com/python/mypy/issues/1933

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Allow yielding result of function that returns None","articleBody":"_UPDATE:_ see below for current status https://github.com/python/mypy/issues/1933#issuecomment-390018636\r\n\r\nThis is a spin-off from PR #1808. @ddfisher and I cannot agree on what the default type should be in the three methods `get_generator_yield_type()`, `get_generator_receive_type()`, `get_generator_return_type()`.\r\n\r\nThe setting: when the user defines a generator function, they can specify a return type. The return type is required to be a _supertype_ of `Generator`; this constrains it to `Iterator`, `Iterable`, `object` (and `Any`, which is special in other ways).\r\n\r\nThe `Generator` type has _three_ type parameters:\r\n- `ty`, the yield type: the type of `y` in `yield y`\r\n- `tc`, the receive type: the type of `c` in `c = yield ...`\r\n- `tr`, the return type: the type of `r` in `return r`\r\n\r\nNote that `tr` is fairly new -- it was introduced in Python 3.3 by PEP 380 for the benefit of `yield from`. `tc` is older, it dates back to Python 2.5 and PEP 342 (it is the value sent to the generator using the `.send()` method). `ty` is the oldest; when `yield` was originally introduced in Python 2.2 by PEP 255, it was a statement. Before PEP 380, `return` in a generator function was not allowed to return a value.\r\n\r\nWhen a generator function is just intended to be used as an iterator, there's no need to specify `tc` and `tr`, and the recommended type is `Iterator[ty]`. (`Iterable[ty]` is also allowed and means roughly the same thing.) In this case the user of the iterator has no access to the `.send()` method. Hence, `yield` might as well be considered a statement, since it's never going to return anything other than `None`. Likewise, there's no point is returning a value with a `return` statement since the user of the iterator in all likelihood is just going to iterate over it until it raises `StopIteration` (since that's all that regular iterators do).\r\n\r\nThis is where @ddfisher and I disagree -- I find it useful if the defaults for `tc` and `tr` are None (or perhaps Void), so that mypy will flag an error in the generator body if you either try to use `yield ...` as an expression, or try to return a value using `return \u003cexpr>`. David (IIUC) believes that both should be `Any`, giving the reason that \"it should be allow to pointless but harmless things.\" (The code currently has [`tc` default to `Void`](https://github.com/python/mypy/blob/master/mypy/checker.py#L298) and [`tr` default to `Any`](https://github.com/python/mypy/blob/master/mypy/checker.py#L317). Go figure.)\r\n\r\nMy problem with David's position is that I want mypy to be strict about pointless things that are likely the result of either a misunderstanding or a refactoring gone bad. I have seen enough people make the mistake of accidentally writing `return v` instead of `yield v` in a generator that I want this to be flagged as an error. There's also the somewhat analogous case of a regular function declared to return `None` -- it would be pointless but harmless to return some value here, so maybe David believes that we shouldn't flag that as an error either?\r\n\r\nI'm not sure why the existing code (written by David) has `Void` as the default for `tc`, but I think it may be because this parameter of `Generator` is [contravariant](https://github.com/python/typeshed/blob/master/stdlib/3/typing.pyi#L99). So hopefully we at least agree here. :-)\r\n\r\nDavid, please feel free to explain your position more fully (I think you were calling on the formal type system but we ran out of time in our in-person discussion at that point).\r\n","author":{"url":"https://github.com/gvanrossum","@type":"Person","name":"gvanrossum"},"datePublished":"2016-07-23T20:57:38Z","url":"https://github.com/python/mypy/issues/1933"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d3aa759f-3d05-f831-3491-3438088aed80
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA744:1A1C04:2102F88:2D03D29:6B0022CD
html-safe-nonced96dff570428dc0d63682bfa414b9ced51c7bf5c41a1b9cc417cc5fe6c3d7e41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzQ0OjFBMUMwNDoyMTAyRjg4OjJEMDNEMjk6NkIwMDIyQ0QiLCJ2aXNpdG9yX2lkIjoiMjczNzM1MjE5ODA1MTY4MzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacead7b063e282ce95dc43d4cc414b6f9ab666f1bb1651e1093eec20a7d19c9785
hovercard-subject-tagissue:167203179
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1933/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a0f958a7a3e865f1cd64cb1a38e2a510927f03152841f0f80c1ad132266facda/python/mypy/issues/1933
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0f958a7a3e865f1cd64cb1a38e2a510927f03152841f0f80c1ad132266facda/python/mypy/issues/1933
og:image:altUPDATE: see below for current status #1933 (comment) This is a spin-off from PR #1808. @ddfisher and I cannot agree on what the default type should be in the three methods get_generator_yield_type(...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/1933#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1933
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1933
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/1933
Reloadhttps://github.com/python/mypy/issues/1933
Reloadhttps://github.com/python/mypy/issues/1933
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1933
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1933
Allow yielding result of function that returns Nonehttps://github.com/python/mypy/issues/1933#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jul 23, 2016https://github.com/python/mypy/issues/1933#issue-167203179
#1933 (comment)https://github.com/python/mypy/issues/1933#issuecomment-390018636
#1808https://github.com/python/mypy/pull/1808
@ddfisherhttps://github.com/ddfisher
@ddfisherhttps://github.com/ddfisher
tc default to Voidhttps://github.com/python/mypy/blob/master/mypy/checker.py#L298
tr default to Anyhttps://github.com/python/mypy/blob/master/mypy/checker.py#L317
contravarianthttps://github.com/python/typeshed/blob/master/stdlib/3/typing.pyi#L99
gvanrossumhttps://github.com/gvanrossum
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
on Jul 23, 2016https://github.com/python/mypy/issues/1933#event-732642213
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Jul 26, 2016https://github.com/python/mypy/issues/1933#issuecomment-235439057
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jul 27, 2016https://github.com/python/mypy/issues/1933#issuecomment-235547374
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jul 27, 2016https://github.com/python/mypy/issues/1933#issuecomment-235626326
#1946https://github.com/python/mypy/pull/1946
gnpricehttps://github.com/gnprice
on Aug 4, 2016https://github.com/python/mypy/issues/1933#event-745901639
gvanrossumhttps://github.com/gvanrossum
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 6, 2017https://github.com/python/mypy/issues/1933#event-914705544
gvanrossumhttps://github.com/gvanrossum
on Mar 29, 2017https://github.com/python/mypy/issues/1933#event-1021273981
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on May 17, 2018https://github.com/python/mypy/issues/1933#issuecomment-390018636
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
on May 17, 2018https://github.com/python/mypy/issues/1933#event-1633011167
ilevkivskyihttps://github.com/ilevkivskyi
on May 17, 2018https://github.com/python/mypy/issues/1933#event-1633015220
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on May 17, 2018https://github.com/python/mypy/issues/1933#issuecomment-390024172
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on May 18, 2018https://github.com/python/mypy/issues/1933#issuecomment-390088456
dvarrazzohttps://github.com/dvarrazzo
on Oct 30, 2024https://github.com/python/mypy/issues/1933#event-15007705279
chore: ignore type error reported by mypy 1.12, 1.13https://github.com/psycopg/psycopg/commit/50ec089e69f28920676b93b72be0548950aa5360
50ec089https://github.com/psycopg/psycopg/commit/50ec089e69f28920676b93b72be0548950aa5360
dvarrazzohttps://github.com/dvarrazzo
on Nov 14, 2024https://github.com/python/mypy/issues/1933#event-15295411935
chore: ignore type error reported by mypy 1.12, 1.13https://github.com/psycopg/psycopg/commit/53009a7660cd4184ad5309ce5270ffa6bd9ad28b
53009a7https://github.com/psycopg/psycopg/commit/53009a7660cd4184ad5309ce5270ffa6bd9ad28b
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/1933
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/1933
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.