René's URL Explorer Experiment


Title: Mypy doesn't catch renaming arguments in overrides · Issue #19132 · python/mypy · GitHub

Open Graph Title: Mypy doesn't catch renaming arguments in overrides · Issue #19132 · python/mypy

X Title: Mypy doesn't catch renaming arguments in overrides · Issue #19132 · python/mypy

Description: Bug Report When overriding methods in subclasses, it's important to keep the same argument names since any argument in Python can be given as a keyword argument. If an override in a subclass changes the name of a parameter, it breaks the...

Open Graph Description: Bug Report When overriding methods in subclasses, it's important to keep the same argument names since any argument in Python can be given as a keyword argument. If an override in a subclass change...

X Description: Bug Report When overriding methods in subclasses, it's important to keep the same argument names since any argument in Python can be given as a keyword argument. If an override in a subclass ch...

Opengraph URL: https://github.com/python/mypy/issues/19132

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mypy doesn't catch renaming arguments in overrides","articleBody":"**Bug Report**\n\nWhen overriding methods in subclasses, it's important to keep the same argument names since any argument in Python can be given as a keyword argument. If an override in a subclass changes the name of a parameter, it breaks the polymorphism for any user of the class using keyword arguments\n\n**To Reproduce**\n\n```python\nfrom abc import ABC, abstractmethod\n\n\nclass Adder(ABC):\n    @abstractmethod\n    def add(self, a: int, b: int) -> int:\n        pass\n\n\nclass MyAdder(Adder):\n    def add(self, a: int, b: int) -> int:\n        return a + b\n\n\nclass OtherAdder(Adder):\n    def add(self, a: int, new_b: int) -> int:\n        return a + new_b\n\n\ndef use_adder(adder: Adder) -> int:\n    return adder.add(a=1, b=2)\n\n\nprint(f\"1 + 2 = {use_adder(MyAdder())}\")  # works\nprint(f\"1 + 2 = {use_adder(OtherAdder())}\")  # broken, but type checks in mypy\n```\n\n**Expected Behavior**\n\nThe code example above should not type check, as `OtherAdder` is not a valid subclass of `Adder`. If I type check this code in `pyright`, it correctly identifies this issue:\n\n``` commandline\n$ pyright classes.py\n/path/to/classes.py\n  /path/to/classes.py:16:9 - error: Method \"add\" overrides class \"Adder\" in an incompatible manner\n    Parameter 3 name mismatch: base parameter is named \"b\", override parameter is named \"new_b\" (reportIncompatibleMethodOverride)\n1 error, 0 warnings, 0 informations\n```\n\n**Actual Behavior**\n\nMypy lets this error through:\n\n``` commandline\n$ mypy classes.py\nSuccess: no issues found in 1 source file\n```\n\n**Your Environment**\n\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\n\n- Mypy version used: `mypy 1.15.0 (compiled: yes)`\n- Mypy command-line flags: None\n- Mypy configuration options from `mypy.ini` (and other config files): None\n- Python version used: `Python 3.13.3`\n\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\n","author":{"url":"https://github.com/mathialo","@type":"Person","name":"mathialo"},"datePublished":"2025-05-22T12:49:09Z","url":"https://github.com/python/mypy/issues/19132"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9aea6651-086e-03fd-5599-597c047b8b45
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEBEE:22FAD4:3EB10C:540AB5:6B002A94
html-safe-nonce8cd44b243cbd1af343de26aad88d7b5aacbceb5056d456b68fd828bcf53fd45d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkVFOjIyRkFENDozRUIxMEM6NTQwQUI1OjZCMDAyQTk0IiwidmlzaXRvcl9pZCI6IjUyNzkyODgzNzk0MzM4MjI4NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac932df3b09083d67962466aaba3e9d98672a1109971e7fa26d69c89415be9a5d8
hovercard-subject-tagissue:3083271471
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/19132/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ebbdb2513003c722886752b28d0b37adc4caa73f0013ee76f42822aa78fc7318/python/mypy/issues/19132
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ebbdb2513003c722886752b28d0b37adc4caa73f0013ee76f42822aa78fc7318/python/mypy/issues/19132
og:image:altBug Report When overriding methods in subclasses, it's important to keep the same argument names since any argument in Python can be given as a keyword argument. If an override in a subclass change...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemathialo
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/19132#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F19132
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F19132
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/19132
Reloadhttps://github.com/python/mypy/issues/19132
Reloadhttps://github.com/python/mypy/issues/19132
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/19132
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/19132
Mypy doesn't catch renaming arguments in overrideshttps://github.com/python/mypy/issues/19132#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/mathialo
mathialohttps://github.com/mathialo
on May 22, 2025https://github.com/python/mypy/issues/19132#issue-3083271471
mathialohttps://github.com/mathialo
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 22, 2025https://github.com/python/mypy/issues/19132#event-17771904179
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on May 22, 2025https://github.com/python/mypy/issues/19132#issuecomment-2902638274
#1013https://github.com/python/mypy/issues/1013
#8314https://github.com/python/mypy/issues/8314
#1013https://github.com/python/mypy/issues/1013
sterliakovhttps://github.com/sterliakov
duplicatehttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Aduplicate
Check keyword argument compatibility across class hierarchies #1013https://github.com/python/mypy/issues/1013
on May 22, 2025https://github.com/python/mypy/issues/19132#event-17779956471
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/19132
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/19132
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.