Title: `Checker.is_final_enum_value` duplicates `TypoInfo.enum_members` logic · Issue #18565 · python/mypy · GitHub
Open Graph Title: `Checker.is_final_enum_value` duplicates `TypoInfo.enum_members` logic · Issue #18565 · python/mypy
X Title: `Checker.is_final_enum_value` duplicates `TypoInfo.enum_members` logic · Issue #18565 · python/mypy
Description: After merging #18559 I think it would make sense to change how we check for @final enums here: mypy/mypy/checker.py Lines 2705 to 2727 in d4e7a81 def is_final_enum_value(self, sym: SymbolTableNode) -> bool: if isinstance(sym.node, (FuncB...
Open Graph Description: After merging #18559 I think it would make sense to change how we check for @final enums here: mypy/mypy/checker.py Lines 2705 to 2727 in d4e7a81 def is_final_enum_value(self, sym: SymbolTableNode)...
X Description: After merging #18559 I think it would make sense to change how we check for @final enums here: mypy/mypy/checker.py Lines 2705 to 2727 in d4e7a81 def is_final_enum_value(self, sym: SymbolTableNode)...
Opengraph URL: https://github.com/python/mypy/issues/18565
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`Checker.is_final_enum_value` duplicates `TypoInfo.enum_members` logic","articleBody":"After merging https://github.com/python/mypy/pull/18559 I think it would make sense to change how we check for `@final` enums here: https://github.com/python/mypy/blob/d4e7a81ef9a66a80cb395b6afb8498f7dbcd3c96/mypy/checker.py#L2705-L2727\n\nThere's no need to duplicate the `.enum_member` logic here once again. I will refactor this piece.","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2025-01-29T09:52:46Z","url":"https://github.com/python/mypy/issues/18565"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5c452be5-58b9-6acb-dc41-4b8e25be08d2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A042:609A0:3166682:40F4B53:6B002401 |
| html-safe-nonce | e820e5e6e283551f265c0a2f722e516540ee6ce1116d7c15d1b4921c379f7b2a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDQyOjYwOUEwOjMxNjY2ODI6NDBGNEI1Mzo2QjAwMjQwMSIsInZpc2l0b3JfaWQiOiI2MDczNTE2ODAyNzExNzU3ODI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 564256b0ea1166872f60bd7a4208c12a890d6101c07cf78bd4b18a4f3b6a5ce7 |
| hovercard-subject-tag | issue:2817719720 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/18565/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c46215e6bad061008b953aaa16bafe3a68587b45e868259add2fb5c86480af7f/python/mypy/issues/18565 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c46215e6bad061008b953aaa16bafe3a68587b45e868259add2fb5c86480af7f/python/mypy/issues/18565 |
| og:image:alt | After merging #18559 I think it would make sense to change how we check for @final enums here: mypy/mypy/checker.py Lines 2705 to 2727 in d4e7a81 def is_final_enum_value(self, sym: SymbolTableNode)... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width