René's URL Explorer Experiment


Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy · GitHub

Open Graph Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy

X Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy

Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown with reveal_type but does not complain a...

Open Graph Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ...

X Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ...

Opengraph URL: https://github.com/python/mypy/issues/18492

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False narrowing with repeated assignment inside if resulting in bad false negative","articleBody":"**Bug Report**\n\nIn a function, `mypy` fails to detect an incompatible assignment in a function, if that is after a `__get_item__` access inside a branch. Weirdly, `mypy` correctly deduces the types, as shown with `reveal_type` but does not complain about the incorrect assignment anyways.\n\n**To Reproduce**\n\nI would have liked to give a playground link, but the MWE involves a `pandas.DataFrame` which seems not to work on the playground.\n\n```python\nimport pandas as pd\n\n# fails as expected\nsome_condition: bool = \"123\".isnumeric()\nlist_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\nif some_condition > 0:\n    output_df = pd.DataFrame(list_of_dicts)\n    output_df = output_df[[\"some\", \"columns\", \"here\"]]\nelse:\n    output_df = None  # fails here\n\n\ndef fails_as_expected_1(some_condition: bool) -> pd.DataFrame:\n    list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n    output_df = pd.DataFrame(list_of_dicts)\n    output_df = output_df[[\"some\", \"columns\", \"here\"]]\n    output_df = None  # fails here\n    other_df: pd.DataFrame = output_df\n    return other_df\n\n\ndef fails_as_expected_2(some_condition: bool) -> pd.DataFrame:\n    list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n    if some_condition > 0:\n        output_df = pd.DataFrame(list_of_dicts)\n    else:\n        output_df = None\n    other_df: pd.DataFrame = output_df  # fails here\n    return other_df\n\n\ndef does_not_fail_but_should(some_condition: bool) -> pd.DataFrame:\n    list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n    if some_condition > 0:\n        output_df = pd.DataFrame(list_of_dicts)\n        reveal_type(output_df)\n        output_df = output_df[[\"some\", \"columns\", \"here\"]]\n        reveal_type(output_df)\n    else:\n        output_df = None\n    other_df: pd.DataFrame = output_df\n    return other_df\n```\n\n**Expected Behavior**\nEach block and function should contain a `mypy` error regarding an incompatible assignment.\n\n**Actual Behavior**\n\nFor the last function, no such error is produced:\n\n```\nmwe2.py:10: error: Incompatible types in assignment (expression has type \"None\", variable has type \"DataFrame\")  [assignment]\nmwe2.py:17: error: Incompatible types in assignment (expression has type \"None\", variable has type \"DataFrame\")  [assignment]\nmwe2.py:28: error: Incompatible types in assignment (expression has type \"DataFrame | None\", variable has type \"DataFrame\")  [assignment]\nmwe2.py:36: note: Revealed type is \"pandas.core.frame.DataFrame\"\nmwe2.py:38: note: Revealed type is \"pandas.core.frame.DataFrame\"\nFound 3 errors in 1 file (checked 1 source file)\n```\n\n**Your Environment**\n\n- Mypy version used: mypy 1.14.1 (compiled: yes)\n- Mypy command-line flags: only the filename\n- Mypy configuration options from `pyproject.toml`:\n\n```toml\n[tool.mypy]\nwarn_unreachable = true\nenable_error_code = [\n    \"possibly-undefined\"\n]\nstrict = true\n```\n- Python version used: Python 3.12.8 from Debian Testing\n\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\n","author":{"url":"https://github.com/MaxG87","@type":"Person","name":"MaxG87"},"datePublished":"2025-01-20T10:37:52Z","url":"https://github.com/python/mypy/issues/18492"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:46bdbc7a-d50b-1221-eb50-4786627cc58d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC67E:7F150:1CF86A9:26674BA:6B003420
html-safe-nonce84e0399802b05a2f2e440544438a69a520a4b1935417cf9dc2387ca21f4b1986
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjdFOjdGMTUwOjFDRjg2QTk6MjY2NzRCQTo2QjAwMzQyMCIsInZpc2l0b3JfaWQiOiIzMjc0OTg1MzY0NjkwODQyNjU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0945ed52c4bf6e068484030cfd1060debd4e7d1d189a57f389eea679382ec088
hovercard-subject-tagissue:2798878975
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/18492/issue_layout
twitter:imagehttps://opengraph.githubassets.com/10049e79e22483b7091d4f550a5809d0b10bb2655e3cd777d9088ca8968c431c/python/mypy/issues/18492
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10049e79e22483b7091d4f550a5809d0b10bb2655e3cd777d9088ca8968c431c/python/mypy/issues/18492
og:image:altBug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMaxG87
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/18492#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F18492
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F18492
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/18492
Reloadhttps://github.com/python/mypy/issues/18492
Reloadhttps://github.com/python/mypy/issues/18492
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/18492
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/18492
False narrowing with repeated assignment inside if resulting in bad false negativehttps://github.com/python/mypy/issues/18492#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/MaxG87
MaxG87https://github.com/MaxG87
on Jan 20, 2025https://github.com/python/mypy/issues/18492#issue-2798878975
MaxG87https://github.com/MaxG87
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Jan 20, 2025https://github.com/python/mypy/issues/18492#event-15996742035
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Jan 20, 2025https://github.com/python/mypy/issues/18492#issuecomment-2603282011
hauntsaninjahttps://github.com/hauntsaninja
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Jan 20, 2025https://github.com/python/mypy/issues/18492#event-16004854415
https://github.com/MaxG87
MaxG87https://github.com/MaxG87
on Jan 21, 2025https://github.com/python/mypy/issues/18492#issuecomment-2604190876
hauntsaninjahttps://github.com/hauntsaninja
on Jan 23, 2025https://github.com/python/mypy/issues/18492#event-16036794379
https://github.com/Prabhat-Thapa45
Prabhat-Thapa45https://github.com/Prabhat-Thapa45
on Jan 31, 2025https://github.com/python/mypy/issues/18492#issuecomment-2626364980
@hauntsaninjahttps://github.com/hauntsaninja
https://github.com/east825
east825https://github.com/east825
on May 19, 2025https://github.com/python/mypy/issues/18492#issuecomment-2891563128
301c3b6https://github.com/python/mypy/commit/301c3b604a2823aeb3b976272e38adb112848acf
@Prabhat-Thapa45https://github.com/Prabhat-Thapa45
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 19, 2025https://github.com/python/mypy/issues/18492#event-17718265506
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on May 19, 2025https://github.com/python/mypy/issues/18492#issuecomment-2892117137
#18538https://github.com/python/mypy/pull/18538
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/18492
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/18492
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.