Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy · GitHub
Open Graph Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy
X Title: False narrowing with repeated assignment inside if resulting in bad false negative · Issue #18492 · python/mypy
Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown with reveal_type but does not complain a...
Open Graph Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ...
X Description: Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ...
Opengraph URL: https://github.com/python/mypy/issues/18492
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False narrowing with repeated assignment inside if resulting in bad false negative","articleBody":"**Bug Report**\n\nIn a function, `mypy` fails to detect an incompatible assignment in a function, if that is after a `__get_item__` access inside a branch. Weirdly, `mypy` correctly deduces the types, as shown with `reveal_type` but does not complain about the incorrect assignment anyways.\n\n**To Reproduce**\n\nI would have liked to give a playground link, but the MWE involves a `pandas.DataFrame` which seems not to work on the playground.\n\n```python\nimport pandas as pd\n\n# fails as expected\nsome_condition: bool = \"123\".isnumeric()\nlist_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\nif some_condition > 0:\n output_df = pd.DataFrame(list_of_dicts)\n output_df = output_df[[\"some\", \"columns\", \"here\"]]\nelse:\n output_df = None # fails here\n\n\ndef fails_as_expected_1(some_condition: bool) -> pd.DataFrame:\n list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n output_df = pd.DataFrame(list_of_dicts)\n output_df = output_df[[\"some\", \"columns\", \"here\"]]\n output_df = None # fails here\n other_df: pd.DataFrame = output_df\n return other_df\n\n\ndef fails_as_expected_2(some_condition: bool) -> pd.DataFrame:\n list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n if some_condition > 0:\n output_df = pd.DataFrame(list_of_dicts)\n else:\n output_df = None\n other_df: pd.DataFrame = output_df # fails here\n return other_df\n\n\ndef does_not_fail_but_should(some_condition: bool) -> pd.DataFrame:\n list_of_dicts = [{\"some\": 1, \"columns\": 2, \"will\": 3, \"go\": 4, \"here\": 5}]\n if some_condition > 0:\n output_df = pd.DataFrame(list_of_dicts)\n reveal_type(output_df)\n output_df = output_df[[\"some\", \"columns\", \"here\"]]\n reveal_type(output_df)\n else:\n output_df = None\n other_df: pd.DataFrame = output_df\n return other_df\n```\n\n**Expected Behavior**\nEach block and function should contain a `mypy` error regarding an incompatible assignment.\n\n**Actual Behavior**\n\nFor the last function, no such error is produced:\n\n```\nmwe2.py:10: error: Incompatible types in assignment (expression has type \"None\", variable has type \"DataFrame\") [assignment]\nmwe2.py:17: error: Incompatible types in assignment (expression has type \"None\", variable has type \"DataFrame\") [assignment]\nmwe2.py:28: error: Incompatible types in assignment (expression has type \"DataFrame | None\", variable has type \"DataFrame\") [assignment]\nmwe2.py:36: note: Revealed type is \"pandas.core.frame.DataFrame\"\nmwe2.py:38: note: Revealed type is \"pandas.core.frame.DataFrame\"\nFound 3 errors in 1 file (checked 1 source file)\n```\n\n**Your Environment**\n\n- Mypy version used: mypy 1.14.1 (compiled: yes)\n- Mypy command-line flags: only the filename\n- Mypy configuration options from `pyproject.toml`:\n\n```toml\n[tool.mypy]\nwarn_unreachable = true\nenable_error_code = [\n \"possibly-undefined\"\n]\nstrict = true\n```\n- Python version used: Python 3.12.8 from Debian Testing\n\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\n","author":{"url":"https://github.com/MaxG87","@type":"Person","name":"MaxG87"},"datePublished":"2025-01-20T10:37:52Z","url":"https://github.com/python/mypy/issues/18492"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:46bdbc7a-d50b-1221-eb50-4786627cc58d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C67E:7F150:1CF86A9:26674BA:6B003420 |
| html-safe-nonce | 84e0399802b05a2f2e440544438a69a520a4b1935417cf9dc2387ca21f4b1986 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjdFOjdGMTUwOjFDRjg2QTk6MjY2NzRCQTo2QjAwMzQyMCIsInZpc2l0b3JfaWQiOiIzMjc0OTg1MzY0NjkwODQyNjU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0945ed52c4bf6e068484030cfd1060debd4e7d1d189a57f389eea679382ec088 |
| hovercard-subject-tag | issue:2798878975 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/18492/issue_layout |
| twitter:image | https://opengraph.githubassets.com/10049e79e22483b7091d4f550a5809d0b10bb2655e3cd777d9088ca8968c431c/python/mypy/issues/18492 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/10049e79e22483b7091d4f550a5809d0b10bb2655e3cd777d9088ca8968c431c/python/mypy/issues/18492 |
| og:image:alt | Bug Report In a function, mypy fails to detect an incompatible assignment in a function, if that is after a __get_item__ access inside a branch. Weirdly, mypy correctly deduces the types, as shown ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MaxG87 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width