René's URL Explorer Experiment


Title: Flag `None` check on value that cannot be `None` · Issue #18386 · python/mypy · GitHub

Open Graph Title: Flag `None` check on value that cannot be `None` · Issue #18386 · python/mypy

X Title: Flag `None` check on value that cannot be `None` · Issue #18386 · python/mypy

Description: Say I have function that maybe returns None and I check the result: def f() -> int | None: ... if f() is None: ... I rewrite the function so that it never returns None: def f() -> int: ... if f() is None: ... Now the is None check makes ...

Open Graph Description: Say I have function that maybe returns None and I check the result: def f() -> int | None: ... if f() is None: ... I rewrite the function so that it never returns None: def f() -> int: ... if f() i...

X Description: Say I have function that maybe returns None and I check the result: def f() -> int | None: ... if f() is None: ... I rewrite the function so that it never returns None: def f() -> int: ... if...

Opengraph URL: https://github.com/python/mypy/issues/18386

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Flag `None` check on value that cannot be `None`","articleBody":"Say I have function that maybe returns `None` and I check the result:\r\n\r\n```python\r\ndef f() -> int | None: ...\r\n\r\nif f() is None: ...\r\n```\r\n\r\nI rewrite the function so that it never returns `None`:\r\n\r\n```python\r\ndef f() -> int: ...\r\n\r\nif f() is None: ...\r\n```\r\n\r\nNow the `is None` check makes no sense -- it will always fail. This is a mistake introduced in refactoring and it should be flagged. (And similar for `is not None` checks)\r\n\r\nIn Rust I don't think this kind of error is possible:\r\n\r\n```rust\r\nfn f() -> Option\u003cu8>;\r\n\r\nif f().is_none() {}  // okay\r\n\r\nfn g() -> u8;\r\n\r\nif g().is_none() {} // no good\r\n```","author":{"url":"https://github.com/nickdrozd","@type":"Person","name":"nickdrozd"},"datePublished":"2024-12-30T21:28:44Z","url":"https://github.com/python/mypy/issues/18386"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d70e686e-c583-f955-7376-0c07a741e808
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA168:B7CF9:64B2E6:8665D3:6B003450
html-safe-nonceaa8c6c28eb9c4d7864b2f3a8d137dd1b8ce96d7e62c02d003c89b4ff18d97423
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTY4OkI3Q0Y5OjY0QjJFNjo4NjY1RDM6NkIwMDM0NTAiLCJ2aXNpdG9yX2lkIjoiODcwNzI2Njg3NjkxNDI4MzYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a09da39ee572d877eddf7bab4622ae92317acec32663f024ea315c6148e4f2c
hovercard-subject-tagissue:2763716067
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/18386/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fde2c232038af4c7f08a32b29af78d8cda897a3a846d40677cc8743e7f8e885f/python/mypy/issues/18386
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fde2c232038af4c7f08a32b29af78d8cda897a3a846d40677cc8743e7f8e885f/python/mypy/issues/18386
og:image:altSay I have function that maybe returns None and I check the result: def f() -> int | None: ... if f() is None: ... I rewrite the function so that it never returns None: def f() -> int: ... if f() i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenickdrozd
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/18386#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F18386
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F18386
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/18386
Reloadhttps://github.com/python/mypy/issues/18386
Reloadhttps://github.com/python/mypy/issues/18386
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/18386
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/18386
#19718https://github.com/python/mypy/pull/19718
Flag None check on value that cannot be Nonehttps://github.com/python/mypy/issues/18386#top
#19718https://github.com/python/mypy/pull/19718
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
https://github.com/nickdrozd
nickdrozdhttps://github.com/nickdrozd
on Dec 30, 2024https://github.com/python/mypy/issues/18386#issue-2763716067
nickdrozdhttps://github.com/nickdrozd
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Dec 30, 2024https://github.com/python/mypy/issues/18386#event-15787116398
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Jan 1, 2025https://github.com/python/mypy/issues/18386#issuecomment-2566846166
https://github.com/nickdrozd
nickdrozdhttps://github.com/nickdrozd
on Jan 1, 2025https://github.com/python/mypy/issues/18386#issuecomment-2566890859
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Jan 1, 2025https://github.com/python/mypy/issues/18386#issuecomment-2566898507
#18078https://github.com/python/mypy/issues/18078
https://github.com/nickdrozd
nickdrozdhttps://github.com/nickdrozd
on Jan 1, 2025https://github.com/python/mypy/issues/18386#issuecomment-2567101291
hamdanalhttps://github.com/hamdanal
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Jan 5, 2025https://github.com/python/mypy/issues/18386#event-15818373304
https://github.com/tyralla
tyrallahttps://github.com/tyralla
on Aug 23, 2025https://github.com/python/mypy/issues/18386#issuecomment-3217447992
#6370https://github.com/python/mypy/pull/6370
mypy/mypy/checkexpr.pyhttps://github.com/python/mypy/blob/116b92bae7b5dbf5e6bd36fd9b0c6804973e5554/mypy/checkexpr.py#L3772-L3780
116b92bhttps://github.com/python/mypy/commit/116b92bae7b5dbf5e6bd36fd9b0c6804973e5554
#19718https://github.com/python/mypy/pull/19718
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#19718https://github.com/python/mypy/pull/19718
on Aug 30, 2025https://github.com/python/mypy/issues/18386#event-19423191384
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 30, 2025https://github.com/python/mypy/issues/18386#event-19423191385
`--strict-equality` for `None` (#19718)https://github.com/python/mypy/commit/618cf55d4b454dc0b64b06ed387a0f5c70bc0cfe
#19718https://github.com/python/mypy/pull/19718
https://docs.github.com/articles/closing-issues-via-commit-messages
618cf55https://github.com/python/mypy/commit/618cf55d4b454dc0b64b06ed387a0f5c70bc0cfe
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/18386
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/18386
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.