Title: Binding an abc to TypeVar loses abstract class check · Issue #1830 · python/mypy · GitHub
Open Graph Title: Binding an abc to TypeVar loses abstract class check · Issue #1830 · python/mypy
X Title: Binding an abc to TypeVar loses abstract class check · Issue #1830 · python/mypy
Description: I was looking at the docstring of Type and noticed that it used a TypeVar for the argument. I wasn't using TypeVars so I started adding them to my code. But then I noticed I was getting fewer errors and mypy was not warning me about crea...
Open Graph Description: I was looking at the docstring of Type and noticed that it used a TypeVar for the argument. I wasn't using TypeVars so I started adding them to my code. But then I noticed I was getting fewer error...
X Description: I was looking at the docstring of Type and noticed that it used a TypeVar for the argument. I wasn't using TypeVars so I started adding them to my code. But then I noticed I was getting fewer e...
Opengraph URL: https://github.com/python/mypy/issues/1830
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Binding an abc to TypeVar loses abstract class check","articleBody":"I was looking at the docstring of Type and noticed that it used a TypeVar for the argument. I wasn't using TypeVars so I started adding them to my code. But then I noticed I was getting fewer errors and mypy was not warning me about creating abstract base classes. Here's my simplified code:\n\n```\nfrom abc import ABCMeta, abstractmethod\nfrom six import add_metaclass\nfrom typing import TypeVar, Type\n\n@add_metaclass(ABCMeta)\nclass User(object):\n @abstractmethod\n def foo(self):\n pass\n\nclass BasicUser(User):\n def foo(self):\n return 'yay'\n\ntry:\n u = User() # This fails correctly.\nexcept TypeError:\n pass\nbasic = BasicUser()\n\n\n# Using a TypeVar\nU = TypeVar('U', bound=User)\ndef new_user(user_class):\n # type: (Type[U]) -> U\n user = user_class() # This passes typechecking.\n return user\n\njoe = new_user(BasicUser)\ntry:\n jo2 = new_user(User) # This should probably fail but doesn't.\nexcept TypeError:\n pass\n\n\n# Not using a TypeVar\ndef new_user2(user_class):\n # type: (Type[User]) -> User\n user = user_class() # This fails typecheck.\n return user\n\njar = new_user2(BasicUser)\ntry:\n ja2 = new_user2(User)\nexcept TypeError:\n pass\n```\n\n(This was in python 2)\n\nI can't tell what's better. It's annoying that `(Type[User]) -> User` wouldn't work. But I sort of understand that it can't guarantee to work. What I've done to work around this is have user_class instead be a function that returns a User. \n\n```\ndef new_user3(user_class_fn):\n # type: (Callable[[], User]) -> User\n user = user_class_fn()\n return user\n\ndef get_basic_user():\n # type: () -> User\n return BasicUser()\n\ndef get_user():\n # type: () -> User\n return User() # this fails correctly\n\njar = new_user3(get_basic_user)\ntry:\n ja2 = new_user3(get_user)\nexcept TypeError:\n pass\n```\n","author":{"url":"https://github.com/euresti","@type":"Person","name":"euresti"},"datePublished":"2016-07-08T11:02:51Z","url":"https://github.com/python/mypy/issues/1830"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:248adda3-ebb5-cda7-84c5-59130a3b1438 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C430:2463C6:4CE44A:673175:6B002F3D |
| html-safe-nonce | a589d078cddd0249f8d3f1f2e1d21632ebd9a14babd3c39c0f43eec9a618bda7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDMwOjI0NjNDNjo0Q0U0NEE6NjczMTc1OjZCMDAyRjNEIiwidmlzaXRvcl9pZCI6IjI2NjQwNjUxMjc2OTg5MzU2MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ab8cded9807936b1b638c5b997b8058d1f375d68d6569bd5c565b31aec52bb0 |
| hovercard-subject-tag | issue:164508041 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1830/issue_layout |
| twitter:image | https://opengraph.githubassets.com/39ce00c96f9fd68e635b208d02d124b8c2aed4649da33ee09d33bd5d04c7beea/python/mypy/issues/1830 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/39ce00c96f9fd68e635b208d02d124b8c2aed4649da33ee09d33bd5d04c7beea/python/mypy/issues/1830 |
| og:image:alt | I was looking at the docstring of Type and noticed that it used a TypeVar for the argument. I wasn't using TypeVars so I started adding them to my code. But then I noticed I was getting fewer error... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | euresti |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width