Title: False positive "Statement is unreachable" when checking if typevar is None · Issue #18126 · python/mypy · GitHub
Open Graph Title: False positive "Statement is unreachable" when checking if typevar is None · Issue #18126 · python/mypy
X Title: False positive "Statement is unreachable" when checking if typevar is None · Issue #18126 · python/mypy
Description: Bug Report Mypy doesn't seem to like it when you check if an argument with typevar type is checked to see if it is None. It incorrectly reports error: Statement is unreachable [unreachable] To Reproduce https://mypy-play.net/?mypy=latest...
Open Graph Description: Bug Report Mypy doesn't seem to like it when you check if an argument with typevar type is checked to see if it is None. It incorrectly reports error: Statement is unreachable [unreachable] To Repr...
X Description: Bug Report Mypy doesn't seem to like it when you check if an argument with typevar type is checked to see if it is None. It incorrectly reports error: Statement is unreachable [unreachable] To ...
Opengraph URL: https://github.com/python/mypy/issues/18126
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False positive \"Statement is unreachable\" when checking if typevar is None","articleBody":"\u003c!--\r\nIf you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form instead.\r\nPlease consider:\r\n\r\n- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\r\n- searching our issue tracker: https://github.com/python/mypy/issues to see if it's already been reported\r\n- asking on gitter chat: https://gitter.im/python/typing\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nIf you're reporting a problem with a specific library function, the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues\r\n\r\nIf the project you encountered the issue in is open source, please provide a link to the project.\r\n-->\r\n\r\nMypy doesn't seem to like it when you check if an argument with typevar type is checked to see if it is `None`. It incorrectly reports ` error: Statement is unreachable [unreachable]`\r\n\r\n**To Reproduce**\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.12&flags=strict%2Cwarn-unreachable&gist=ceb8193f19f8b53a55dea70fad802469\r\n\r\n```python\r\nimport typing as t\r\n\r\nT = t.TypeVar(\"T\")\r\n\r\ndef foo(arg: T) -> None:\r\n if arg is None:\r\n return None\r\n # Do something with arg\r\n return None\r\n\r\n\r\nfoo(None) ## Allowed\r\nfoo(123)\r\n```\r\n\r\nRun mypy with `--warn-unreachable` flag\r\n\r\n**Expected Behavior**\r\n\r\n\u003c!--\r\nHow did you expect mypy to behave? It’s fine if you’re not sure your understanding is correct.\r\nWrite down what you thought would happen. If you expected no errors, delete this section.\r\n-->\r\nNo errors\r\n\r\n**Actual Behavior**\r\n\r\n\u003c!-- What went wrong? Paste mypy's output. -->\r\n```\r\n$ mypy .vscode/scratch.py\r\n.vscode/scratch.py: note: In function \"foo\":\r\n.vscode/scratch.py:9: error: Statement is unreachable [unreachable]\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\nThe error seems to only happen when checking if arg is `None`, but not with other types. For example, I tired changing `if arg is None:` line to the following and these were the results.\r\n\r\n1. `if arg is True:` -> no errors\r\n2. `if isinstance(arg, int):` -> no errors\r\n3. `if isinstance(arg, type(None)):` -> unreachable error\r\n4. `if arg == None:` -> No error\r\n\r\nAlso, changing the type to `T | None` removes the error as well.\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: mypy 1.13.0 (compiled: yes)\r\n- Mypy command-line flags:\r\n- Mypy configuration options from `mypy.ini` (and other config files): `warn_unreachable = True`\r\n- Python version used: 3.12\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n","author":{"url":"https://github.com/Cnoor0171","@type":"Person","name":"Cnoor0171"},"datePublished":"2024-11-07T18:18:23Z","url":"https://github.com/python/mypy/issues/18126"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:da07cc10-c404-a245-392d-8e37a0b74874 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BD70:22E601:3EEC88:54C858:6B002AFE |
| html-safe-nonce | 41f1956c7b34d0efc8134aabbd0d1eeb452118883d1d691128d29c83d3a38ec0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDcwOjIyRTYwMTozRUVDODg6NTRDODU4OjZCMDAyQUZFIiwidmlzaXRvcl9pZCI6IjE0MTQ3NTY5Mzc2OTc4NjQ0NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e18ab6002a423456e39a5d74d0771b2d32a022c13fad354f7bf78e4502099d01 |
| hovercard-subject-tag | issue:2641821118 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/18126/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ea1e6e69d3aecdf6efb35e6859f4f1de778ee85cb1b505dcfab066483b62c10a/python/mypy/issues/18126 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ea1e6e69d3aecdf6efb35e6859f4f1de778ee85cb1b505dcfab066483b62c10a/python/mypy/issues/18126 |
| og:image:alt | Bug Report Mypy doesn't seem to like it when you check if an argument with typevar type is checked to see if it is None. It incorrectly reports error: Statement is unreachable [unreachable] To Repr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Cnoor0171 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width