Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy · GitHub
Open Graph Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy
X Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy
Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Statement, and possibly Var and related typ...
Open Graph Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta...
X Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta...
Opengraph URL: https://github.com/python/mypy/issues/1783
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add stronger typing to nodes.py","articleBody":"We should have a subclass `Expression` of `Node`, make all the `*Expr` node types inherit from it, and make all the fields of `Node`s that are intended to be expressions into `Expression`s. Similarly for `Statement`, and possibly `Var` and related types.\n\n`NodeVisitor` should be parameterized on at least two types, namely the return type on expressions and the return type on other things (mostly statements). `Node`'s `accept` method should be moved into `Expression` and `Statement` (etc.), returning different type parameters of the `NodeVisitor`. Then `TypeChecker` can become a `NodeVisitor[Type, None]`, meaning that it returns a type on an expression but returns nothing on a statement.\n\nThen `TypeChecker`'s `visit_*_stmt` methods wouldn't all be returning `None` where a `Type` was expected. So this is pretty important for getting mypy to type check itself under strict optional checking, which was my original motivation, but I think this refactoring is a good idea anyways: more specific types for the fields of `Node` subtypes give more information about what values are actually legal, which is helpful when either producing or consuming those nodes.\n\nI don't want to do this refactoring right now as it's fairly large, and the parser is one of the things heavily affected, and we currently have two of those. Better to wait until after the old parser is gone.\n","author":{"url":"https://github.com/rwbarton","@type":"Person","name":"rwbarton"},"datePublished":"2016-07-01T15:00:21Z","url":"https://github.com/python/mypy/issues/1783"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:38d4c1d0-5397-63ab-6154-6315e60c602b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C808:33DDEF:25CAC9B:33DA580:6B0048C3 |
| html-safe-nonce | 7fb33c2ab8f28973cb19505dc5faadcccad0e077f4def30ddb9fed10fa312d24 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODA4OjMzRERFRjoyNUNBQzlCOjMzREE1ODA6NkIwMDQ4QzMiLCJ2aXNpdG9yX2lkIjoiNTg4NTQ2ODY5NDgxMjgzODA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d88bf978d237dbc85860011b1abadecd07696c4616bfb6eb7c947f3367ed85f8 |
| hovercard-subject-tag | issue:163413950 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1783/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4d7df7784fd6ad65650ed2602c1c82643be322fe3fa92cf0268c15a1f1959d24/python/mypy/issues/1783 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4d7df7784fd6ad65650ed2602c1c82643be322fe3fa92cf0268c15a1f1959d24/python/mypy/issues/1783 |
| og:image:alt | We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rwbarton |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width