René's URL Explorer Experiment


Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy · GitHub

Open Graph Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy

X Title: Add stronger typing to nodes.py · Issue #1783 · python/mypy

Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Statement, and possibly Var and related typ...

Open Graph Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta...

X Description: We should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta...

Opengraph URL: https://github.com/python/mypy/issues/1783

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add stronger typing to nodes.py","articleBody":"We should have a subclass `Expression` of `Node`, make all the `*Expr` node types inherit from it, and make all the fields of `Node`s that are intended to be expressions into `Expression`s. Similarly for `Statement`, and possibly `Var` and related types.\n\n`NodeVisitor` should be parameterized on at least two types, namely the return type on expressions and the return type on other things (mostly statements). `Node`'s `accept` method should be moved into `Expression` and `Statement` (etc.), returning different type parameters of the `NodeVisitor`. Then `TypeChecker` can become a `NodeVisitor[Type, None]`, meaning that it returns a type on an expression but returns nothing on a statement.\n\nThen `TypeChecker`'s `visit_*_stmt` methods wouldn't all be returning `None` where a `Type` was expected. So this is pretty important for getting mypy to type check itself under strict optional checking, which was my original motivation, but I think this refactoring is a good idea anyways: more specific types for the fields of `Node` subtypes give more information about what values are actually legal, which is helpful when either producing or consuming those nodes.\n\nI don't want to do this refactoring right now as it's fairly large, and the parser is one of the things heavily affected, and we currently have two of those. Better to wait until after the old parser is gone.\n","author":{"url":"https://github.com/rwbarton","@type":"Person","name":"rwbarton"},"datePublished":"2016-07-01T15:00:21Z","url":"https://github.com/python/mypy/issues/1783"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:38d4c1d0-5397-63ab-6154-6315e60c602b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC808:33DDEF:25CAC9B:33DA580:6B0048C3
html-safe-nonce7fb33c2ab8f28973cb19505dc5faadcccad0e077f4def30ddb9fed10fa312d24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODA4OjMzRERFRjoyNUNBQzlCOjMzREE1ODA6NkIwMDQ4QzMiLCJ2aXNpdG9yX2lkIjoiNTg4NTQ2ODY5NDgxMjgzODA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd88bf978d237dbc85860011b1abadecd07696c4616bfb6eb7c947f3367ed85f8
hovercard-subject-tagissue:163413950
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1783/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4d7df7784fd6ad65650ed2602c1c82643be322fe3fa92cf0268c15a1f1959d24/python/mypy/issues/1783
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4d7df7784fd6ad65650ed2602c1c82643be322fe3fa92cf0268c15a1f1959d24/python/mypy/issues/1783
og:image:altWe should have a subclass Expression of Node, make all the *Expr node types inherit from it, and make all the fields of Nodes that are intended to be expressions into Expressions. Similarly for Sta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerwbarton
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/1783#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1783
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1783
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/1783
Reloadhttps://github.com/python/mypy/issues/1783
Reloadhttps://github.com/python/mypy/issues/1783
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1783
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1783
Add stronger typing to nodes.pyhttps://github.com/python/mypy/issues/1783#top
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jul 1, 2016https://github.com/python/mypy/issues/1783#issue-163413950
rwbartonhttps://github.com/rwbarton
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
on Jul 1, 2016https://github.com/python/mypy/issues/1783#event-710602290
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jul 1, 2016https://github.com/python/mypy/issues/1783#issuecomment-229974974
rwbartonhttps://github.com/rwbarton
on Jul 1, 2016https://github.com/python/mypy/issues/1783#event-710656512
Mark Node types as Statements or Expressionshttps://github.com/rwbarton/mypy/commit/70aaeedcbea39bda1c9e36b307fef156073a4d40
70aaeedhttps://github.com/rwbarton/mypy/commit/70aaeedcbea39bda1c9e36b307fef156073a4d40
Mark Node types as Statements or Expressionshttps://github.com/rwbarton/mypy/commit/e644730e8de0b4d39e76c7c5c19cdb1c1937d4ac
e644730https://github.com/rwbarton/mypy/commit/e644730e8de0b4d39e76c7c5c19cdb1c1937d4ac
gvanrossumhttps://github.com/gvanrossum
on Jul 1, 2016https://github.com/python/mypy/issues/1783#event-710669390
Mark Node types as Statements or Expressions (#1785)https://github.com/python/mypy/commit/baf2d78eda47bddb39ed29e6f1393168d7c75e9e
#1785https://github.com/python/mypy/pull/1785
baf2d78https://github.com/python/mypy/commit/baf2d78eda47bddb39ed29e6f1393168d7c75e9e
gvanrossumhttps://github.com/gvanrossum
on Jul 7, 2016https://github.com/python/mypy/issues/1783#event-716348198
gvanrossumhttps://github.com/gvanrossum
on Oct 3, 2016https://github.com/python/mypy/issues/1783#event-810624744
Make Expression, Statement true subclasses of Node. See #1783.https://github.com/python/mypy/commit/640921b33e2d37a23aaab07b4dc4302ef5aae09b
#1783https://github.com/python/mypy/issues/1783
640921bhttps://github.com/python/mypy/commit/640921b33e2d37a23aaab07b4dc4302ef5aae09b
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 31, 2016https://github.com/python/mypy/issues/1783#issuecomment-257446784
@elazarghttps://github.com/elazarg
@rwbartonhttps://github.com/rwbarton
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Nov 1, 2016https://github.com/python/mypy/issues/1783#issuecomment-257467303
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Nov 1, 2016https://github.com/python/mypy/issues/1783#issuecomment-257468276
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Nov 1, 2016https://github.com/python/mypy/issues/1783#issuecomment-257471588
gvanrossumhttps://github.com/gvanrossum
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Jan 6, 2017https://github.com/python/mypy/issues/1783#event-914699378
gvanrossumhttps://github.com/gvanrossum
on Mar 29, 2017https://github.com/python/mypy/issues/1783#event-1021274380
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Apr 3, 2017https://github.com/python/mypy/issues/1783#issuecomment-291266774
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Apr 3, 2017https://github.com/python/mypy/issues/1783#issuecomment-291315804
gvanrossumhttps://github.com/gvanrossum
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2017https://github.com/python/mypy/issues/1783#event-1027455218
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/1783
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/1783
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.