René's URL Explorer Experiment


Title: Support typing.Union/typing.Optional in isinstance check (/support old-style unions) · Issue #17680 · python/mypy · GitHub

Open Graph Title: Support typing.Union/typing.Optional in isinstance check (/support old-style unions) · Issue #17680 · python/mypy

X Title: Support typing.Union/typing.Optional in isinstance check (/support old-style unions) · Issue #17680 · python/mypy

Description: Preamble This issue may already exists but I was unable to find an exact match. There are plenty of issues related to the PEP 604 syntax but none that are really about using typing.Union/typing.Optional/... Support for PEP 604 syntax was...

Open Graph Description: Preamble This issue may already exists but I was unable to find an exact match. There are plenty of issues related to the PEP 604 syntax but none that are really about using typing.Union/typing.Opt...

X Description: Preamble This issue may already exists but I was unable to find an exact match. There are plenty of issues related to the PEP 604 syntax but none that are really about using typing.Union/typing.Opt...

Opengraph URL: https://github.com/python/mypy/issues/17680

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support typing.Union/typing.Optional in isinstance check (/support old-style unions)","articleBody":"**Preamble**\r\n\r\n- This issue may already exists but I was unable to find an exact match. There are plenty of issues related to the PEP 604 syntax but none that are really about using `typing.Union`/`typing.Optional`/...\r\n- Support for PEP 604 syntax was recently added in  #11673 / #17371 \r\n- Old style unions were briefly mentioned in https://github.com/python/mypy/pull/17371#pullrequestreview-2115445793\r\n\r\n**Feature**\r\n\r\nExample code\r\n\r\n```python\r\nfrom typing import Any, Union, Optional\r\n\r\nfoo: Any = None\r\n\r\nif isinstance(foo, int | None):\r\n    reveal_type(foo)\r\n\r\nif isinstance(foo, Union[int, None]):\r\n    reveal_type(foo)\r\n\r\nif isinstance(foo, Optional[int]):\r\n    reveal_type(foo)\r\n\r\nbar = int | None\r\nbaz = Optional[int]\r\nif isinstance(foo, bar):\r\n    reveal_type(foo)\r\n\r\nif isinstance(foo, baz):\r\n    reveal_type(foo)\r\n```\r\n\r\nOutput for the above with mypy v1.11.1:\r\n```\r\nsrc/union.py:6: note: Revealed type is \"Union[builtins.int, None]\"\r\nsrc/union.py:8: error: Argument 2 to \"isinstance\" has incompatible type \"\u003ctyping special form>\"; expected \"_ClassInfo\"  [arg-type]\r\nsrc/union.py:9: note: Revealed type is \"Any\"\r\nsrc/union.py:11: error: Argument 2 to \"isinstance\" has incompatible type \"\u003ctyping special form>\"; expected \"_ClassInfo\"  [arg-type]\r\nsrc/union.py:12: note: Revealed type is \"Any\"\r\nsrc/union.py:17: note: Revealed type is \"Union[builtins.int, None]\"\r\nsrc/union.py:19: error: Parameterized generics cannot be used with class or instance checks  [misc]\r\nsrc/union.py:19: error: Argument 2 to \"isinstance\" has incompatible type \"\u003ctyping special form>\"; expected \"_ClassInfo\"  [arg-type]\r\nsrc/union.py:20: note: Revealed type is \"Any\"\r\nFound 4 errors in 1 file (checked 1 source file)\r\n```\r\n\r\nRunning the above with pyright:\r\n```\r\n.../src/union.py\r\n  .../src/union.py:6:17 - information: Type of \"foo\" is \"int | None\"\r\n  .../src/union.py:9:17 - information: Type of \"foo\" is \"int | None\"\r\n  .../src/union.py:12:17 - information: Type of \"foo\" is \"int | None\"\r\n  .../src/union.py:17:17 - information: Type of \"foo\" is \"int | None\"\r\n  .../src/union.py:20:17 - information: Type of \"foo\" is \"int | None\"\r\n0 errors, 0 warnings, 5 informations\r\n```\r\n\r\nSummary:\r\n- when using the PEP 604-syntax the type is correctly narrowed to `Union[builtins.int, None]`\r\n- when using the `typing.Union` and/or `typing.Optional` syntax the type is not narrowed and remains `Any` (and errors are shown)\r\n","author":{"url":"https://github.com/bram-tv","@type":"Person","name":"bram-tv"},"datePublished":"2024-08-15T14:17:43Z","url":"https://github.com/python/mypy/issues/17680"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e5c08b6e-1e44-d1b6-d098-5c022c4dd152
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C42:1BCD46:E1E8F0:12FA1AC:6B005825
html-safe-nonce5e83ef49825816af35bfd27821aa987b7f398fb6b420c17e77aa1b2e2bef24cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQyOjFCQ0Q0NjpFMUU4RjA6MTJGQTFBQzo2QjAwNTgyNSIsInZpc2l0b3JfaWQiOiIzMTQxNTkyMzk0OTY1NzM1NDYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac27a894648c48b345088b14ee8468acb8deb579eac50d36bd24ab3e6020cbf676
hovercard-subject-tagissue:2468140685
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17680/issue_layout
twitter:imagehttps://opengraph.githubassets.com/aa257af569dfcafa3cef53f6ec4d34b8bf0519d0e712a71c9fad0fbc35b4922f/python/mypy/issues/17680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa257af569dfcafa3cef53f6ec4d34b8bf0519d0e712a71c9fad0fbc35b4922f/python/mypy/issues/17680
og:image:altPreamble This issue may already exists but I was unable to find an exact match. There are plenty of issues related to the PEP 604 syntax but none that are really about using typing.Union/typing.Opt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebram-tv
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/17680#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17680
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17680
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/17680
Reloadhttps://github.com/python/mypy/issues/17680
Reloadhttps://github.com/python/mypy/issues/17680
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17680
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17680
#19714https://github.com/python/mypy/pull/19714
Support typing.Union/typing.Optional in isinstance check (/support old-style unions)https://github.com/python/mypy/issues/17680#top
#19714https://github.com/python/mypy/pull/19714
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
https://github.com/bram-tv
bram-tvhttps://github.com/bram-tv
on Aug 15, 2024https://github.com/python/mypy/issues/17680#issue-2468140685
isinstance doesn't work on type aliases that use a union #11673https://github.com/python/mypy/issues/11673
Fix isinstance with type aliases to PEP 604 unions #17371https://github.com/python/mypy/pull/17371
Fix isinstance with type aliases to PEP 604 unions #17371 (review)https://github.com/python/mypy/pull/17371#pullrequestreview-2115445793
bram-tvhttps://github.com/bram-tv
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Aug 15, 2024https://github.com/python/mypy/issues/17680#event-13896395792
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 16, 2024https://github.com/python/mypy/issues/17680#issuecomment-2292550194
hauntsaninjahttps://github.com/hauntsaninja
on Aug 22, 2025https://github.com/python/mypy/issues/17680#event-19282702631
Somewhat better support for isinstance on old-style unionshttps://github.com/hauntsaninja/mypy/commit/320f33321d6d4d5a6138ae2d9adade40f89342a7
https://docs.github.com/articles/closing-issues-via-commit-messages
320f333https://github.com/hauntsaninja/mypy/commit/320f33321d6d4d5a6138ae2d9adade40f89342a7
Somewhat better support for isinstance on old-style unions (#19714)https://github.com/python/mypy/commit/ac4cacbba3c8511bb591fd11f813de66e79a7aa7
#19714https://github.com/python/mypy/pull/19714
https://docs.github.com/articles/closing-issues-via-commit-messages
ac4cacbhttps://github.com/python/mypy/commit/ac4cacbba3c8511bb591fd11f813de66e79a7aa7
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#19714https://github.com/python/mypy/pull/19714
on Aug 23, 2025https://github.com/python/mypy/issues/17680#event-19297188548
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/17680
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/17680
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.