Title: `functools.partial` plugin is only triggered on calls · Issue #17620 · python/mypy · GitHub
Open Graph Title: `functools.partial` plugin is only triggered on calls · Issue #17620 · python/mypy
X Title: `functools.partial` plugin is only triggered on calls · Issue #17620 · python/mypy
Description: Bug Report partial support is too fragile and easy to fool. To Reproduce import typing as t from functools import partial # 1. # uncomment this to get type error # partial(lambda x, y: x + y, 10)() # 2. # But this silly little thing pass...
Open Graph Description: Bug Report partial support is too fragile and easy to fool. To Reproduce import typing as t from functools import partial # 1. # uncomment this to get type error # partial(lambda x, y: x + y, 10)()...
X Description: Bug Report partial support is too fragile and easy to fool. To Reproduce import typing as t from functools import partial # 1. # uncomment this to get type error # partial(lambda x, y: x + y, 10)()...
Opengraph URL: https://github.com/python/mypy/issues/17620
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`functools.partial` plugin is only triggered on calls","articleBody":"\u003c!--\r\nIf you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form instead.\r\nPlease consider:\r\n\r\n- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\r\n- searching our issue tracker: https://github.com/python/mypy/issues to see if it's already been reported\r\n- asking on gitter chat: https://gitter.im/python/typing\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nIf you're reporting a problem with a specific library function, the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues\r\n\r\nIf the project you encountered the issue in is open source, please provide a link to the project.\r\n-->\r\n\r\n`partial` support is too fragile and easy to fool.\r\n\r\n**To Reproduce**\r\n\r\n```python\r\nimport typing as t\r\nfrom functools import partial\r\n\r\n# 1.\r\n# uncomment this to get type error\r\n# partial(lambda x, y: x + y, 10)()\r\n\r\n# 2.\r\n# But this silly little thing passes type-check\r\nsilly: t.Callable[[], int] = partial(lambda x, y: x + y, 10)\r\nsilly()\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nFail to coerce partial into incompatible callable type.\r\n\r\n\u003c!--\r\nHow did you expect mypy to behave? It’s fine if you’re not sure your understanding is correct.\r\nWrite down what you thought would happen. If you expected no errors, delete this section.\r\n-->\r\n\r\n**Actual Behavior**\r\n\r\n\u003c!-- What went wrong? Paste mypy's output. -->\r\nSuccess: no issues found in 1 source file\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: master\r\n- Mypy command-line flags: no\r\n- Mypy configuration options from `mypy.ini` (and other config files):\r\n- Python version used: 3.12\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n\r\nLooks like we carry information about needed arguments somewhere anyways, since `1` fails type check due to not enough arguments, so why we allow to coerce that partial into incompatible callable?\r\nPerhaps this is due to [this](https://github.com/python/typeshed/blob/17af88919f23b909f7e87eb6bd0877c383c9227d/stdlib/functools.pyi#L125-L135) definition of partial:\r\n```python\r\n def __call__(self, /, *args: Any, **kwargs: Any) -> _T: ...\r\n```\r\nBut, for example, `pyright` takes that into account and fails as expected:\r\n```\r\n[nix-shell:/tmp]$ pyright issue.py\r\n/tmp/issue.py\r\n /tmp/issue.py:10:30 - error: Expression of type \"partial[Unknown]\" is incompatible with declared type \"() -> int\"\r\n Type \"partial[Unknown]\" is incompatible with type \"() -> int\"\r\n Extra parameter \"y\" (reportAssignmentType)\r\n1 error, 0 warnings, 0 informations\r\n```\r\n\r\nI think it worth fixing, since we support `partial` and it is useful to rely on that support. It can be fixed, for example, as viewing `partial` result internally not as `partial[int]` type, but as something like\r\n```python\r\nclass FakePartial(Protocol[P, Ret]):\r\n @property\r\n def args(self) -> tuple[Any, ...]: ...\r\n \r\n @property\r\n def keywords(self) -> dict[any, ...]: ...\r\n\r\n @property\r\n def func(self) -> t.Callable[..., Ret]: ...\r\n\r\n def __call__(self, *args: P.args, **kwargs: P.kwargs) -> Ret: ...\r\n```\r\n","author":{"url":"https://github.com/nerodono","@type":"Person","name":"nerodono"},"datePublished":"2024-08-01T21:04:41Z","url":"https://github.com/python/mypy/issues/17620"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a2d8aa97-a983-e60f-dbb0-a4bb6c7aa2b6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BA8E:2463C6:50538E:6BC1D0:6B003036 |
| html-safe-nonce | f6c31b1ba46de8d892375868b585567dff481737726885a30d9afd9871042627 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQThFOjI0NjNDNjo1MDUzOEU6NkJDMUQwOjZCMDAzMDM2IiwidmlzaXRvcl9pZCI6IjM0NTI1NjM2Mzk0MDIyNDYxOTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 81729a36ad304208fb5dc61e274c1bc42a773649c972a29e7c06d367107c9413 |
| hovercard-subject-tag | issue:2443438266 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17620/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f3f4a4c8ce67b263a2631e89dbff610bc4e09e29e9f214559d39903482a1adc6/python/mypy/issues/17620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f3f4a4c8ce67b263a2631e89dbff610bc4e09e29e9f214559d39903482a1adc6/python/mypy/issues/17620 |
| og:image:alt | Bug Report partial support is too fragile and easy to fool. To Reproduce import typing as t from functools import partial # 1. # uncomment this to get type error # partial(lambda x, y: x + y, 10)()... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nerodono |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width