Title: 1.11 regression: "generic" mapping failing with confusing error message · Issue #17566 · python/mypy · GitHub
Open Graph Title: 1.11 regression: "generic" mapping failing with confusing error message · Issue #17566 · python/mypy
X Title: 1.11 regression: "generic" mapping failing with confusing error message · Issue #17566 · python/mypy
Description: Bug Report I've boiled down a minimal example -- this pattern is used by pyupgrade (and reorder-python-imports) to register ast functions and has been working with mypy since version 0.710 -- but was broken with the last update sadly To ...
Open Graph Description: Bug Report I've boiled down a minimal example -- this pattern is used by pyupgrade (and reorder-python-imports) to register ast functions and has been working with mypy since version 0.710 -- but w...
X Description: Bug Report I've boiled down a minimal example -- this pattern is used by pyupgrade (and reorder-python-imports) to register ast functions and has been working with mypy since version 0.710 -- b...
Opengraph URL: https://github.com/python/mypy/issues/17566
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"1.11 regression: \"generic\" mapping failing with confusing error message","articleBody":"\r\n**Bug Report**\r\n\r\nI've boiled down a minimal example -- this pattern is used by `pyupgrade` (and `reorder-python-imports`) to register ast functions and has been working with mypy since version 0.710 -- but was broken with the last update sadly\r\n\r\n**To Reproduce**\r\n\r\nthis is a simplified version of [pyupgrade/_data.py](https://github.com/asottile/pyupgrade/blob/main/pyupgrade/_data.py) -- `FUNCS` acts as a mapping from ast types to their callback functions\r\n\r\n```python\r\nimport ast\r\nimport collections\r\nfrom typing import Callable, Protocol, TypeVar\r\n\r\nAST_T = TypeVar('AST_T', bound=ast.AST)\r\nASTFunc = Callable[[AST_T], None]\r\n\r\nFUNCS = collections.defaultdict(list)\r\n\r\ndef register(tp: type[AST_T]) -> Callable[[ASTFunc[AST_T]], ASTFunc[AST_T]]:\r\n def register_decorator(func: ASTFunc[AST_T]) -> ASTFunc[AST_T]:\r\n FUNCS[tp].append(func)\r\n return func\r\n return register_decorator\r\n\r\n\r\nclass ASTCallbackMapping(Protocol):\r\n def __getitem__(self, tp: type[AST_T]) -> list[ASTFunc[AST_T]]: ...\r\n\r\ndef visit(funcs: ASTCallbackMapping) -> None: ...\r\n\r\n\r\ndef f() -> None:\r\n visit(FUNCS)\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nthe behaviour pre-mypy-1.11:\r\n\r\n(no errors)\r\n\r\n**Actual Behavior**\r\n\r\n```console\r\n$ mypy t.py \r\nt.py:24: error: Argument 1 to \"visit\" has incompatible type \"defaultdict[type[AST_T], list[Callable[[AST_T], None]]]\"; expected \"ASTCallbackMapping\" [arg-type]\r\nt.py:24: note: Following member(s) of \"defaultdict[type[AST_T], list[Callable[[AST_T], None]]]\" have conflicts:\r\nt.py:24: note: Expected:\r\nt.py:24: note: def [AST_T: AST] __getitem__(self, type[AST_T], /) -> list[Callable[[AST_T], None]]\r\nt.py:24: note: Got:\r\nt.py:24: note: def __getitem__(self, type[AST_T], /) -> list[Callable[[AST_T], None]]\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\nthe error message seems suspicious because I think those two are the same ?\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 1.11.0\r\n- Mypy command-line flags: none\r\n- Mypy configuration options from `mypy.ini` (and other config files): none\r\n- Python version used: 3.10.12 -- though really anything modern\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n","author":{"url":"https://github.com/asottile","@type":"Person","name":"asottile"},"datePublished":"2024-07-23T00:10:20Z","url":"https://github.com/python/mypy/issues/17566"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:94e804a3-5175-b2f0-212d-191e47d72f26 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E2F2:2A0045:25CA185:313F853:6AFFF8CB |
| html-safe-nonce | 8ff2805b067d02c241180a9cb69f551ddf0ac41e2da704f010a4e8e39d0bed87 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkYyOjJBMDA0NToyNUNBMTg1OjMxM0Y4NTM6NkFGRkY4Q0IiLCJ2aXNpdG9yX2lkIjoiMjQwMjYxODY2NTgyMTI3MjI2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c863fee581d6d5bdde1f84e195e4251a8b9616a55897210a07f82badb7189433 |
| hovercard-subject-tag | issue:2423986498 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17566/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9e0789008c7af0c83d72b010c54f5c122665924b2f8cca578dc0eef5290ed0b0/python/mypy/issues/17566 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9e0789008c7af0c83d72b010c54f5c122665924b2f8cca578dc0eef5290ed0b0/python/mypy/issues/17566 |
| og:image:alt | Bug Report I've boiled down a minimal example -- this pattern is used by pyupgrade (and reorder-python-imports) to register ast functions and has been working with mypy since version 0.710 -- but w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | asottile |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width