René's URL Explorer Experiment


Title: Combining two type checks with `and` deduces `Any` if the first is `Any` · Issue #17100 · python/mypy · GitHub

Open Graph Title: Combining two type checks with `and` deduces `Any` if the first is `Any` · Issue #17100 · python/mypy

X Title: Combining two type checks with `and` deduces `Any` if the first is `Any` · Issue #17100 · python/mypy

Description: Combining two isinstance checks with and where the first one deduces the type to Any ignores the second one. To Reproduce from typing import Any, reveal_type class A: pass class B(A): pass value: Any if isinstance(value, A) and not isins...

Open Graph Description: Combining two isinstance checks with and where the first one deduces the type to Any ignores the second one. To Reproduce from typing import Any, reveal_type class A: pass class B(A): pass value: A...

X Description: Combining two isinstance checks with and where the first one deduces the type to Any ignores the second one. To Reproduce from typing import Any, reveal_type class A: pass class B(A): pass value: A...

Opengraph URL: https://github.com/python/mypy/issues/17100

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Combining two type checks with `and` deduces `Any` if the first is `Any`","articleBody":"Combining two `isinstance` checks with `and` where the first one deduces the type to `Any` ignores the second one.\r\n\r\n**To Reproduce**\r\n\r\n```python\r\nfrom typing import Any, reveal_type\r\n\r\nclass A: pass\r\nclass B(A): pass  \r\nvalue: Any\r\n\r\nif isinstance(value, A) and not isinstance(value, B):\r\n    reveal_type(value)\r\nif not isinstance(value, B) and isinstance(value, A):\r\n    reveal_type(value)\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.12&gist=643066dcf62c1c2b88bb4714032fa8b5\r\n\r\n**Expected Behavior**\r\n\r\nMypy should deduce the type as `A` in both cases:\r\n\r\n```\r\nmain.py:8: note: Revealed type is \"__main__.A\"\r\nmain.py:10: note: Revealed type is \"__main__.A\"\r\n```\r\n\r\n**Actual Behavior**\r\n\r\n```\r\nmain.py:8: note: Revealed type is \"__main__.A\"\r\nmain.py:10: note: Revealed type is \"Any\"\r\n```\r\n\r\n**Background**\r\n\r\nThis worked before mypy 1.7 and is a regression caused by #16237. The direct reason is that `Any` is now preferred in some circumstances in `and_conditional_maps()` (the `isinstance` in the `if`):\r\n\r\nhttps://github.com/python/mypy/blob/80190101f68b52e960c22572ed6cc814de078b9c/mypy/checker.py#L7609-L7618\r\n\r\nI'm not sure why this is the case or why it is needed to prefer `Any` here. Intuitively, it should be the other way around. The additional `Any` doesn't add any new information but it shouldn't destroy the information already known from other sources.\r\n\r\nWhen I remove the `or isinstance(get_proper_type(m1[n1]), AnyType)` in the above code, only one testcase fails (in `testNarrowingWithAnyOps`) because it explicitly tests for this `Any` result, like this:\r\n\r\n```\r\nclass C: ...\r\nclass D(C): ...\r\ntp: Any\r\n...\r\n\r\nc1: C\r\nif isinstance(c1, tp) and isinstance(c1, D):\r\n    reveal_type(c1)  # N: Revealed type is \"Any\"\r\n```\r\n\r\nWith the changed code this deduces the type as `D` instead.\r\n\r\n","author":{"url":"https://github.com/sth","@type":"Person","name":"sth"},"datePublished":"2024-04-05T08:48:46Z","url":"https://github.com/python/mypy/issues/17100"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:eee97037-83aa-d4db-4a3a-d4647b0bc17f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8876:18E7F5:D594D2:1168E85:6AFFF7E5
html-safe-nonce74e4ab1c0a233e3260a4da152c6dd252367b3622d589f7a572d78b72f0192019
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODc2OjE4RTdGNTpENTk0RDI6MTE2OEU4NTo2QUZGRjdFNSIsInZpc2l0b3JfaWQiOiIyNDgyMDI0NjA5NjAwMjM5NTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd96e7c25551ce6fd1b3f43685faeffc096530101943dba5fbfcc976d6c649f74
hovercard-subject-tagissue:2227418444
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17100/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a4fcb9093b9cffb7e7b0ae4f88f2bca459adeb79a25a1c8000b0231b1b5ed4d1/python/mypy/issues/17100
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4fcb9093b9cffb7e7b0ae4f88f2bca459adeb79a25a1c8000b0231b1b5ed4d1/python/mypy/issues/17100
og:image:altCombining two isinstance checks with and where the first one deduces the type to Any ignores the second one. To Reproduce from typing import Any, reveal_type class A: pass class B(A): pass value: A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesth
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/17100#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17100
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17100
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/17100
Reloadhttps://github.com/python/mypy/issues/17100
Reloadhttps://github.com/python/mypy/issues/17100
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17100
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17100
#21167https://github.com/python/mypy/pull/21167
Combining two type checks with and deduces Any if the first is Anyhttps://github.com/python/mypy/issues/17100#top
#21167https://github.com/python/mypy/pull/21167
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/sth
sthhttps://github.com/sth
on Apr 5, 2024https://github.com/python/mypy/issues/17100#issue-2227418444
https://mypy-play.net/?mypy=latest&python=3.12&gist=643066dcf62c1c2b88bb4714032fa8b5https://mypy-play.net/?mypy=latest&python=3.12&gist=643066dcf62c1c2b88bb4714032fa8b5
#16237https://github.com/python/mypy/pull/16237
mypy/mypy/checker.pyhttps://github.com/python/mypy/blob/80190101f68b52e960c22572ed6cc814de078b9c/mypy/checker.py#L7609-L7618
8019010https://github.com/python/mypy/commit/80190101f68b52e960c22572ed6cc814de078b9c
sthhttps://github.com/sth
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Apr 5, 2024https://github.com/python/mypy/issues/17100#event-12370214894
https://github.com/sth
sthhttps://github.com/sth
on May 4, 2024https://github.com/python/mypy/issues/17100#issuecomment-2094348597
@ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/yonilerner
yonilernerhttps://github.com/yonilerner
on Jun 27, 2024https://github.com/python/mypy/issues/17100#issuecomment-2195749126
https://mypy-play.net/?mypy=master&python=3.11&gist=a89cc8d27cb963b8b5919595f73894b8https://mypy-play.net/?mypy=master&python=3.11&gist=a89cc8d27cb963b8b5919595f73894b8
hauntsaninjahttps://github.com/hauntsaninja
on Apr 9, 2026https://github.com/python/mypy/issues/17100#event-24345739075
Narrow Any in and_conditional_map (#21167)https://github.com/python/mypy/commit/ef28d9c2ca6476a9cffeb6c1e8dbe1a9432fda90
#21167https://github.com/python/mypy/pull/21167
https://docs.github.com/articles/closing-issues-via-commit-messages
ef28d9chttps://github.com/python/mypy/commit/ef28d9c2ca6476a9cffeb6c1e8dbe1a9432fda90
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#21167https://github.com/python/mypy/pull/21167
on Apr 9, 2026https://github.com/python/mypy/issues/17100#event-24345739378
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/17100
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/17100
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.