Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy · GitHub
Open Graph Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy
X Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy
Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [mypy-play.net] # from __future__ import a...
Open Graph Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [m...
X Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy...
Opengraph URL: https://github.com/python/mypy/issues/17047
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy sometimes confuses nested classes-in-functions which share the same name","articleBody":"**Bug Report**\r\n\r\nIn some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes.\r\n\r\n**To Reproduce**\r\n\r\nCheck the following ~minimal example with mypy:\r\n\r\n[[mypy-play.net](https://mypy-play.net/?mypy=latest&python=3.12&gist=eaecd26c13952908fab01f0a4de89324)]\r\n```python\r\n# from __future__ import annotations # with or without makes no difference\r\n\r\ndef test_a() -> None:\r\n\r\n class SomeClass: # line 5\r\n def some_method(self) -> None:\r\n _ = some_var # line 7\r\n\r\n some_var = None # not necessary for repro; stops error on line 7\r\n\r\ndef test_b() -> None:\r\n\r\n instance: SomeClass\r\n\r\n class SomeClass: # line 15\r\n pass\r\n\r\n instance = SomeClass()\r\n # error: Incompatible types in assignment (expression\r\n # has type \"SomeClass@15\", variable has type\r\n # \"SomeClass@5\") [assignment]\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nNo errors.\r\n\r\n**Actual Behavior**\r\n\r\nThe tool confuses the two classes of the same name (`SomeClass`), despite these being declared in entirely different scopes.\r\n\r\n**Bisection**\r\n\r\nThe problem appears to have been introduced by https://github.com/python/mypy/commit/389a1725c1df7fad4e2605360157c9f910cb502c (which made its way into mypy 0.900):\r\n```\r\n389a1725c1df7fad4e2605360157c9f910cb502c is the first bad commit\r\ncommit 389a1725c1df7fad4e2605360157c9f910cb502c\r\nAuthor: Jukka Lehtosalo \u003cjukka.lehtosalo@iki.fi>\r\nDate: Thu May 6 14:32:36 2021 +0100\r\n\r\n Fix crash with nested NamedTuple in incremental mode (#10431)\r\n\r\n The name of the nested tuple type was inconsistent. Sometimes if was stored\r\n using the full name in the module symbol table.\r\n\r\n Also improve the internal API for creating classes to be less error-prone.\r\n\r\n Work on #7281.\r\n\r\n mypy/semanal.py | 10 +++++++---\r\n mypy/semanal_enum.py | 9 +++++----\r\n mypy/semanal_namedtuple.py | 2 +-\r\n mypy/semanal_newtype.py | 11 ++++++-----\r\n mypy/semanal_shared.py | 2 +-\r\n mypy/semanal_typeddict.py | 14 ++++++++------\r\n test-data/unit/check-incremental.test | 26 ++++++++++++++++++++++++++\r\n 7 files changed, 54 insertions(+), 20 deletions(-)\r\n```\r\nProbably relates to #7281, #10431.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: 1.9.0, 0.900, but not 0.800 (see: \"bisection\")\r\n- Mypy command-line flags: _none necessary_\r\n- Mypy configuration options from `mypy.ini` (and other config files): _none necessary_\r\n- Python version used: 3.8, 3.12\r\n","author":{"url":"https://github.com/finite-state-machine","@type":"Person","name":"finite-state-machine"},"datePublished":"2024-03-19T09:40:39Z","url":"https://github.com/python/mypy/issues/17047"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:340f0eb1-c218-f1ed-08e3-3619bf20527e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B168:4D1C6:28393B7:36DCBB0:6B0049A5 |
| html-safe-nonce | 2197ccdb3840a8f7574000f2e8173ecf17e32d1c2328b49f1a71d23fb6eb23d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTY4OjREMUM2OjI4MzkzQjc6MzZEQ0JCMDo2QjAwNDlBNSIsInZpc2l0b3JfaWQiOiI0MDIxMDM0NTI0MTc0NDY5NTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de941ef3e81587c13cfd01338c18524aff702aafb2c16071c84e45da829cee21 |
| hovercard-subject-tag | issue:2194475725 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17047/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f8a32338898677e5a3bfd3281bbbac37d23435daef3f3fb55e69906c67925419/python/mypy/issues/17047 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f8a32338898677e5a3bfd3281bbbac37d23435daef3f3fb55e69906c67925419/python/mypy/issues/17047 |
| og:image:alt | Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | finite-state-machine |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width