René's URL Explorer Experiment


Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy · GitHub

Open Graph Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy

X Title: mypy sometimes confuses nested classes-in-functions which share the same name · Issue #17047 · python/mypy

Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [mypy-play.net] # from __future__ import a...

Open Graph Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [m...

X Description: Bug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy...

Opengraph URL: https://github.com/python/mypy/issues/17047

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy sometimes confuses nested classes-in-functions which share the same name","articleBody":"**Bug Report**\r\n\r\nIn some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes.\r\n\r\n**To Reproduce**\r\n\r\nCheck the following ~minimal example with mypy:\r\n\r\n[[mypy-play.net](https://mypy-play.net/?mypy=latest&python=3.12&gist=eaecd26c13952908fab01f0a4de89324)]\r\n```python\r\n# from __future__ import annotations  # with or without makes no difference\r\n\r\ndef test_a() -> None:\r\n\r\n    class SomeClass:  # line 5\r\n        def some_method(self) -> None:\r\n            _ = some_var  # line 7\r\n\r\n    some_var = None  # not necessary for repro; stops error on line 7\r\n\r\ndef test_b() -> None:\r\n\r\n    instance: SomeClass\r\n\r\n    class SomeClass:  # line 15\r\n        pass\r\n\r\n    instance = SomeClass()\r\n            # error: Incompatible types in assignment (expression\r\n            #        has type \"SomeClass@15\", variable has type\r\n            #        \"SomeClass@5\")  [assignment]\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nNo errors.\r\n\r\n**Actual Behavior**\r\n\r\nThe tool confuses the two classes of the same name (`SomeClass`), despite these being declared in entirely different scopes.\r\n\r\n**Bisection**\r\n\r\nThe problem appears to have been introduced by https://github.com/python/mypy/commit/389a1725c1df7fad4e2605360157c9f910cb502c (which made its way into mypy 0.900):\r\n```\r\n389a1725c1df7fad4e2605360157c9f910cb502c is the first bad commit\r\ncommit 389a1725c1df7fad4e2605360157c9f910cb502c\r\nAuthor: Jukka Lehtosalo \u003cjukka.lehtosalo@iki.fi>\r\nDate:   Thu May 6 14:32:36 2021 +0100\r\n\r\n    Fix crash with nested NamedTuple in incremental mode (#10431)\r\n\r\n    The name of the nested tuple type was inconsistent. Sometimes if was stored\r\n    using the full name in the module symbol table.\r\n\r\n    Also improve the internal API for creating classes to be less error-prone.\r\n\r\n    Work on #7281.\r\n\r\n mypy/semanal.py                       | 10 +++++++---\r\n mypy/semanal_enum.py                  |  9 +++++----\r\n mypy/semanal_namedtuple.py            |  2 +-\r\n mypy/semanal_newtype.py               | 11 ++++++-----\r\n mypy/semanal_shared.py                |  2 +-\r\n mypy/semanal_typeddict.py             | 14 ++++++++------\r\n test-data/unit/check-incremental.test | 26 ++++++++++++++++++++++++++\r\n 7 files changed, 54 insertions(+), 20 deletions(-)\r\n```\r\nProbably relates to #7281, #10431.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: 1.9.0, 0.900, but not 0.800 (see: \"bisection\")\r\n- Mypy command-line flags: _none necessary_\r\n- Mypy configuration options from `mypy.ini` (and other config files): _none necessary_\r\n- Python version used: 3.8, 3.12\r\n","author":{"url":"https://github.com/finite-state-machine","@type":"Person","name":"finite-state-machine"},"datePublished":"2024-03-19T09:40:39Z","url":"https://github.com/python/mypy/issues/17047"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:340f0eb1-c218-f1ed-08e3-3619bf20527e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB168:4D1C6:28393B7:36DCBB0:6B0049A5
html-safe-nonce2197ccdb3840a8f7574000f2e8173ecf17e32d1c2328b49f1a71d23fb6eb23d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTY4OjREMUM2OjI4MzkzQjc6MzZEQ0JCMDo2QjAwNDlBNSIsInZpc2l0b3JfaWQiOiI0MDIxMDM0NTI0MTc0NDY5NTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde941ef3e81587c13cfd01338c18524aff702aafb2c16071c84e45da829cee21
hovercard-subject-tagissue:2194475725
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17047/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f8a32338898677e5a3bfd3281bbbac37d23435daef3f3fb55e69906c67925419/python/mypy/issues/17047
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f8a32338898677e5a3bfd3281bbbac37d23435daef3f3fb55e69906c67925419/python/mypy/issues/17047
og:image:altBug Report In some circumstances, mypy will confuse two classes of the same name, even if they're declared in non-overlapping scopes. To Reproduce Check the following ~minimal example with mypy: [m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefinite-state-machine
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/17047#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17047
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17047
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/17047
Reloadhttps://github.com/python/mypy/issues/17047
Reloadhttps://github.com/python/mypy/issues/17047
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17047
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17047
mypy sometimes confuses nested classes-in-functions which share the same namehttps://github.com/python/mypy/issues/17047#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/finite-state-machine
finite-state-machinehttps://github.com/finite-state-machine
on Mar 19, 2024https://github.com/python/mypy/issues/17047#issue-2194475725
mypy-play.nethttps://mypy-play.net/?mypy=latest&python=3.12&gist=eaecd26c13952908fab01f0a4de89324
389a172https://github.com/python/mypy/commit/389a1725c1df7fad4e2605360157c9f910cb502c
#7281https://github.com/python/mypy/issues/7281
#10431https://github.com/python/mypy/pull/10431
finite-state-machinehttps://github.com/finite-state-machine
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Mar 19, 2024https://github.com/python/mypy/issues/17047#event-12166414594
finite-state-machinehttps://github.com/finite-state-machine
on Mar 19, 2024https://github.com/python/mypy/issues/17047#event-12166424015
https://github.com/finite-state-machine
finite-state-machinehttps://github.com/finite-state-machine
on Mar 19, 2024https://github.com/python/mypy/issues/17047#issuecomment-2007567826
@JukkaLhttps://github.com/JukkaL
tianyizheng02https://github.com/tianyizheng02
on Aug 18, 2024https://github.com/python/mypy/issues/17047#event-13921200235
Fix mypy errors and rename NamedTuple fields in gym.pyhttps://github.com/pittcsc/PittAPI/commit/1e18ead9b4b9e3b5fddd6f26143e940a94d1157b
1e18eadhttps://github.com/pittcsc/PittAPI/commit/1e18ead9b4b9e3b5fddd6f26143e940a94d1157b
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/17047
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/17047
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.