René's URL Explorer Experiment


Title: Type narrowing for ellipsis via 'is ...' failing in 1.9.0 · Issue #17002 · python/mypy · GitHub

Open Graph Title: Type narrowing for ellipsis via 'is ...' failing in 1.9.0 · Issue #17002 · python/mypy

X Title: Type narrowing for ellipsis via 'is ...' failing in 1.9.0 · Issue #17002 · python/mypy

Description: Bug Report As of mypy 1.9.0, narrowing of unions containing EllipsisType via the expressions if x is ... or if x is Ellipsis no longer works. In both branches of the if statement, the type of x still contains EllipsisType instead of bein...

Open Graph Description: Bug Report As of mypy 1.9.0, narrowing of unions containing EllipsisType via the expressions if x is ... or if x is Ellipsis no longer works. In both branches of the if statement, the type of x sti...

X Description: Bug Report As of mypy 1.9.0, narrowing of unions containing EllipsisType via the expressions if x is ... or if x is Ellipsis no longer works. In both branches of the if statement, the type of x sti...

Opengraph URL: https://github.com/python/mypy/issues/17002

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing for ellipsis via 'is ...' failing in 1.9.0","articleBody":"**Bug Report**\r\n\r\nAs of mypy 1.9.0, narrowing of unions containing `EllipsisType` via the expressions `if x is ...` or `if x is Ellipsis` no longer works.  In both branches of the if statement, the type of `x` still contains `EllipsisType` instead of being narrowed.\r\n\r\nThis narrowed as expected in 1.8.0.\r\n\r\nAs a workaround, it appears that `if instanceof(x, EllipsisType)` still works as expected.\r\n\r\n**To Reproduce**\r\n\r\nRun mypy against the following snippet:\r\n\r\n```python\r\nfrom types import EllipsisType\r\n\r\nx: int | EllipsisType\r\n\r\nif x is ...:\r\n    pass\r\nelse:\r\n    y = x + 1\r\n```\r\n\r\nA more complicated reproduction of this issue can be seen in our repo here: https://github.com/lsst/daf_butler/actions/runs/8209898890/job/22456322445?pr=973\r\n\r\n**Expected Behavior**\r\n\r\nmypy 1.8.0 shows no errors because `x` was narrowed to `int` in the else clause:\r\n```\r\nSuccess: no issues found in 1 source file\r\n```\r\n\r\n**Actual Behavior**\r\nmypy 1.9.0 reports an error instead:\r\n\r\n```\r\ntmp.py:8: error: Unsupported operand types for + (\"EllipsisType\" and \"int\")  [operator]\r\ntmp.py:8: note: Left operand is of type \"int | EllipsisType\"\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: 1.9.0\r\n- Mypy command-line flags: none\r\n- Mypy configuration options from `mypy.ini` (and other config files): none\r\n- Python version used: 3.11.7\r\n","author":{"url":"https://github.com/dhirving","@type":"Person","name":"dhirving"},"datePublished":"2024-03-08T23:54:17Z","url":"https://github.com/python/mypy/issues/17002"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0f4b76e6-ea88-6afe-e3b7-8c53df72ba56
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8CF2:77A5A:31BD594:42197D8:6B003855
html-safe-nonce217a485f49e108d39a9be897bf7e20eafd7c3788f2edfeec5e47ae9bf8937f35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0YyOjc3QTVBOjMxQkQ1OTQ6NDIxOTdEODo2QjAwMzg1NSIsInZpc2l0b3JfaWQiOiIxNjQyOTM4MjM3OTE3ODcwMTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f3c6a3921df1ac298d9d30db774ac15ec70984fc4229795eafbe0ce147e6a3d
hovercard-subject-tagissue:2176935503
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/17002/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b573d89e9209e303efc322b6c2a69b5441c0c5b70c5d1b87f0c0ccb871fdb794/python/mypy/issues/17002
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b573d89e9209e303efc322b6c2a69b5441c0c5b70c5d1b87f0c0ccb871fdb794/python/mypy/issues/17002
og:image:altBug Report As of mypy 1.9.0, narrowing of unions containing EllipsisType via the expressions if x is ... or if x is Ellipsis no longer works. In both branches of the if statement, the type of x sti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedhirving
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/17002#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17002
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F17002
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/17002
Reloadhttps://github.com/python/mypy/issues/17002
Reloadhttps://github.com/python/mypy/issues/17002
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17002
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/17002
#17003https://github.com/python/mypy/pull/17003
Type narrowing for ellipsis via 'is ...' failing in 1.9.0https://github.com/python/mypy/issues/17002#top
#17003https://github.com/python/mypy/pull/17003
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/dhirving
dhirvinghttps://github.com/dhirving
on Mar 8, 2024https://github.com/python/mypy/issues/17002#issue-2176935503
https://github.com/lsst/daf_butler/actions/runs/8209898890/job/22456322445?pr=973https://github.com/lsst/daf_butler/actions/runs/8209898890/job/22456322445?pr=973
dhirvinghttps://github.com/dhirving
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Mar 8, 2024https://github.com/python/mypy/issues/17002#event-12061633057
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Mar 9, 2024https://github.com/python/mypy/issues/17002#issuecomment-1986703553
python/typeshed#11223https://github.com/python/typeshed/pull/11223
hauntsaninjahttps://github.com/hauntsaninja
on Mar 9, 2024https://github.com/python/mypy/issues/17002#event-12062670911
Fix type narrowing for types.EllipsisTypehttps://github.com/hauntsaninja/mypy/commit/63d491a8f7d476381d2826f46a638d536e54521e
https://docs.github.com/articles/closing-issues-via-commit-messages
63d491ahttps://github.com/hauntsaninja/mypy/commit/63d491a8f7d476381d2826f46a638d536e54521e
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#17003https://github.com/python/mypy/pull/17003
on Mar 10, 2024https://github.com/python/mypy/issues/17002#event-12064445200
hauntsaninjahttps://github.com/hauntsaninja
on Mar 10, 2024https://github.com/python/mypy/issues/17002#event-12064445210
Fix type narrowing for types.EllipsisType (#17003)https://github.com/python/mypy/commit/16abf5cbe08c8b399381fc38220586cf2e49c2bc
#17003https://github.com/python/mypy/pull/17003
https://docs.github.com/articles/closing-issues-via-commit-messages
16abf5chttps://github.com/python/mypy/commit/16abf5cbe08c8b399381fc38220586cf2e49c2bc
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Mar 10, 2024https://github.com/python/mypy/issues/17002#issuecomment-1987058181
@dhirvinghttps://github.com/dhirving
https://github.com/lsst/daf_butlerhttps://github.com/lsst/daf_butler
https://github.com/dhirving
dhirvinghttps://github.com/dhirving
on Mar 11, 2024https://github.com/python/mypy/issues/17002#issuecomment-1988854514
mfisherlevinehttps://github.com/mfisherlevine
on May 4, 2026https://github.com/python/mypy/issues/17002#event-25138266658
Add mypy GitHub Action workflowhttps://github.com/lsst-so/rubintv_production/commit/447bc6ffb37c3d160a81523cc3e0007a018d78d3
447bc6fhttps://github.com/lsst-so/rubintv_production/commit/447bc6ffb37c3d160a81523cc3e0007a018d78d3
Dogfood the just-built image for mypyhttps://github.com/lsst-so/rubintv_production/commit/a025d134a56617cd2d3a170c94406264f14b812d
a025d13https://github.com/lsst-so/rubintv_production/commit/a025d134a56617cd2d3a170c94406264f14b812d
Dogfood the just-built image for mypyhttps://github.com/lsst-so/rubintv_production/commit/f7590619a70c44790877954808c9d0341e54d594
f759061https://github.com/lsst-so/rubintv_production/commit/f7590619a70c44790877954808c9d0341e54d594
Pin mypy below 2.0https://github.com/lsst-so/rubintv_production/commit/ecd88d57d1399e55a7de421ad9202bfe83b674e8
ecd88d5https://github.com/lsst-so/rubintv_production/commit/ecd88d57d1399e55a7de421ad9202bfe83b674e8
Pin mypy below 2.0https://github.com/lsst-so/rubintv_production/commit/fb9d7ae2794b079d1daeadb8073296dbcd71a009
fb9d7aehttps://github.com/lsst-so/rubintv_production/commit/fb9d7ae2794b079d1daeadb8073296dbcd71a009
Bake CI dev tools (mypy, pytest, stubs, xdist) into the imagehttps://github.com/lsst-so/rubintv_production/commit/634f2febf31338408576e635a7e4abaca4ed1146
634f2fehttps://github.com/lsst-so/rubintv_production/commit/634f2febf31338408576e635a7e4abaca4ed1146
Bake CI dev tools (mypy, pytest, stubs, xdist) into the imagehttps://github.com/lsst-so/rubintv_production/commit/51b952feb23078a1ac9788e5b03b65546b7b930c
51b952fhttps://github.com/lsst-so/rubintv_production/commit/51b952feb23078a1ac9788e5b03b65546b7b930c
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/17002
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/17002
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.