René's URL Explorer Experiment


Title: disambiguate booleans on conditions ("and" & "or" operators) · Issue #1698 · python/mypy · GitHub

Open Graph Title: disambiguate booleans on conditions ("and" & "or" operators) · Issue #1698 · python/mypy

X Title: disambiguate booleans on conditions ("and" & "or" operators) · Issue #1698 · python/mypy

Description: I've noticed many false positive type errors related to "and" and "or" operators because they have the tendency to create union types. I'm working with some program which I reduced to the following example: REGEX = re.compile(r'(a*)(b*)(...

Open Graph Description: I've noticed many false positive type errors related to "and" and "or" operators because they have the tendency to create union types. I'm working with some program which I reduced to the following...

X Description: I've noticed many false positive type errors related to "and" and "or" operators because they have the tendency to create union types. I'm working with some program whic...

Opengraph URL: https://github.com/python/mypy/issues/1698

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"disambiguate booleans on conditions (\"and\" & \"or\" operators)","articleBody":"I've noticed many false positive type errors related to \"and\" and \"or\" operators because they have the tendency to create union types. I'm working with some program which I reduced to the following example:\n\n``` python\nREGEX = re.compile(r'(a*)(b*)(c*)')\n\ndef example(s: str, ignore_matches: bool) -> int:\n    match = not ignore_matches and REGEX.search(s)\n    if match:\n        x = match.group(1) or match.group(3)\n        y = match.start(2)\n        return len(x) + y\n```\n\nmypy figures out that the type of match is `Union[bool, re.Match]` (`re.Match` actually doesn't exist, so I can't workaround this with an `isinstance()` check here but this is not the main point here). So inside the if, I get:\n\n```\nfoo.py:9: error: Some element of union has no attribute \"group\"\nfoo.py:10: error: Some element of union has no attribute \"start\"\n```\n\nI understand why this happens, but I'm thinking that this could be analyzed statically, if mypy actually has some \"always True\" and \"always False\" types as subtypes of \"Boolean\". This could help in \"and\" and \"or\" expressions. The type of the expression above would be `Union[FalseType, re.Match]`. Which can be analyzed in an if removing the \"FalseType\" option from the Union, which gives an accurate typing of re.Match.\n\nA dual situation can be found if you have `boolexp or other_exp` which could be typed as `Union[TrueType, other_type]`.\n\nA possible generalization of this is having additional type information for all types saying \"can be true-ish\", \"can be false-ish\"; and that type information can be narrowed down on boolean operators and ifs.\n\nOn first sight, these ideas may look like going beyond the idea of a type checker and more into a program verifier but that's not actually what I'm proposing; the thing is that in actual programs this kind of checks are actually a way to narrow down union types, and my increase the effectiveness of mypy as a typechecker.\n","author":{"url":"https://github.com/dmoisset","@type":"Person","name":"dmoisset"},"datePublished":"2016-06-11T12:18:18Z","url":"https://github.com/python/mypy/issues/1698"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bbdffebd-8716-2080-7b5f-64ee37065181
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE810:145630:303042D:3FE6D01:6B002F45
html-safe-nonce65d61e7a04cd7638718da97acaf7e3ccd1ef0f3b3572b868f1df0bedec30a765
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODEwOjE0NTYzMDozMDMwNDJEOjNGRTZEMDE6NkIwMDJGNDUiLCJ2aXNpdG9yX2lkIjoiNDI2MzI1ODY2NjY0NTMzNTg3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac30e941126e1a185c0746ec27d09dd6066f7fd036cd07491d130151fdc365555d
hovercard-subject-tagissue:159771001
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1698/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f0ff9bed12a9350f6a60143f68a1bd98caa9ec2ba9cb009225c4fadb1d763e5b/python/mypy/issues/1698
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f0ff9bed12a9350f6a60143f68a1bd98caa9ec2ba9cb009225c4fadb1d763e5b/python/mypy/issues/1698
og:image:altI've noticed many false positive type errors related to "and" and "or" operators because they have the tendency to create union types. I'm working with some program which I reduced to the following...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedmoisset
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/1698#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1698
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1698
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/1698
Reloadhttps://github.com/python/mypy/issues/1698
Reloadhttps://github.com/python/mypy/issues/1698
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1698
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1698
disambiguate booleans on conditions ("and" & "or" operators)https://github.com/python/mypy/issues/1698#top
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
https://github.com/dmoisset
dmoissethttps://github.com/dmoisset
on Jun 11, 2016https://github.com/python/mypy/issues/1698#issue-159771001
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 11, 2016https://github.com/python/mypy/issues/1698#issuecomment-225372927
JukkaLhttps://github.com/JukkaL
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
on Jun 13, 2016https://github.com/python/mypy/issues/1698#event-690262183
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jun 13, 2016https://github.com/python/mypy/issues/1698#issuecomment-225548995
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jun 13, 2016https://github.com/python/mypy/issues/1698#issuecomment-225572642
@pdmccormickhttps://github.com/pdmccormick
#1477https://github.com/python/mypy/issues/1477
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jun 13, 2016https://github.com/python/mypy/issues/1698#issuecomment-225591683
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Jul 12, 2016https://github.com/python/mypy/issues/1698#issuecomment-232152600
https://github.com/dmoisset
dmoissethttps://github.com/dmoisset
on Jul 14, 2016https://github.com/python/mypy/issues/1698#issuecomment-232750973
@ddfisherhttps://github.com/ddfisher
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Jul 14, 2016https://github.com/python/mypy/issues/1698#issuecomment-232755116
https://github.com/dmoisset
dmoissethttps://github.com/dmoisset
on Jul 19, 2016https://github.com/python/mypy/issues/1698#issuecomment-233709981
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Jul 19, 2016https://github.com/python/mypy/issues/1698#issuecomment-233767490
https://github.com/dmoisset
dmoissethttps://github.com/dmoisset
on Aug 5, 2016https://github.com/python/mypy/issues/1698#issuecomment-237916649
#1989https://github.com/python/mypy/pull/1989
gnpricehttps://github.com/gnprice
on Aug 11, 2016https://github.com/python/mypy/issues/1698#event-753332539
ddfisherhttps://github.com/ddfisher
on Aug 16, 2016https://github.com/python/mypy/issues/1698#event-757823170
Fix for #1698 (#1989)https://github.com/python/mypy/commit/9a8a8c098a592cccc87473019b29f56a5db9c7cb
#1698https://github.com/python/mypy/issues/1698
#1989https://github.com/python/mypy/pull/1989
9a8a8c0https://github.com/python/mypy/commit/9a8a8c098a592cccc87473019b29f56a5db9c7cb
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 17, 2016https://github.com/python/mypy/issues/1698#issuecomment-240277414
#1989https://github.com/python/mypy/pull/1989
gvanrossumhttps://github.com/gvanrossum
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 17, 2016https://github.com/python/mypy/issues/1698#event-757852952
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/1698
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/1698
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.