René's URL Explorer Experiment


Title: Various stubgen regressions in mypy 1.7.0 · Issue #16486 · python/mypy · GitHub

Open Graph Title: Various stubgen regressions in mypy 1.7.0 · Issue #16486 · python/mypy

X Title: Various stubgen regressions in mypy 1.7.0 · Issue #16486 · python/mypy

Description: Bug Report Trying to update mypy from 1.6.1 to 1.7.0 has revealed a few regressions in the stub generator output related to pybind11 modules. To Reproduce Consider this pybind11 module: #include #include #include ...

Open Graph Description: Bug Report Trying to update mypy from 1.6.1 to 1.7.0 has revealed a few regressions in the stub generator output related to pybind11 modules. To Reproduce Consider this pybind11 module: #include

X Description: Bug Report Trying to update mypy from 1.6.1 to 1.7.0 has revealed a few regressions in the stub generator output related to pybind11 modules. To Reproduce Consider this pybind11 module: #include &l...

Opengraph URL: https://github.com/python/mypy/issues/16486

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Various stubgen regressions in mypy 1.7.0","articleBody":"**Bug Report**\r\n\r\nTrying to update mypy from 1.6.1 to 1.7.0 has revealed a few regressions in the stub generator output related to pybind11 modules.\r\n\r\n**To Reproduce**\r\n\r\nConsider this pybind11 module:\r\n\r\n```c++\r\n#include \u003cfilesystem>\r\n#include \u003coptional>\r\n#include \u003cutility>\r\n#include \u003cvector>\r\n\r\n#include \u003cpybind11/pybind11.h>\r\n#include \u003cpybind11/stl.h>\r\n\r\nnamespace py = pybind11;\r\n\r\nstd::vector\u003cfloat> funcReturningVector()\r\n{\r\n  return std::vector\u003cfloat>{1.0, 2.0, 3.0, 4.0};\r\n}\r\n\r\nstd::pair\u003cint, float> funcReturningPair()\r\n{\r\n  return std::pair{42, 1.0};\r\n}\r\n\r\nstd::optional\u003cint> funcReturningOptional()\r\n{\r\n  return std::nullopt;\r\n}\r\n\r\nstd::filesystem::path funcIncompleteSignature()\r\n{\r\n  // This example does not include \u003cpybind11/stl/filesystem.h> on purpose\r\n  // to demonstrate the signature of an incomplete binding.\r\n  return std::filesystem::path{\"foobar\"};\r\n}\r\n\r\nstruct MyStruct\r\n{\r\n  int a;\r\n  int b;\r\n  int c;\r\n};\r\n\r\nPYBIND11_MODULE(my_native_module, m)\r\n{\r\n  m.def(\"func_returning_vector\", &funcReturningVector);\r\n  m.def(\"func_returning_pair\", &funcReturningPair);\r\n  m.def(\"func_returning_optional\", &funcReturningOptional);\r\n\r\n  m.def(\"func_incomplete_signature\", &funcIncompleteSignature);\r\n\r\n  py::class_\u003cMyStruct>(m, \"MyStruct\")\r\n      .def_readwrite(\"a\", &MyStruct::a)\r\n      .def_readwrite(\"b\", &MyStruct::b, \"some docstring\")\r\n      .def_property_readonly(\r\n          \"c\",\r\n          [](const MyStruct& x) {\r\n            return x.c;\r\n          },\r\n          \"some docstring\");\r\n}\r\n```\r\n\r\nTo reproduce, store the above snippet as `my_native_module.cpp` and then:\r\n\r\n```sh\r\n# Install latest pybind11:\r\npip install pybind11==2.11.1\r\n\r\n# Compile pybind11 module:\r\nc++ -O3 -Wall -shared -std=c++17 -fPIC $(python3 -m pybind11 --includes) my_native_module.cpp -o my_native_module.so\r\n\r\n# Run the stub generator on it:\r\nstubgen -p my_native_module\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nmypy 1.6.1 outputs the following, which is pretty reasonable:\r\n\r\n```py\r\nfrom typing import Any, List, Optional, Tuple\r\n\r\nclass MyStruct:\r\n    a: int\r\n    b: int\r\n    def __init__(self, *args, **kwargs) -> None: ...\r\n    @property\r\n    def c(self) -> int: ...\r\n\r\ndef func_incomplete_signature(*args, **kwargs) -> Any: ...\r\ndef func_returning_optional() -> Optional[int]: ...\r\ndef func_returning_pair() -> Tuple[int,float]: ...\r\ndef func_returning_vector() -> List[float]: ...\r\n```\r\n\r\n**Actual Behavior**\r\n\r\nmypy 1.7.0 outputs the following:\r\n\r\n```py\r\nfrom _typeshed import Incomplete\r\n\r\nclass MyStruct:\r\n    a: int\r\n    b: Incomplete\r\n    def __init__(self, *args, **kwargs) -> None: ...\r\n    @property\r\n    def c(self): ...\r\n\r\ndef func_incomplete_signature(*args, **kwargs): ...\r\ndef func_returning_optional() -> Optional[int]: ...\r\ndef func_returning_pair() -> Tuple[int, float]: ...\r\ndef func_returning_vector() -> List[float]: ...\r\n```\r\n\r\nThe regressions are:\r\n\r\n- The most obvious thing is that the imports for `List`, `Tuple`, and `Optional` are missing. This makes the resulting `.pyi` invalid, because it uses symbols that have not been imported. The stub output does not type check. This is not limited to these three types, but applies to other types like `Iterable`, `Iterator`, `Dict`, `Set`, `Union`, etc.\r\n- The type annotation of field `b` has regressed from `int` to `Incomplete`, apparently due to the explicit docstring.\r\n- The type annotation of field `c` has regressed from `int` to not annotated at all, probably also because of the explicit docstring.\r\n- The signature of the `func_incomplete_signature` has also slightly worsened: Before, it was at least annotated as `-> Any` but now it misses any return type annotation at all. This is problematic when users want to validate their generated stubs for completeness, i.e., run `mypy --disallow-untyped-defs` on the output. Of course semantically it is the same, but still it would be nicer to always produce some return type (arguably a broken signature may be rather annotated as `-> object` instead of `-> Incomplete` to avoid running into bugs from incomplete stub output).\r\n\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: 1.7.0\r\n- Mypy command-line flags: irrelevant for stubgen\r\n- Mypy configuration options from `mypy.ini` (and other config files): irrelevant for stubgen\r\n- Python version used: 3.10\r\n\r\n","author":{"url":"https://github.com/bluenote10","@type":"Person","name":"bluenote10"},"datePublished":"2023-11-14T13:49:56Z","url":"https://github.com/python/mypy/issues/16486"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5c1956dd-7bd9-c1a2-d0e9-ab5e4b77181a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCCE2:1DA29F:10A40FD:15C0868:6AFFFA16
html-safe-nonce75440d4dde3435d295b18dfe71df4c7e225ef125cf8da97fed87ba8496dfe8c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0UyOjFEQTI5RjoxMEE0MEZEOjE1QzA4Njg6NkFGRkZBMTYiLCJ2aXNpdG9yX2lkIjoiODYyNDkxOTEzNzIxMjE1NTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac568895d20bc82d4b40c5aa43d4f3a8fb1eced5affbf47f009d98441b5735cfc6
hovercard-subject-tagissue:1992784694
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/16486/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dc5bf7314a64a730c9c6ecd7c8676976818c196fc9fc728bcfe2b27abc16cc2e/python/mypy/issues/16486
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dc5bf7314a64a730c9c6ecd7c8676976818c196fc9fc728bcfe2b27abc16cc2e/python/mypy/issues/16486
og:image:altBug Report Trying to update mypy from 1.6.1 to 1.7.0 has revealed a few regressions in the stub generator output related to pybind11 modules. To Reproduce Consider this pybind11 module: #include
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebluenote10
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/16486#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F16486
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F16486
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/16486
Reloadhttps://github.com/python/mypy/issues/16486
Reloadhttps://github.com/python/mypy/issues/16486
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/16486
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/16486
Various stubgen regressions in mypy 1.7.0https://github.com/python/mypy/issues/16486#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
https://github.com/bluenote10
bluenote10https://github.com/bluenote10
on Nov 14, 2023https://github.com/python/mypy/issues/16486#issue-1992784694
bluenote10https://github.com/bluenote10
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Nov 14, 2023https://github.com/python/mypy/issues/16486#event-10954903566
JelleZijlstrahttps://github.com/JelleZijlstra
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
on Nov 14, 2023https://github.com/python/mypy/issues/16486#event-10954990192
https://github.com/bluenote10
bluenote10https://github.com/bluenote10
on Nov 15, 2023https://github.com/python/mypy/issues/16486#issuecomment-1812908110
#13284https://github.com/python/mypy/pull/13284
mypy/misc/test-stubgenc.shhttps://github.com/python/mypy/blob/0699dde8dc2633861a65ac43701eda09e79de366/misc/test-stubgenc.sh#L27
0699ddehttps://github.com/python/mypy/commit/0699dde8dc2633861a65ac43701eda09e79de366
https://github.com/chadrik
chadrikhttps://github.com/chadrik
on Nov 15, 2023https://github.com/python/mypy/issues/16486#issuecomment-1812979345
JelleZijlstrahttps://github.com/JelleZijlstra
on Nov 29, 2023https://github.com/python/mypy/issues/16486#event-11091699060
Fix stubgen regressions with pybind11 and mypy 1.7 (#16504)https://github.com/python/mypy/commit/69b31445280d7c495fa0268b24fc558bcbe74505
#16504https://github.com/python/mypy/pull/16504
69b3144https://github.com/python/mypy/commit/69b31445280d7c495fa0268b24fc558bcbe74505
https://github.com/bluenote10
bluenote10https://github.com/bluenote10
on Jan 5, 2024https://github.com/python/mypy/issues/16486#issuecomment-1879052581
@chadrikhttps://github.com/chadrik
@chadrikhttps://github.com/chadrik
bluenote10https://github.com/bluenote10
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 5, 2024https://github.com/python/mypy/issues/16486#event-11403760518
JelleZijlstrahttps://github.com/JelleZijlstra
on Jan 13, 2024https://github.com/python/mypy/issues/16486#event-11478235477
Improve stubgen tests (#16760)https://github.com/python/mypy/commit/a8741d8fda2695e189add60b1cfc4adebd2c3e1e
#16760https://github.com/python/mypy/pull/16760
a8741d8https://github.com/python/mypy/commit/a8741d8fda2695e189add60b1cfc4adebd2c3e1e
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/16486
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/16486
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.