René's URL Explorer Experiment


Title: Incorrect type narrowing for select class hierarchies · Issue #16379 · python/mypy · GitHub

Open Graph Title: Incorrect type narrowing for select class hierarchies · Issue #16379 · python/mypy

X Title: Incorrect type narrowing for select class hierarchies · Issue #16379 · python/mypy

Description: Bug Report I've found that in an exhaustive isinstance if block, mypy still leaves a more general type resolution than it should. In the snippet of code, mypy should be able to understand that there is no attr-defined error. To Reproduce...

Open Graph Description: Bug Report I've found that in an exhaustive isinstance if block, mypy still leaves a more general type resolution than it should. In the snippet of code, mypy should be able to understand that ther...

X Description: Bug Report I've found that in an exhaustive isinstance if block, mypy still leaves a more general type resolution than it should. In the snippet of code, mypy should be able to understand that ...

Opengraph URL: https://github.com/python/mypy/issues/16379

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect type narrowing for select class hierarchies ","articleBody":"**Bug Report**\r\n\r\nI've found that in an exhaustive `isinstance` if block, mypy still leaves a more general type resolution than it should. In the snippet of code, mypy should be able to understand that there is no attr-defined error.\r\n\r\n**To Reproduce**\r\n\r\n```python\r\nfrom __future__ import annotations\r\n\r\n\r\nclass A:\r\n    pass\r\n\r\n\r\nclass B(A):\r\n    def get_x(self):\r\n        pass\r\n\r\n\r\nclass C(A):\r\n    def get_x(self):\r\n        pass\r\n\r\n\r\nclass D(C):\r\n    pass\r\n\r\n\r\nclass E(C):\r\n    pass\r\n\r\n\r\nclass F(C):\r\n    pass\r\n\r\n\r\ndef x(obj: A):\r\n    value = \"\"\r\n    if isinstance(obj, B):\r\n        value = obj.__class__.__name__\r\n    elif isinstance(obj, D):\r\n        value = obj.__class__.__name__\r\n    elif isinstance(obj, E):\r\n        value = obj.__class__.__name__\r\n    elif isinstance(obj, F):\r\n        value = obj.__class__.__name__\r\n    else:\r\n        raise RuntimeError(\"unhandled type\")\r\n\r\n    reveal_type(obj)\r\n    obj.get_x()\r\n\r\n```\r\n\r\n**Expected Behavior**\r\n\r\n```\r\nx.py:43: note: Revealed type is \"B | D | E | F\"\r\n```\r\n\r\n**Actual Behavior**\r\n```\r\nx.py:43: note: Revealed type is \"x.A\"\r\nx.py:44: error: \"A\" has no attribute \"get_x\"  [attr-defined]\r\n```\r\n\r\n**Your Environment**\r\n\r\n\r\n- Mypy version used: mypy 1.6.1 (compiled: yes)\r\n- Mypy command-line flags: default\r\n- Mypy configuration options from `mypy.ini` (and other config files): default\r\n- Python version used: 3.10.13\r\n\r\n","author":{"url":"https://github.com/Redoubts","@type":"Person","name":"Redoubts"},"datePublished":"2023-10-31T17:32:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/16379/mypy/issues/16379"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d0bcd05b-904b-3ecb-b487-ad9cb1297a9e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8486:F3B55:2930824:3992BED:6A5F6712
html-safe-nonce4ec5758f559b3d065dc201ff80b83fbde79024c52066a6ce891e0a243d7da828
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDg2OkYzQjU1OjI5MzA4MjQ6Mzk5MkJFRDo2QTVGNjcxMiIsInZpc2l0b3JfaWQiOiI1NzQwMTg0Njc4NjIxNDcyNTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb1c30cab414b1494d46edbb14d3e1f7662f5cb91c7a8838e09ecacd668af3c6d
hovercard-subject-tagissue:1970958262
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/16379/issue_layout
twitter:imagehttps://opengraph.githubassets.com/89ba8b7a8ae8352f31d01cd1e1427d3f7bf2e9bb03f79d17dcf8eef7fb142caf/python/mypy/issues/16379
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/89ba8b7a8ae8352f31d01cd1e1427d3f7bf2e9bb03f79d17dcf8eef7fb142caf/python/mypy/issues/16379
og:image:altBug Report I've found that in an exhaustive isinstance if block, mypy still leaves a more general type resolution than it should. In the snippet of code, mypy should be able to understand that ther...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRedoubts
hostnamegithub.com
expected-hostnamegithub.com
None00788ab1bca5e7741110f9acff93fb613e3960b647280b664f19a2f2727fc38a
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0f1c555eb8c0d65e8ad53f33a2a87d02583a75b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/issues/16379#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F16379
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F16379
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/16379
Reloadhttps://github.com/python/mypy/issues/16379
Reloadhttps://github.com/python/mypy/issues/16379
Please reload this pagehttps://github.com/python/mypy/issues/16379
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/issues/16379
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.3k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 472 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Incorrect type narrowing for select class hierarchies https://github.com/python/mypy/issues/16379#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-join-v-unionUsing join vs. using unionshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-join-v-union%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/Redoubts
Redoubtshttps://github.com/Redoubts
on Oct 31, 2023https://github.com/python/mypy/issues/16379#issue-1970958262
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-join-v-unionUsing join vs. using unionshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-join-v-union%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.