Title: regression with Generic/ParamSpec between 1.4.1 and 1.5.0 · Issue #15844 · python/mypy · GitHub
Open Graph Title: regression with Generic/ParamSpec between 1.4.1 and 1.5.0 · Issue #15844 · python/mypy
X Title: regression with Generic/ParamSpec between 1.4.1 and 1.5.0 · Issue #15844 · python/mypy
Description: Bug Report With 1.5.0, some of our software has started to surface a var-annotated ("Need type annotation for") error that it did not surface with 1.4.1; I could not find anything in the 1.5.0 release notes that suggested that this was i...
Open Graph Description: Bug Report With 1.5.0, some of our software has started to surface a var-annotated ("Need type annotation for") error that it did not surface with 1.4.1; I could not find anything in the 1.5.0 rele...
X Description: Bug Report With 1.5.0, some of our software has started to surface a var-annotated ("Need type annotation for") error that it did not surface with 1.4.1; I could not find anything in the ...
Opengraph URL: https://github.com/python/mypy/issues/15844
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"regression with Generic/ParamSpec between 1.4.1 and 1.5.0","articleBody":"**Bug Report**\r\n\r\nWith `1.5.0`, some of our software has started to surface a `var-annotated` (\"Need type annotation for\") error that it did not surface with `1.4.1`; I could not find anything in the 1.5.0 release notes that suggested that this was intentional.\r\n\r\n**To Reproduce**\r\n\r\nOur actual software is a bit domain-specific, but I've tried to extract the details; the concept involves a data descriptor that attaches a callable to a class and generates a new callable that inverts how the callable's constructor and runtime arguments are supplied. The solution depends on `ParamSpec` to preserve the argument signatures and uses `Generic` so that the same internals can be used for different functions.\r\n\r\n```python\r\n#!/usr/bin/env python3\r\nfrom dataclasses import dataclass\r\nfrom typing import Generic, ParamSpec, Protocol, Self, TypeVar, overload\r\n\r\n\r\nP = ParamSpec(\"P\")\r\nT = TypeVar(\"T\")\r\n\r\n\r\nclass Transform(Protocol[P, T]):\r\n \"\"\"Generic protocol to transform a value using inputs.\"\"\"\r\n\r\n def __init__(self, *args: P.args, **kwargs: P.kwargs) -> None:\r\n raise NotImplementedError\r\n\r\n def __call__(self, value: T) -> T:\r\n raise NotImplementedError\r\n\r\n\r\nclass BoundTransform(Generic[P, T]):\r\n \"\"\"Wrapper around a transform function that performs late-binding.\"\"\"\r\n\r\n def __init__(\r\n self,\r\n value: T,\r\n transform_cls: type[Transform[P, T]],\r\n ) -> None:\r\n self.value: T = value\r\n self.transform_cls: type[Transform[P, T]] = transform_cls\r\n\r\n def __call__(\r\n self,\r\n *args: P.args,\r\n **kwargs: P.kwargs,\r\n ) -> T:\r\n return self.transform_cls(*args, **kwargs)(self.value)\r\n\r\n\r\nclass HasValue(Protocol[T]):\r\n value: T\r\n\r\nclass Transformer(Generic[P, T]):\r\n \"\"\"Data descriptor that applies the bound transformer to something with a value.\"\"\"\r\n\r\n def __init__(\r\n self,\r\n transform_cls: type[Transform[P, T]],\r\n ) -> None:\r\n self.transform_cls: type[Transform[P, T]] = transform_cls\r\n\r\n @overload\r\n def __get__(self, obj: None, objtype: type[HasValue[T]]) -> Self:\r\n ...\r\n\r\n @overload\r\n def __get__(self, obj: HasValue[T], objtype: type[HasValue[T]]) -> BoundTransform[P, T]:\r\n ...\r\n\r\n def __get__(self, obj: HasValue[T] | None, objtype: type[HasValue[T]]) -> Self | BoundTransform[P, T]:\r\n if obj is None:\r\n return self\r\n\r\n return BoundTransform(obj.value, self.transform_cls)\r\n\r\n\r\n@dataclass(frozen=True)\r\nclass Add:\r\n \"\"\"Transform implementation that adds two integers.\"\"\"\r\n value: int\r\n\r\n def __call__(self, value: int) -> int:\r\n return value + self.value\r\n\r\n\r\n@dataclass(frozen=True)\r\nclass HasNumber(HasValue[int]):\r\n \"\"\"HasValue implementation that holds an integer.\"\"\"\r\n value: int\r\n\r\n add = Transformer(Add)\r\n\r\n\r\n\r\nif __name__ == \"__main__\":\r\n # Usage example\r\n foo = HasNumber(42)\r\n bar = foo.add(-42)\r\n assert bar == 0\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nNo errors from mypy. This is true for `1.4.1`.\r\n\r\n**Actual Behavior**\r\n\r\nErrors. This is true for `1.5.0`\r\n\r\n```sh\r\nmain.py:81: error: Need type annotation for \"add\" [var-annotated]\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: `1.4.1` and `1.5.0`\r\n- Mypy command-line flags: n/a\r\n- Mypy configuration options from `mypy.ini` (and other config files): n/a\r\n- Python version used: 3.11.4","author":{"url":"https://github.com/jessemyers-lettuce","@type":"Person","name":"jessemyers-lettuce"},"datePublished":"2023-08-10T19:37:24Z","url":"https://github.com/python/mypy/issues/15844"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:461a86f4-9693-4f01-b09e-842fe01e6b7c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B1B0:15E5F9:27F6890:3696B42:6B0049AD |
| html-safe-nonce | 3752b5640f1584d0ecb43948823d7dd811b5dadcc14cd860007eb4fabf0718a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUIwOjE1RTVGOToyN0Y2ODkwOjM2OTZCNDI6NkIwMDQ5QUQiLCJ2aXNpdG9yX2lkIjoiMzcxMTQyMTU1NDU1NTM3Mzk5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e4efa1f781d6ac2dd26d1fc94d86412a9ea2d2742de8c69eae16fc440cdf60a6 |
| hovercard-subject-tag | issue:1845782978 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/15844/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dfe7f7adc0d7c579bc963beda4d6acc735c9633b9e5caf76906e857f78c6222b/python/mypy/issues/15844 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dfe7f7adc0d7c579bc963beda4d6acc735c9633b9e5caf76906e857f78c6222b/python/mypy/issues/15844 |
| og:image:alt | Bug Report With 1.5.0, some of our software has started to surface a var-annotated ("Need type annotation for") error that it did not surface with 1.4.1; I could not find anything in the 1.5.0 rele... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jessemyers-lettuce |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width