René's URL Explorer Experiment


Title: TypedDict 'in' narrowing w/o @final · Issue #15697 · python/mypy · GitHub

Open Graph Title: TypedDict 'in' narrowing w/o @final · Issue #15697 · python/mypy

X Title: TypedDict 'in' narrowing w/o @final · Issue #15697 · python/mypy

Description: We shouldn't require @final decoration for TypedDicts to narrow them based on the 'in' operator. Why? Basically @erictraut's comment. In #13838, we've added "key in Union[TypedDict, ...]" narrowing for TypedDicts that are marked @final. ...

Open Graph Description: We shouldn't require @final decoration for TypedDicts to narrow them based on the 'in' operator. Why? Basically @erictraut's comment. In #13838, we've added "key in Union[TypedDict, ...]" narrowing...

X Description: We shouldn't require @final decoration for TypedDicts to narrow them based on the 'in' operator. Why? Basically @erictraut's comment. In #13838, we've added "key in Union[T...

Opengraph URL: https://github.com/python/mypy/issues/15697

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TypedDict 'in' narrowing w/o @final","articleBody":"We shouldn't require `@final` decoration for TypedDicts to narrow them based on the 'in' operator.\r\n\r\n## Why?\r\n\r\nBasically @erictraut's [comment](https://github.com/python/mypy/issues/15695#issuecomment-1638955963).\r\n\r\nIn #13838, we've added \"key in Union[TypedDict, ...]\" narrowing for TypedDicts that are marked `@final`. The reason was to prevent this:\r\n\r\n```python\r\nclass Mammal(TypedDict):\r\n  mammary_glands: int\r\n\r\nclass Bird(TypedDict):\r\n  eggs: int\r\n\r\nclass Echidna(Mammal):\r\n  eggs: int\r\n\r\nanimal: Mammal | Bird\r\nif 'eggs' in animal:\r\n  assert_type(animal, Bird)  # WRONG! Could still be a Mammal (a Echidna)\r\nif 'eggs' in animal and 'mammary_glands' in animal:\r\n  assert_never(animal)  # WRONG! Could still be a Mammal (a Echidna)\r\n```\r\n\r\nHowever, per @erictraut's [comment](https://github.com/python/mypy/issues/15695#issuecomment-1638955963), due to TypedDict being a structural type, we shouldn't consider the class hierarchy when type-matching.\r\n\r\nThis will be consistent with [pyright](https://github.com/microsoft/pyright/commit/6a25a7bf0b5cb3721a06d0e0d6245b2ebfbf053b) and TypeScript ([Playground Link](https://www.typescriptlang.org/play?&q=337#code/JYOwLgpgTgZghgYwgAgLJwLYbgG2QbwChllss4oBPAfQHMc4QATAZwC5kQBXDAI2kIBfQoVCRYiFACFgUJgWLIItWu049+UISLHR4SZAFEEAC2BMQcJQA9IzFmkzY8REstUdufAcMIA3CmRGYGcOdHI8AB9kGTlkAF5kAHleACsIBDAACgBKURhkLIBydxYi5FAgkBDcHIUSBAB7EBYwZF5ZJg5Y+UTg5xIAekH2rjamrhx5fiCjU3NLAEJtIA)).","author":{"url":"https://github.com/ikonst","@type":"Person","name":"ikonst"},"datePublished":"2023-07-18T03:23:57Z","url":"https://github.com/python/mypy/issues/15697"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3dfc121c-9809-ce9d-ce3c-1ede8a04be70
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDE02:3DAD59:1DA0DBC:2732E14:6B003844
html-safe-nonce680afe370e8abe022b3910eb6c2107ee0bd0e6d352777d848b3720f834862dd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTAyOjNEQUQ1OToxREEwREJDOjI3MzJFMTQ6NkIwMDM4NDQiLCJ2aXNpdG9yX2lkIjoiMTU1ODMyMDY2ODEyOTUwNTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac279b4dabc5625899e44643b98034080383e91b03bb7665d44330d7bb3bd2a534
hovercard-subject-tagissue:1809008450
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/15697/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f40420ea66fcf0ea71dbcbceca6f3bd68d13b324bf5efb8fc8f7e48f84777eaf/python/mypy/issues/15697
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f40420ea66fcf0ea71dbcbceca6f3bd68d13b324bf5efb8fc8f7e48f84777eaf/python/mypy/issues/15697
og:image:altWe shouldn't require @final decoration for TypedDicts to narrow them based on the 'in' operator. Why? Basically @erictraut's comment. In #13838, we've added "key in Union[TypedDict, ...]" narrowing...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameikonst
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/15697#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F15697
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F15697
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/15697
Reloadhttps://github.com/python/mypy/issues/15697
Reloadhttps://github.com/python/mypy/issues/15697
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/15697
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/15697
#15698https://github.com/python/mypy/pull/15698
TypedDict 'in' narrowing w/o @finalhttps://github.com/python/mypy/issues/15697#top
#15698https://github.com/python/mypy/pull/15698
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jul 18, 2023https://github.com/python/mypy/issues/15697#issue-1809008450
@erictrauthttps://github.com/erictraut
commenthttps://github.com/python/mypy/issues/15695#issuecomment-1638955963
#13838https://github.com/python/mypy/pull/13838
@erictrauthttps://github.com/erictraut
commenthttps://github.com/python/mypy/issues/15695#issuecomment-1638955963
pyrighthttps://github.com/microsoft/pyright/commit/6a25a7bf0b5cb3721a06d0e0d6245b2ebfbf053b
Playground Linkhttps://www.typescriptlang.org/play?&q=337#code/JYOwLgpgTgZghgYwgAgLJwLYbgG2QbwChllss4oBPAfQHMc4QATAZwC5kQBXDAI2kIBfQoVCRYiFACFgUJgWLIItWu049+UISLHR4SZAFEEAC2BMQcJQA9IzFmkzY8REstUdufAcMIA3CmRGYGcOdHI8AB9kGTlkAF5kAHleACsIBDAACgBKURhkLIBydxYi5FAgkBDcHIUSBAB7EBYwZF5ZJg5Y+UTg5xIAekH2rjamrhx5fiCjU3NLAEJtIA
ikonsthttps://github.com/ikonst
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Jul 18, 2023https://github.com/python/mypy/issues/15697#event-9844952172
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Jul 18, 2023https://github.com/python/mypy/issues/15697#issuecomment-1639637893
#7981 (comment)https://github.com/python/mypy/issues/7981#issuecomment-557079403
#15425https://github.com/python/mypy/pull/15425
AlexWaygoodhttps://github.com/AlexWaygood
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
on Jul 18, 2023https://github.com/python/mypy/issues/15697#event-9846902931
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Sep 2, 2023https://github.com/python/mypy/issues/15697#issuecomment-1703675936
@hauntsaninjahttps://github.com/hauntsaninja
your comment herehttps://github.com/python/mypy/issues/15695#issuecomment-1675764082
how people expect it to behttps://github.com/python/mypy/issues/9953
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jan 20, 2024https://github.com/python/mypy/issues/15697#issuecomment-1902174686
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jan 21, 2024https://github.com/python/mypy/issues/15697#issuecomment-1902469085
@gvanrossumhttps://github.com/gvanrossum
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/15697
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/15697
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.