René's URL Explorer Experiment


Title: isinstance checks cause type declarations to leak from the binder · Issue #1568 · python/mypy · GitHub

Open Graph Title: isinstance checks cause type declarations to leak from the binder · Issue #1568 · python/mypy

X Title: isinstance checks cause type declarations to leak from the binder · Issue #1568 · python/mypy

Description: The problem with this is most easily visible with list comprehensions: lst = [1, 2, 3] # type: List[Union[int, str]] [x if isinstance(x, int) else 0 for x in lst] reveal_type([x for x in [4, 5, 6]]) $ python3 -m mypy ~/test.py test.py:3:...

Open Graph Description: The problem with this is most easily visible with list comprehensions: lst = [1, 2, 3] # type: List[Union[int, str]] [x if isinstance(x, int) else 0 for x in lst] reveal_type([x for x in [4, 5, 6]]...

X Description: The problem with this is most easily visible with list comprehensions: lst = [1, 2, 3] # type: List[Union[int, str]] [x if isinstance(x, int) else 0 for x in lst] reveal_type([x for x in [4, 5, 6]]...

Opengraph URL: https://github.com/python/mypy/issues/1568

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"isinstance checks cause type declarations to leak from the binder","articleBody":"The problem with this is most easily visible with list comprehensions:\n\n``` python\nlst = [1, 2, 3]  # type: List[Union[int, str]]\n[x if isinstance(x, int) else 0 for x in lst]\nreveal_type([x for x in [4, 5, 6]])\n```\n\n```\n$ python3 -m mypy ~/test.py\ntest.py:3: error: Revealed type is 'builtins.list[Union[builtins.int, builtins.str]]'\n```\n\nThis happens because of this line in the binder, which always adds the declared type of a variable to the topmost frame whenever a binding for it is pushed: https://github.com/python/mypy/blob/master/mypy/checker.py#L127\n\nThis is obviously a bug, but it's not yet clear what the best way to fix the issue is.  The binder is small, but complicated -- perhaps the best fix is it rewrite it in a more understandable/robust way?\n\nThis issue is the reason mypy still has a self-typecheck error with #1562.\n","author":{"url":"https://github.com/ddfisher","@type":"Person","name":"ddfisher"},"datePublished":"2016-05-24T00:51:49Z","url":"https://github.com/python/mypy/issues/1568"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:164f23ff-8aff-411e-f0e5-f1782b29c6c8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC8DC:2AD163:28DCD4D:37B2B65:6B0049B5
html-safe-nonce71d5bceb2c741c676d0b69deafc595588f8f8944c097a972371b2d5e4c9d3212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOERDOjJBRDE2MzoyOERDRDREOjM3QjJCNjU6NkIwMDQ5QjUiLCJ2aXNpdG9yX2lkIjoiMjI4NTY5MDMwMjkwMTUzNzIwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f0700953e716b793617f60a857b5f520e6852942e597113aa1e7f9e0c0d38d3
hovercard-subject-tagissue:156397654
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1568/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8484c1ce78a68dbb97f245bb4f0efc9f324805c547bd42558927c02d444ec80c/python/mypy/issues/1568
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8484c1ce78a68dbb97f245bb4f0efc9f324805c547bd42558927c02d444ec80c/python/mypy/issues/1568
og:image:altThe problem with this is most easily visible with list comprehensions: lst = [1, 2, 3] # type: List[Union[int, str]] [x if isinstance(x, int) else 0 for x in lst] reveal_type([x for x in [4, 5, 6]]...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameddfisher
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/1568#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1568
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1568
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/1568
Reloadhttps://github.com/python/mypy/issues/1568
Reloadhttps://github.com/python/mypy/issues/1568
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1568
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1568
isinstance checks cause type declarations to leak from the binderhttps://github.com/python/mypy/issues/1568#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on May 24, 2016https://github.com/python/mypy/issues/1568#issue-156397654
https://github.com/python/mypy/blob/master/mypy/checker.py#L127https://github.com/python/mypy/blob/master/mypy/checker.py#L127
#1562https://github.com/python/mypy/pull/1562
ddfisherhttps://github.com/ddfisher
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 24, 2016https://github.com/python/mypy/issues/1568#event-669669126
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on May 24, 2016https://github.com/python/mypy/issues/1568#issuecomment-221139310
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on May 24, 2016https://github.com/python/mypy/issues/1568#issuecomment-221388671
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on May 31, 2016https://github.com/python/mypy/issues/1568#issuecomment-222585921
@ecpricehttps://github.com/ecprice
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jun 22, 2016https://github.com/python/mypy/issues/1568#issuecomment-227849859
#1044https://github.com/python/mypy/issues/1044
https://github.com/ecprice
ecpricehttps://github.com/ecprice
on Jun 22, 2016https://github.com/python/mypy/issues/1568#issuecomment-227895564
rwbartonhttps://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jun 26, 2016https://github.com/python/mypy/issues/1568#event-704164341
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jun 29, 2016https://github.com/python/mypy/issues/1568#issuecomment-229236548
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 29, 2016https://github.com/python/mypy/issues/1568#issuecomment-229240864
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Jun 29, 2016https://github.com/python/mypy/issues/1568#issuecomment-229241764
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Apr 3, 2017https://github.com/python/mypy/issues/1568#issuecomment-291263383
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Apr 3, 2017https://github.com/python/mypy/issues/1568#issuecomment-291279783
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2017https://github.com/python/mypy/issues/1568#event-1027304262
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/1568
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/1568
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.