René's URL Explorer Experiment


Title: Honor return type of `__new__` even if not a subclass · Issue #15182 · python/mypy · GitHub

Open Graph Title: Honor return type of `__new__` even if not a subclass · Issue #15182 · python/mypy

X Title: Honor return type of `__new__` even if not a subclass · Issue #15182 · python/mypy

Description: This follows gh-1020 which was closed by gh-7188. This arises because I am adding type hints to sympy (sympy/sympy#25103). In the following code we have a subclass whose __new__ method is only guaranteed to return objects that are types ...

Open Graph Description: This follows gh-1020 which was closed by gh-7188. This arises because I am adding type hints to sympy (sympy/sympy#25103). In the following code we have a subclass whose __new__ method is only guar...

X Description: This follows gh-1020 which was closed by gh-7188. This arises because I am adding type hints to sympy (sympy/sympy#25103). In the following code we have a subclass whose __new__ method is only guar...

Opengraph URL: https://github.com/python/mypy/issues/15182

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Honor return type of `__new__` even if not a subclass","articleBody":"This follows gh-1020 which was closed by gh-7188. This arises because I am adding type hints to sympy (https://github.com/sympy/sympy/pull/25103).\r\n\r\nIn the following code we have a subclass whose `__new__` method is only guaranteed to return objects that are types of the superclass:\r\n```python\r\nfrom __future__ import annotations\r\n\r\nclass A:\r\n    def __new__(cls) -> A:\r\n        return super().__new__(cls)\r\n\r\nclass B(A):\r\n    def __new__(cls) -> A:\r\n        return super().__new__(cls)\r\n\r\nreveal_type(B())\r\n```\r\nWith mypy this is rejected and the type of `B()` is inferred incorrectly but pyright accepts this and gets the inference for `B()` correct:\r\n```console\r\n$ mypy q.py\r\nq.py:8: error: Incompatible return type for \"__new__\" (returns \"A\", but must return a subtype of \"B\")  [misc]\r\nq.py:11: note: Revealed type is \"q.B\"\r\nFound 1 error in 1 file (checked 1 source file)\r\n$ pyright q.py\r\n...\r\n  ./q.py:11:13 - information: Type of \"B()\" is \"A\"\r\n0 errors, 0 warnings, 1 information \r\nCompleted in 0.955sec\r\n```\r\nThe fix for `__new__` in gh-7188 was:\r\n\r\n- If the return type is Any, ignore that and keep the class type as\r\nthe return type\r\n- Otherwise respect `__new__`'s return type\r\n- Produce an error if the return type is not a subtype of the class.\r\n\r\nThe issue here is about mixing the last two points. Here mypy produces an error but then does *not* respect `__new__`'s return type. The return type is not respected since mypy infers that it is of type `B` unlike pyright which infers type `A` as specified by the hint. I don't mind mypy reporting an error here but in context `-> A` is the accurate type hint and mypy should respect that because anything else is just not correct. I can add a type ignore to silence the mypy error but the inference will still be wrong in all downstream/user code and is also inconsistent with pyright.","author":{"url":"https://github.com/oscarbenjamin","@type":"Person","name":"oscarbenjamin"},"datePublished":"2023-05-04T15:07:40Z","url":"https://github.com/python/mypy/issues/15182"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ade565b8-f957-f2f6-d2f1-fc420d40ee63
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB084:2DB972:2CA10E3:3AF389D:6B001D7B
html-safe-nonce5a86419c9850a5399508ac0f52e32511507954d1355ae1e6e2039772f93d2955
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDg0OjJEQjk3MjoyQ0ExMEUzOjNBRjM4OUQ6NkIwMDFEN0IiLCJ2aXNpdG9yX2lkIjoiNDU2NzY2NzkzMTE5ODAwNDYwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93b024f665027321f3fb3b1cb4c782fd3abd3f01ea6c971fd1b49f5f9931a751
hovercard-subject-tagissue:1696212117
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/15182/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c5532d03adefc6f4d52c9d0aaf6fc3f9d1ec5b07c5f1eb7d1d7095af3b405992/python/mypy/issues/15182
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c5532d03adefc6f4d52c9d0aaf6fc3f9d1ec5b07c5f1eb7d1d7095af3b405992/python/mypy/issues/15182
og:image:altThis follows gh-1020 which was closed by gh-7188. This arises because I am adding type hints to sympy (sympy/sympy#25103). In the following code we have a subclass whose __new__ method is only guar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameoscarbenjamin
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/15182#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F15182
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F15182
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/15182
Reloadhttps://github.com/python/mypy/issues/15182
Reloadhttps://github.com/python/mypy/issues/15182
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/15182
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/15182
#21441https://github.com/python/mypy/pull/21441
Honor return type of __new__ even if not a subclasshttps://github.com/python/mypy/issues/15182#top
#21441https://github.com/python/mypy/pull/21441
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/oscarbenjamin
oscarbenjaminhttps://github.com/oscarbenjamin
on May 4, 2023https://github.com/python/mypy/issues/15182#issue-1696212117
gh-1020https://github.com/python/mypy/issues/1020
gh-7188https://github.com/python/mypy/pull/7188
sympy/sympy#25103https://github.com/sympy/sympy/pull/25103
gh-7188https://github.com/python/mypy/pull/7188
oscarbenjaminhttps://github.com/oscarbenjamin
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 4, 2023https://github.com/python/mypy/issues/15182#event-9168614707
https://github.com/oscarbenjamin
oscarbenjaminhttps://github.com/oscarbenjamin
on May 4, 2023https://github.com/python/mypy/issues/15182#issuecomment-1535233665
mypy/mypy/typeops.pyhttps://github.com/python/mypy/blob/13f35ad0915e70c2c299e2eb308968c86117132d/mypy/typeops.py#L184-L196
13f35adhttps://github.com/python/mypy/commit/13f35ad0915e70c2c299e2eb308968c86117132d
https://github.com/Viicos
Viicoshttps://github.com/Viicos
on May 4, 2023https://github.com/python/mypy/issues/15182#issuecomment-1535276973
@oscarbenjaminhttps://github.com/oscarbenjamin
#8330https://github.com/python/mypy/issues/8330
#14471https://github.com/python/mypy/pull/14471
https://github.com/oscarbenjamin
oscarbenjaminhttps://github.com/oscarbenjamin
on May 4, 2023https://github.com/python/mypy/issues/15182#issuecomment-1535474260
#8330https://github.com/python/mypy/issues/8330
mypy/mypy/checkmember.pyhttps://github.com/python/mypy/blob/13f35ad0915e70c2c299e2eb308968c86117132d/mypy/checkmember.py#L1198-L1199
13f35adhttps://github.com/python/mypy/commit/13f35ad0915e70c2c299e2eb308968c86117132d
https://github.com/NeilGirdhar
NeilGirdharhttps://github.com/NeilGirdhar
on Dec 19, 2023https://github.com/python/mypy/issues/15182#issuecomment-1863574936
nnxhttps://github.com/google/flax/tree/main/flax/experimental/nnx
herehttps://github.com/google/flax/blob/f1cb0114a3aacefd28676cc6796613c916788af8/flax/experimental/nnx/nnx/variables.py#L89
https://github.com/Viicos
Viicoshttps://github.com/Viicos
on Dec 20, 2023https://github.com/python/mypy/issues/15182#issuecomment-1863915763
nnxhttps://github.com/google/flax/tree/main/flax/experimental/nnx
herehttps://github.com/google/flax/blob/f1cb0114a3aacefd28676cc6796613c916788af8/flax/experimental/nnx/nnx/variables.py#L89
#16020 (comment)https://github.com/python/mypy/pull/16020#issuecomment-1761244557
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 25, 2024https://github.com/python/mypy/issues/15182#issuecomment-2017730441
python/typeshed#11645https://github.com/python/typeshed/issues/11645
python/typeshed#11646https://github.com/python/typeshed/pull/11646
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 25, 2024https://github.com/python/mypy/issues/15182#issuecomment-2017745235
@oscarbenjaminhttps://github.com/oscarbenjamin
https://mypy-play.net/?mypy=latest&python=3.12&flags=strict&gist=336602d390b5e6566e9fca93d7fa48a6https://mypy-play.net/?mypy=latest&python=3.12&flags=strict&gist=336602d390b5e6566e9fca93d7fa48a6
https://github.com/Viicos
Viicoshttps://github.com/Viicos
on Mar 25, 2024https://github.com/python/mypy/issues/15182#issuecomment-2017757575
#16020https://github.com/python/mypy/pull/16020
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Jul 5, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211083626
@Viicoshttps://github.com/Viicos
#16020https://github.com/python/mypy/pull/16020
#15182https://github.com/python/mypy/issues/15182
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Jul 5, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211087503
section on the __new__ methodhttps://typing.readthedocs.io/en/latest/spec/constructors.html#new-method
https://github.com/oscarbenjamin
oscarbenjaminhttps://github.com/oscarbenjamin
on Jul 5, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211169942
gh-14122https://github.com/python/mypy/issues/14122
https://github.com/Viicos
Viicoshttps://github.com/Viicos
on Jul 6, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211791782
@Viicoshttps://github.com/Viicos
#16020https://github.com/python/mypy/pull/16020
#15182https://github.com/python/mypy/issues/15182
mypy/test-data/unit/check-classes.testhttps://github.com/python/mypy/blob/cdccffa7c009988a3f1677328965fa35e066889b/test-data/unit/check-classes.test#L6925-L6931
cdccffahttps://github.com/python/mypy/commit/cdccffa7c009988a3f1677328965fa35e066889b
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Jul 6, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211800404
@Viicoshttps://github.com/Viicos
https://github.com/oscarbenjamin
oscarbenjaminhttps://github.com/oscarbenjamin
on Jul 6, 2024https://github.com/python/mypy/issues/15182#issuecomment-2211804585
#16020https://github.com/python/mypy/pull/16020
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Feb 28, 2025https://github.com/python/mypy/issues/15182#issuecomment-2690406846
#18343 (comment)https://github.com/python/mypy/issues/18343#issuecomment-2571784915
https://github.com/Avasam
Avasamhttps://github.com/Avasam
on May 25, 2025https://github.com/python/mypy/issues/15182#issuecomment-2908173883
sterliakovhttps://github.com/sterliakov
__new__ return types are not respected (reported as error and overwritten by the current class) unless the return type is a subclass of the current class #19624https://github.com/python/mypy/issues/19624
on Aug 9, 2025https://github.com/python/mypy/issues/15182#event-19067982344
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
938dbe2https://github.com/python/mypy/commit/938dbe2fe79359e6d97ff5319a40b61f7af446fd
on May 27, 2026https://github.com/python/mypy/issues/15182#event-25993406653
pullhttps://github.com/apps/pull
on May 27, 2026https://github.com/python/mypy/issues/15182#event-25994368346
Respect explicit return type of __new__() (python#21441)https://github.com/LadyK-21/mypy/commit/938dbe2fe79359e6d97ff5319a40b61f7af446fd
python#21441https://github.com/python/mypy/pull/21441
938dbe2https://github.com/LadyK-21/mypy/commit/938dbe2fe79359e6d97ff5319a40b61f7af446fd
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/15182
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/15182
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.