Title: Decorator factory function typing · Issue #15037 · python/mypy · GitHub
Open Graph Title: Decorator factory function typing · Issue #15037 · python/mypy
X Title: Decorator factory function typing · Issue #15037 · python/mypy
Description: Bug Report I have a decorator factory function that takes a schema and returns a decorator that validates something against the provided schema and also passes in an argument to the wrapped function. Here's a simplified version of the co...
Open Graph Description: Bug Report I have a decorator factory function that takes a schema and returns a decorator that validates something against the provided schema and also passes in an argument to the wrapped functio...
X Description: Bug Report I have a decorator factory function that takes a schema and returns a decorator that validates something against the provided schema and also passes in an argument to the wrapped functio...
Opengraph URL: https://github.com/python/mypy/issues/15037
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Decorator factory function typing ","articleBody":"\u003c!--\r\nIf you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form instead.\r\nPlease consider:\r\n\r\n- checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\r\n- searching our issue tracker: https://github.com/python/mypy/issues to see if it's already been reported\r\n- asking on gitter chat: https://gitter.im/python/typing\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nIf you're reporting a problem with a specific library function, the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues\r\n\r\nIf the project you encountered the issue in is open source, please provide a link to the project.\r\n-->\r\n\r\nI have a decorator factory function that takes a schema and returns a decorator that validates something against the provided schema and also passes in an argument to the wrapped function. Here's a simplified version of the code:\r\n\r\n```python\r\nfrom typing import Any, Callable, Concatenate, ParamSpec, TypeVar\r\n\r\nP = ParamSpec(\"P\")\r\nSchema = TypeVar(\"Schema\") \r\nRet = TypeVar(\"Ret\") \r\n\r\ndef validate(\r\n schema: Schema,\r\n) -> Callable[\r\n [Callable[Concatenate[int, P], Ret]],\r\n Callable[P, Ret],\r\n]:\r\n def decorator(\r\n f: Callable[\r\n Concatenate[int, P], Ret\r\n ]\r\n ) -> Callable[P, Ret]:\r\n def wrap(*args: P.args, **kwargs: P.kwargs) -> Ret: \r\n # for simplicity, omitting schema validation \r\n # that would normally happen here.\r\n \r\n additional_arg = 42 # also simplified\r\n return f(additional_arg, *args, **kwargs)\r\n\r\n return wrap\r\n\r\n return decorator\r\n```\r\n\r\nWith mypy 1.1.1, the type annotations are fine. But with the recently released mypy 1.2.0, I get this error:\r\n\r\n```\r\nerror: Incompatible return value type (got \"Callable[[Arg(Callable[[int, **P], Ret], 'f')], Callable[P, Ret]]\", expected \"Callable[[Callable[[int, **P], Ret]], Callable[P, Ret]]\") [return-value]\r\n```\r\n\r\n**To Reproduce**\r\n\r\nRun the following with mypy 1.2.0 (example returns an error) and mypy 1.1.1 (no error):\r\n\r\n- Playground URL: https://mypy-play.net/?mypy=1.2.0&python=3.11&gist=c8cc63e9ae1cc5b82fc0b613a26aa302\r\n- Gist URL: https://gist.github.com/mypy-play/c8cc63e9ae1cc5b82fc0b613a26aa302\r\n\r\n**Expected Behavior**\r\n\r\nI'd expect mypy to not return an error unless there is a legitimate issue with the types in this code (if that's the case, please let me know!).\r\n\r\nMoreover, the actual type in the error message doesn't seem to be a valid type (specifically `Arg(Callable[[int, **P], Ret], 'f')` in this example). \r\n\r\n**Actual Behavior**\r\n\r\n```error: Incompatible return value type (got \"Callable[[Arg(Callable[[int, **P], Ret], 'f')], Callable[P, Ret]]\", expected \"Callable[[Callable[[int, **P], Ret]], Callable[P, Ret]]\") [return-value]```\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 1.2.0\r\n- Mypy command-line flags: none\r\n- Mypy configuration options from `mypy.ini` (and other config files): n/a\r\n- Python version used: 3.11\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n","author":{"url":"https://github.com/ssamojl","@type":"Person","name":"ssamojl"},"datePublished":"2023-04-11T16:32:32Z","url":"https://github.com/python/mypy/issues/15037"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cb4328c3-e24f-f46d-562d-6097fb046fdd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86DC:1EE55B:1843BA7:20F7DB4:6AFFF95D |
| html-safe-nonce | 6c25ae897e2d43074593299b540353314e644604d903abcc6fffac7a1715f619 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkRDOjFFRTU1QjoxODQzQkE3OjIwRjdEQjQ6NkFGRkY5NUQiLCJ2aXNpdG9yX2lkIjoiNDE4NDAwNTAwNTIyNjgwMTUwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aee8ef962296d01a1b66a1434b498571e01515a6af93a9f5b15d21d7d77cf7be |
| hovercard-subject-tag | issue:1662863735 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/15037/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0d7fdd916c100b8acc38e1bd2b21382cd7dfd53dfe7a405907c941a9908ca723/python/mypy/issues/15037 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0d7fdd916c100b8acc38e1bd2b21382cd7dfd53dfe7a405907c941a9908ca723/python/mypy/issues/15037 |
| og:image:alt | Bug Report I have a decorator factory function that takes a schema and returns a decorator that validates something against the provided schema and also passes in an argument to the wrapped functio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ssamojl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width