René's URL Explorer Experiment


Title: Inconsistent behavior w.r.t missing builtins · Issue #14547 · python/mypy · GitHub

Open Graph Title: Inconsistent behavior w.r.t missing builtins · Issue #14547 · python/mypy

X Title: Inconsistent behavior w.r.t missing builtins · Issue #14547 · python/mypy

Description: Issue Some of the builtins fixtures are sparse to the point that they're missing even the declaration of dict, list, tuple etc. types. The austerity is justified by improved tests performance, and it's understood that specific tests can ...

Open Graph Description: Issue Some of the builtins fixtures are sparse to the point that they're missing even the declaration of dict, list, tuple etc. types. The austerity is justified by improved tests performance, and ...

X Description: Issue Some of the builtins fixtures are sparse to the point that they're missing even the declaration of dict, list, tuple etc. types. The austerity is justified by improved tests performance, ...

Opengraph URL: https://github.com/python/mypy/issues/14547

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistent behavior w.r.t missing builtins","articleBody":"# Issue\r\n\r\nSome of the builtins fixtures are sparse to the point that they're missing even the declaration of `dict`, `list`, `tuple` etc. types. The austerity is justified by improved tests performance, and it's understood that specific tests can specify a broader fixture without slowing down other tests.\r\n\r\nHowever, some core features rely on the presence of those types, e.g.\r\n- functions' `**kwargs`\r\n- modules' `__annotations__`\r\n- `namedtuple`'s attributes like `_field_types`\r\n\r\nI've observed 3 different strategies used to handle the types absence:\r\n- **crash** (example: [`**kwargs` handling](https://github.com/python/mypy/blob/e778a58066f23982d5cbe1df5317d6540c5902fd/mypy/types.py#L3607))\r\n- **give up** (example: [`__annotations__` not being added](https://github.com/python/mypy/blob/bac9e77eaeb36c0535bc05cb1faf6eced25b8af1/mypy/semanal.py#L636-L639))\r\n- **fallback to `object`** (example: [`NamedTuple` attributes](https://github.com/python/mypy/blob/dcf910e05fdcff00b1fb9a8b9ca85f9a6667b946/mypy/semanal_namedtuple.py#L484-L486))\r\n\r\nI think we should recommend and, ideally, consolidate on one strategy.\r\n\r\n# Motivation\r\n\r\nCase in point: Recently while implementing #14526, I had to \"play\" a whack-a-mole with unrelated tests breaking. I've used `**kw` which required me to add `dict` to a number of builtins fixtures, which in turn caused `__annotations__` to materialize where they didn't before, and failed some other tests.\r\n\r\nI think ideally we shouldn't have this whack-a-mole, and tests should be less brittle.\r\n\r\n# Recommendation\r\n\r\nWhich strategy to adopt? While it's good practice to structure code to be more testable, I think it's normally discouraged to have code paths that are only due to testing. Since those builtins should universally exist in \"production\", I think **crash** should be our strategy.\r\n\r\nSince code typically relies only on the presence of those classes (not their methods), we can put in place a rule (validated by tests) that any builtins fixture must define a baseline of types, even if empty. This shouldn't affect performance greatly, and provide a comfortable baseline.","author":{"url":"https://github.com/ikonst","@type":"Person","name":"ikonst"},"datePublished":"2023-01-28T16:18:02Z","url":"https://github.com/python/mypy/issues/14547"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:90a5aacb-7cd1-18d6-fc08-877507513475
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA8E6:3FDF0C:5084F7:6BB2CF:6B002F13
html-safe-nonce237445efae8f546c5e34b76adc13582f107e6cc43c2434c0b5900a92e0122ce9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEU2OjNGREYwQzo1MDg0Rjc6NkJCMkNGOjZCMDAyRjEzIiwidmlzaXRvcl9pZCI6IjQ3NTkwMDc5NTk3MzA2MzA0MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac040b83f0a69ff903180e7d776cfefb6b1767d199ea3a5659bab5b1aacd53de0e
hovercard-subject-tagissue:1560917904
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14547/issue_layout
twitter:imagehttps://opengraph.githubassets.com/51ec21d5e2bf41e42ba927a9a6d4e4804fd415c650bf2c5d79b8f4ada94526b3/python/mypy/issues/14547
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/51ec21d5e2bf41e42ba927a9a6d4e4804fd415c650bf2c5d79b8f4ada94526b3/python/mypy/issues/14547
og:image:altIssue Some of the builtins fixtures are sparse to the point that they're missing even the declaration of dict, list, tuple etc. types. The austerity is justified by improved tests performance, and ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameikonst
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/14547#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14547
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14547
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/14547
Reloadhttps://github.com/python/mypy/issues/14547
Reloadhttps://github.com/python/mypy/issues/14547
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14547
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14547
Inconsistent behavior w.r.t missing builtinshttps://github.com/python/mypy/issues/14547#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-developerIssues relevant to mypy developershttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-developer%22
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jan 28, 2023https://github.com/python/mypy/issues/14547#issue-1560917904
**kwargs handlinghttps://github.com/python/mypy/blob/e778a58066f23982d5cbe1df5317d6540c5902fd/mypy/types.py#L3607
__annotations__ not being addedhttps://github.com/python/mypy/blob/bac9e77eaeb36c0535bc05cb1faf6eced25b8af1/mypy/semanal.py#L636-L639
NamedTuple attributeshttps://github.com/python/mypy/blob/dcf910e05fdcff00b1fb9a8b9ca85f9a6667b946/mypy/semanal_namedtuple.py#L484-L486
#14526https://github.com/python/mypy/pull/14526
ikonsthttps://github.com/ikonst
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Jan 28, 2023https://github.com/python/mypy/issues/14547#event-8380015214
AlexWaygoodhttps://github.com/AlexWaygood
topic-developerIssues relevant to mypy developershttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-developer%22
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
on Jan 28, 2023https://github.com/python/mypy/issues/14547#event-8380020448
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jan 28, 2023https://github.com/python/mypy/issues/14547#issuecomment-1407434589
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jan 28, 2023https://github.com/python/mypy/issues/14547#issuecomment-1407460588
hauntsaninjahttps://github.com/hauntsaninja
on Jan 30, 2023https://github.com/python/mypy/issues/14547#event-8385829303
Fail-fast on missing builtins (#14550)https://github.com/python/mypy/commit/f31d162415c97096cce62827bc89db0c751d6bfb
#14550https://github.com/python/mypy/pull/14550
f31d162https://github.com/python/mypy/commit/f31d162415c97096cce62827bc89db0c751d6bfb
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jan 30, 2023https://github.com/python/mypy/issues/14547#issuecomment-1409312356
mypy/mypy/checkexpr.pyhttps://github.com/python/mypy/blob/91e858199147e69cbc6f2f658ded66ebd31086f6/mypy/checkexpr.py#L392-L398
91e8581https://github.com/python/mypy/commit/91e858199147e69cbc6f2f658ded66ebd31086f6
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/14547
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/14547
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-developerIssues relevant to mypy developershttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-developer%22
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.