Title: Assigning wrapped class members to a member defined by a base class fails with incompatible types in assignment · Issue #14408 · python/mypy · GitHub
Open Graph Title: Assigning wrapped class members to a member defined by a base class fails with incompatible types in assignment · Issue #14408 · python/mypy
X Title: Assigning wrapped class members to a member defined by a base class fails with incompatible types in assignment · Issue #14408 · python/mypy
Description: Bug Report Consider the following code, where wrap is some decorator that preserves the function signature: class Base: def f(self, a: int) -> int: return a + 1 def g(self, a: int) -> int: return a + 1 class Derived(Base): @wrap def f(se...
Open Graph Description: Bug Report Consider the following code, where wrap is some decorator that preserves the function signature: class Base: def f(self, a: int) -> int: return a + 1 def g(self, a: int) -> int: return a...
X Description: Bug Report Consider the following code, where wrap is some decorator that preserves the function signature: class Base: def f(self, a: int) -> int: return a + 1 def g(self, a: int) -> int: re...
Opengraph URL: https://github.com/python/mypy/issues/14408
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Assigning wrapped class members to a member defined by a base class fails with incompatible types in assignment","articleBody":"**Bug Report**\r\n\r\nConsider the following code, where `wrap` is some decorator that preserves the function signature:\r\n\r\n```python\r\nclass Base:\r\n def f(self, a: int) -> int:\r\n return a + 1\r\n\r\n def g(self, a: int) -> int:\r\n return a + 1\r\n\r\nclass Derived(Base):\r\n @wrap\r\n def f(self, a: int) -> int:\r\n return a + 2\r\n\r\n def _g(self, a: int) -> int:\r\n return a + 2 \r\n\r\n g = wrap(_g)\r\n```\r\n\r\nThe assignment `g = wrap(_g)` fails with `Argument 1 to \"wrap\" has incompatible type \"Callable[[Dervied, int], int]\"; expected \"Callable[[Base, int], int]\"`. I would have expected both ways of wrapping a function to be the same (ans as far as I can tell they do so at runtime) and therefore both should be allowed.\r\n\r\nThis is also not a general issue with assignments as the following code type checks:\r\n\r\n```python\r\nclass Base:\r\n def f(self, a: int) -> int:\r\n return a + 1\r\n\r\nclass Derived(Base):\r\n def _f(self, a: int) -> int:\r\n return a + 2\r\n\r\n f = _f\r\n```\r\n\r\n**To Reproduce**\r\n\r\nhttps://mypy-play.net/?mypy=master&python=3.11&gist=2455e6265bf5ec9cc5ffac2d95accf98\r\n\r\nNote that mypy-play seems to use c660354846688ff8158d0f0178eb298171b74f5b rather than the latest commit from master for some reason. The output on current master is slightly different (the type of `C.abc` is no longer consider `def (self: __main__.A, a: builtins.int) -> builtins.int`):\r\n```\r\ntest_assign_function_subclass.py:32: error: Incompatible types in assignment (expression has type \"Callable[[C, int], int]\", base class \"A\" defined the type as \"Callable[[A, int], int]\") [assignment]\r\ntest_assign_function_subclass.py:50: error: Cannot determine type of \"abc\" [has-type]\r\ntest_assign_function_subclass.py:55: note: Revealed type is \"def (self: test_assign_function_subclass.A, a: builtins.int) -> builtins.int\"\r\ntest_assign_function_subclass.py:56: note: Revealed type is \"def (self: test_assign_function_subclass.B, a: builtins.int) -> builtins.int\"\r\ntest_assign_function_subclass.py:57: error: Cannot determine type of \"abc\" [has-type]\r\ntest_assign_function_subclass.py:57: note: Revealed type is \"Any\"\r\ntest_assign_function_subclass.py:58: note: Revealed type is \"def (self: test_assign_function_subclass.D, a: builtins.int) -> builtins.int\"\r\ntest_assign_function_subclass.py:59: note: Revealed type is \"def (self: test_assign_function_subclass.E, a: builtins.int) -> builtins.int\"\r\nFound 3 errors in 1 file (checked 1 source file)\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nNo error, code type checks \r\n\r\n**Actual Behavior**\r\n\r\n```\r\nmain.py:32: error: Argument 1 to \"wrap\" has incompatible type \"Callable[[C, int], int]\"; expected \"Callable[[A, int], int]\" [arg-type]\r\n```\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 98cc165a657a316accb93f1ed57fdc128b086d9f\r\n- Mypy command-line flags: None\r\n- Mypy configuration options from `mypy.ini` (and other config files): None\r\n- Python version used: 3.10 & 3.11\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n","author":{"url":"https://github.com/VincentVanlaer","@type":"Person","name":"VincentVanlaer"},"datePublished":"2023-01-06T22:21:10Z","url":"https://github.com/python/mypy/issues/14408"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:90a88774-a743-f6e3-19bc-f880e004b37f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9CC6:2B41BC:34D5B2:473F47:6B0027F0 |
| html-safe-nonce | da9dc4b3ae537fd520aaa3c1b091552000a64315ff8fc185287de0c60c45f231 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0M2OjJCNDFCQzozNEQ1QjI6NDczRjQ3OjZCMDAyN0YwIiwidmlzaXRvcl9pZCI6IjI1OTE4MTM3MjMyNjE3NzM4MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ae3745d50a136f0b144b09134fa362d5f6b81fbc8d8342920043b549c63fd55a |
| hovercard-subject-tag | issue:1523251440 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14408/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d59e611fe047c6dc96bf2be6ad22e6ff7abc789277d5a1b339594c15dbc24bed/python/mypy/issues/14408 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d59e611fe047c6dc96bf2be6ad22e6ff7abc789277d5a1b339594c15dbc24bed/python/mypy/issues/14408 |
| og:image:alt | Bug Report Consider the following code, where wrap is some decorator that preserves the function signature: class Base: def f(self, a: int) -> int: return a + 1 def g(self, a: int) -> int: return a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | VincentVanlaer |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width