René's URL Explorer Experiment


Title: False positive with inherited writable property that reads subtype in subclass · Issue #14301 · python/mypy · GitHub

Open Graph Title: False positive with inherited writable property that reads subtype in subclass · Issue #14301 · python/mypy

X Title: False positive with inherited writable property that reads subtype in subclass · Issue #14301 · python/mypy

Description: If I run mypy on the following code: class Base: value = 123 @property def x(self) -> int: return self.value @x.setter def x(self, value: int) -> None: self.value = value class Sub(Base): @property def x(self) -> bool: return self.value ...

Open Graph Description: If I run mypy on the following code: class Base: value = 123 @property def x(self) -> int: return self.value @x.setter def x(self, value: int) -> None: self.value = value class Sub(Base): @property...

X Description: If I run mypy on the following code: class Base: value = 123 @property def x(self) -> int: return self.value @x.setter def x(self, value: int) -> None: self.value = value class Sub(Base): @pr...

Opengraph URL: https://github.com/python/mypy/issues/14301

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False positive with inherited writable property that reads subtype in subclass","articleBody":"If I run mypy on the following code:\r\n\r\n```py\r\nclass Base:\r\n    value = 123\r\n\r\n    @property\r\n    def x(self) -> int:\r\n        return self.value\r\n\r\n    @x.setter\r\n    def x(self, value: int) -> None:\r\n        self.value = value\r\n\r\nclass Sub(Base):\r\n    @property\r\n    def x(self) -> bool:\r\n        return self.value != 0\r\n    \r\n    @x.setter\r\n    def x(self, value: int) -> None:\r\n        self.value = value\r\n```\r\n\r\nIt reports:\r\n```\r\nerror: Signature of \"x\" incompatible with supertype \"Base\"  [override]\r\n```\r\n\r\nI'd expect mypy to not report any error, as `bool` is a subtype of `int` and therefore the property type returned by the subclass always conforms to the property type defined in the superclass.\r\n\r\nThis problem only occurs for writable properties: if I remove the setter definitions from both the superclass and the subclass, no false positive is reported.\r\n\r\nI can produce this problem using mypy 0.991 on Python 3.10.8. When using mypy 0.981 instead, no false positive is reported.\r\n","author":{"url":"https://github.com/mthuurne","@type":"Person","name":"mthuurne"},"datePublished":"2022-12-15T21:46:27Z","url":"https://github.com/python/mypy/issues/14301"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:dbc563d1-5a3d-b5f6-c1cd-ba144241bdda
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93C6:1A77D:107E28:163CD0:6B001DC1
html-safe-noncecf47bb80e430f198ed278f3e7007f8bc829cdcdf86981889faddb9fe5576d5e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0M2OjFBNzdEOjEwN0UyODoxNjNDRDA6NkIwMDFEQzEiLCJ2aXNpdG9yX2lkIjoiNjQ4MjIwMjQxMDAxMjkwODk5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9b48f32236d77a4ab1eb159a4c7c9db5fcdcc0fc179cd42cdd2abdaaed8eb62f
hovercard-subject-tagissue:1499152181
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14301/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1721d3c5ee6a799b4f2cc14bc183079151b40face24cbd8cfa013521e797570f/python/mypy/issues/14301
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1721d3c5ee6a799b4f2cc14bc183079151b40face24cbd8cfa013521e797570f/python/mypy/issues/14301
og:image:altIf I run mypy on the following code: class Base: value = 123 @property def x(self) -> int: return self.value @x.setter def x(self, value: int) -> None: self.value = value class Sub(Base): @property...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemthuurne
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/14301#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14301
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14301
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/14301
Reloadhttps://github.com/python/mypy/issues/14301
Reloadhttps://github.com/python/mypy/issues/14301
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14301
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14301
#18510https://github.com/python/mypy/pull/18510
False positive with inherited writable property that reads subtype in subclasshttps://github.com/python/mypy/issues/14301#top
#18510https://github.com/python/mypy/pull/18510
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
topic-inheritanceInheritance and incompatible overrideshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-inheritance%22
https://github.com/mthuurne
mthuurnehttps://github.com/mthuurne
on Dec 15, 2022https://github.com/python/mypy/issues/14301#issue-1499152181
mthuurnehttps://github.com/mthuurne
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Dec 15, 2022https://github.com/python/mypy/issues/14301#event-8051346678
AlexWaygoodhttps://github.com/AlexWaygood
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
topic-inheritanceInheritance and incompatible overrideshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-inheritance%22
on Dec 15, 2022https://github.com/python/mypy/issues/14301#event-8051370145
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#18510https://github.com/python/mypy/pull/18510
on Jan 25, 2025https://github.com/python/mypy/issues/14301#event-16068177236
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
1eb9d4chttps://github.com/python/mypy/commit/1eb9d4ce36144d9e2e7c79dc35d517b4e1963dd7
on Jan 25, 2025https://github.com/python/mypy/issues/14301#event-16068177246
cdce8phttps://github.com/cdce8p
on Jan 25, 2025https://github.com/python/mypy/issues/14301#event-16068226585
Support properties with setter type different from getter type (pytho…https://github.com/cdce8p/mypy/commit/1eb9d4ce36144d9e2e7c79dc35d517b4e1963dd7
pytho…https://github.com/python/mypy/pull/18510
1eb9d4chttps://github.com/cdce8p/mypy/commit/1eb9d4ce36144d9e2e7c79dc35d517b4e1963dd7
x612skmhttps://github.com/x612skm
on Feb 24, 2025https://github.com/python/mypy/issues/14301#event-16437209720
Support properties with setter type different from getter type (pytho…https://github.com/x612skm/mypy-dev/commit/0f5b2e9cca3d8f4299dc19c2df0f09d30a999d75
pytho…https://github.com/python/mypy/pull/18510
0f5b2e9https://github.com/x612skm/mypy-dev/commit/0f5b2e9cca3d8f4299dc19c2df0f09d30a999d75
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/14301
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/14301
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
topic-inheritanceInheritance and incompatible overrideshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-inheritance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.