Title: Wildly inconsistent performance for seemingly trivial changes to source code · Issue #14271 · python/mypy · GitHub
Open Graph Title: Wildly inconsistent performance for seemingly trivial changes to source code · Issue #14271 · python/mypy
X Title: Wildly inconsistent performance for seemingly trivial changes to source code · Issue #14271 · python/mypy
Description: My company is currently using 0.971 internally. I was looking into upgrading to 0.991 and discovered a significant performance regression. Encourage by the recent commit log I tried the master branch as well, which is definitely better b...
Open Graph Description: My company is currently using 0.971 internally. I was looking into upgrading to 0.991 and discovered a significant performance regression. Encourage by the recent commit log I tried the master bran...
X Description: My company is currently using 0.971 internally. I was looking into upgrading to 0.991 and discovered a significant performance regression. Encourage by the recent commit log I tried the master bran...
Opengraph URL: https://github.com/python/mypy/issues/14271
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wildly inconsistent performance for seemingly trivial changes to source code","articleBody":"My company is currently using 0.971 internally. I was looking into upgrading to 0.991 and discovered a significant performance regression. Encourage by the recent commit log I tried the master branch as well, which is definitely better but still much worse than 0.971 on our codebase: roughly 4x slower: from ~300s to ~1200s for whole-codebase run without incremental cache.\r\n\r\nIn the course of narrowing down the slowdown (via per-file and per-line timing stats), I discovered a surprisingly large performance difference for seemingly very similar code. Consider:\r\n\r\n```\r\nfrom typing import Any, Dict\r\n\r\nclass Foo(object):\r\n def __init__(self) -> None:\r\n self.field = {\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n }\r\n ],\r\n },\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n },\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n },\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 2,\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n }\r\n ]\r\n }\r\n }\r\n },\r\n ]\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 2,\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n }\r\n ]\r\n }\r\n }\r\n },\r\n ]\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 2,\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n }\r\n ]\r\n }\r\n }\r\n },\r\n ]\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': {\r\n 'XXX': [\r\n {\r\n 'XXX': {\r\n 'XXX': {\r\n 'XXX': 2,\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n }\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n }\r\n ]\r\n }\r\n }\r\n },\r\n ]\r\n }\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': None,\r\n 'XXX': None\r\n }\r\n ]\r\n },\r\n 'XXX': {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX',\r\n 'XXX': [\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n },\r\n {\r\n 'XXX': 'XXX',\r\n 'XXX': 'XXX'\r\n }\r\n ]\r\n }\r\n }\r\n }\r\n\r\n\r\nreveal_type(Foo.field)\r\n\r\n```\r\n\r\nResults in:\r\n\r\n```\r\ntest-san.py:286: note: Revealed type is \"builtins.dict[builtins.str, builtins.dict[builtins.str, typing.Collection[builtins.str]]]\"\r\nSuccess: no issues found in 1 source file\r\n\r\nreal\t0m1.238s\r\nuser\t0m1.140s\r\nsys\t0m0.089s\r\n```\r\n\r\nBut changing the code to:\r\n```\r\nfrom typing import Any, Dict\r\n\r\nclass Foo(object):\r\n def __init__(self) -> None:\r\n self.field: Dict[Any, Any] = NotImplemented\r\n\r\n def reset(self) -> None:\r\n self.field = {\r\n # same contents as above...\r\n }\r\n```\r\n\r\nchanges the runtime quite significantly:\r\n\r\n```\r\ntest-san.py:289: note: Revealed type is \"builtins.dict[Any, Any]\"\r\nSuccess: no issues found in 1 source file\r\n\r\nreal\t0m10.080s\r\nuser\t0m9.790s\r\nsys\t0m0.256s\r\n```\r\n\r\nand a further code change as follows:\r\n```\r\nfrom typing import Any, Dict\r\n\r\nclass Foo(object):\r\n def __init__(self) -> None:\r\n self.field = NotImplemented\r\n\r\n def reset(self) -> None:\r\n self.field = {\r\n # same contents as above...\r\n }\r\n```\r\n\r\nleads to another noticeable perf hit:\r\n```\r\n$ time mypy test-san.py\r\ntest-san.py:9: error: Incompatible types in assignment (expression has type \"Dict[str, Dict[str, Collection[str]]]\", variable has type \"_NotImplementedType\") [assignment]\r\ntest-san.py:289: note: Revealed type is \"builtins._NotImplementedType\"\r\nFound 1 error in 1 file (checked 1 source file)\r\n\r\nreal\t0m22.067s\r\nuser\t0m21.666s\r\nsys\t0m0.319s\r\n```\r\n\r\nI haven't had time to profile this yet but I suspect it is related to https://github.com/python/mypy/pull/9477 and https://github.com/python/mypy/pull/12707 and that somehow one version of the code hits the optimization and another doesn't\r\n\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: master as of `695ea3017fee084c9d2ec17d9b28f8af905e3b63`, mypyc-compiled\r\n- Mypy command-line flags: N/A\r\n- Mypy configuration options from `mypy.ini` (and other config files): N/A\r\n- Python version used: 3.7.8\r\n- OS: macOS 12.5.1 (x86_64)\r\n\r\n","author":{"url":"https://github.com/huguesb","@type":"Person","name":"huguesb"},"datePublished":"2022-12-10T04:24:20Z","url":"https://github.com/python/mypy/issues/14271"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2134db2d-65ad-d970-e8d4-7f489aa1962a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BB0C:9E1B2:2EAA5B4:3DADC60:6B002407 |
| html-safe-nonce | 8275233df49e271dd692595b21975fcefb5cd4216aa9feabd8b9bb5d7c3bb73d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjBDOjlFMUIyOjJFQUE1QjQ6M0RBREM2MDo2QjAwMjQwNyIsInZpc2l0b3JfaWQiOiIxNDExMTM4NzU0MTY4NDk3MTU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ac89574bace050c72d4a2c95250abf7485b252f8915a6efcf1e8e05da1705179 |
| hovercard-subject-tag | issue:1487914719 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14271/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c8e65eea240387c9cc2d4096aa2481ca472ca9522397c29c1cc42c238d812bb8/python/mypy/issues/14271 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c8e65eea240387c9cc2d4096aa2481ca472ca9522397c29c1cc42c238d812bb8/python/mypy/issues/14271 |
| og:image:alt | My company is currently using 0.971 internally. I was looking into upgrading to 0.991 and discovered a significant performance regression. Encourage by the recent commit log I tried the master bran... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | huguesb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width