René's URL Explorer Experiment


Title: mypy 0.990 is 1000x slow on pydantic codebase vs 0.982 · Issue #14034 · python/mypy · GitHub

Open Graph Title: mypy 0.990 is 1000x slow on pydantic codebase vs 0.982 · Issue #14034 · python/mypy

X Title: mypy 0.990 is 1000x slow on pydantic codebase vs 0.982 · Issue #14034 · python/mypy

Description: Bug Report Running mypy on the current pydantic codebase (specifically the code as of pydantic/pydantic#4735), give the following run times: running mypy pydantic with mypy 0.982, and no .mypy_cache: 8s running mypy pydantic with mypy 0....

Open Graph Description: Bug Report Running mypy on the current pydantic codebase (specifically the code as of pydantic/pydantic#4735), give the following run times: running mypy pydantic with mypy 0.982, and no .mypy_cach...

X Description: Bug Report Running mypy on the current pydantic codebase (specifically the code as of pydantic/pydantic#4735), give the following run times: running mypy pydantic with mypy 0.982, and no .mypy_cach...

Opengraph URL: https://github.com/python/mypy/issues/14034

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy 0.990 is 1000x slow on pydantic codebase vs 0.982","articleBody":"**Bug Report**\r\n\r\nRunning mypy on the current pydantic codebase (specifically the code as of https://github.com/pydantic/pydantic/pull/4735), give the following run times:\r\n\r\n* running `mypy pydantic` with mypy `0.982`, and no `.mypy_cache`: 8s\r\n* running `mypy pydantic` with mypy `0.982`, `.mypy_cache` present: 0.17s\r\n* running `mypy pydantic` with mypy `0.990`, and no `.mypy_cache`: 3m19s\r\n* running `mypy pydantic` with mypy `0.990`, `.mypy_cache` present: 3m6s\r\n\r\n(1000x comes from `(3 * 60 + 6) / 0.17`)\r\n\r\nThere are quite a few errors, mostly due to `no_implicit_optional=True`, but still - this seems like a significant regression.\r\n\r\nWhile mypy 0.990 is running, I see 100% usage on 1 CPU.\r\n\r\n**To Reproduce**\r\n\r\nShould be as simple as cloning pydantic, checkout that branch (`uprev-mypy`), install requirements from `requirements/linting.txt`, run mypy.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: `0.990`\r\n- Mypy command-line flags: just `mypy pydantic`\r\n- Mypy configuration options from `mypy.ini` (and other config files): see [this bit of `pyproject.toml`](https://github.com/pydantic/pydantic/blob/aea7016e6cbc7c589713e9ffb7891316d9cde262/pyproject.toml#L155-L187)\r\n- Python version used:3.10.0 (just realised how old my version of 3.10 is, I've upgraded to 3.10.8, same result)\r\n\r\n\r\n","author":{"url":"https://github.com/samuelcolvin","@type":"Person","name":"samuelcolvin"},"datePublished":"2022-11-08T11:20:14Z","url":"https://github.com/python/mypy/issues/14034"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6a7ca6a2-4f63-e5fd-4031-4589d2f08abf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC300:1BAA33:2282911:2DE233B:6B004E7C
html-safe-nonce4fab5020c34a89c1c8d63765c27fdb3a5d151f3894148f1878748ba6f690bd0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzAwOjFCQUEzMzoyMjgyOTExOjJERTIzM0I6NkIwMDRFN0MiLCJ2aXNpdG9yX2lkIjoiNzg0MDYwOTA0NDI3OTYxMTAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc03cc866343ee65a7fec30bebbcaaddf9626001582c29c794ae35d1d36369106
hovercard-subject-tagissue:1440002516
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14034/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9e553393a968182751f334dff01424fb18c6e38d680ea0bed389331daf1ca632/python/mypy/issues/14034
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e553393a968182751f334dff01424fb18c6e38d680ea0bed389331daf1ca632/python/mypy/issues/14034
og:image:altBug Report Running mypy on the current pydantic codebase (specifically the code as of pydantic/pydantic#4735), give the following run times: running mypy pydantic with mypy 0.982, and no .mypy_cach...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesamuelcolvin
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/14034#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14034
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14034
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/14034
Reloadhttps://github.com/python/mypy/issues/14034
Reloadhttps://github.com/python/mypy/issues/14034
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14034
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14034
#15104https://github.com/python/mypy/pull/15104
mypy 0.990 is 1000x slow on pydantic codebase vs 0.982https://github.com/python/mypy/issues/14034#top
#15104https://github.com/python/mypy/pull/15104
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
topic-recursive-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-recursive-types%22
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issue-1440002516
pydantic/pydantic#4735https://github.com/pydantic/pydantic/pull/4735
this bit of pyproject.tomlhttps://github.com/pydantic/pydantic/blob/aea7016e6cbc7c589713e9ffb7891316d9cde262/pyproject.toml#L155-L187
Nexthttps://github.com/python/mypy/issues/14034?timeline_page=1
samuelcolvinhttps://github.com/samuelcolvin
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Nov 8, 2022https://github.com/python/mypy/issues/14034#event-7761680376
AlexWaygoodhttps://github.com/AlexWaygood
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
on Nov 8, 2022https://github.com/python/mypy/issues/14034#event-7761753013
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307061865
#14027https://github.com/python/mypy/issues/14027
@hauntsaninjahttps://github.com/hauntsaninja
definedhttps://github.com/pydantic/pydantic-core/blob/463ed7aa83b08c43bc699e7e5380026551e38876/pydantic_core/core_schema.py#L1102
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307077730
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307081098
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307090494
AlexWaygoodhttps://github.com/AlexWaygood
topic-recursive-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-recursive-types%22
on Nov 8, 2022https://github.com/python/mypy/issues/14034#event-7762015861
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307101172
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307118266
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307147893
@JukkaLhttps://github.com/JukkaL
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307160247
herehttps://github.com/pydantic/pydantic-core/blob/463ed7aa83b08c43bc699e7e5380026551e38876/src/validators/union.rs#L318-L361
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307162108
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307163745
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Nov 8, 2022https://github.com/python/mypy/issues/14034#issuecomment-1307610622
https://github.com/adriangb
adriangbhttps://github.com/adriangb
on Mar 15, 2023https://github.com/python/mypy/issues/14034#issuecomment-1470252641
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1499844903
https://github.com/adriangb
adriangbhttps://github.com/adriangb
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1499853935
pydantic/pydantic-core#528https://github.com/pydantic/pydantic-core/pull/528
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1499858957
#14034 (comment)https://github.com/python/mypy/issues/14034#issuecomment-1499250007
https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checkshttps://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1500095023
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1500103549
@cdce8phttps://github.com/cdce8p
thishttps://github.com/pydantic/pydantic-core/blob/8a0ecd4eb05de20f8b3910df7be049071442fc35/pydantic_core/core_schema.py#L3286
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1500580946
@cdce8phttps://github.com/cdce8p
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1500581290
https://github.com/adriangb
adriangbhttps://github.com/adriangb
on Apr 7, 2023https://github.com/python/mypy/issues/14034#issuecomment-1500589629
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 21, 2023https://github.com/python/mypy/issues/14034#issuecomment-1517304618
hauntsaninjahttps://github.com/hauntsaninja
on Apr 23, 2023https://github.com/python/mypy/issues/14034#event-9074273038
Fix performance in union subtypinghttps://github.com/hauntsaninja/mypy/commit/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
https://docs.github.com/articles/closing-issues-via-commit-messages
d89b317https://github.com/hauntsaninja/mypy/commit/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#15104https://github.com/python/mypy/pull/15104
on Apr 23, 2023https://github.com/python/mypy/issues/14034#event-9074903412
JukkaLhttps://github.com/JukkaL
on Apr 23, 2023https://github.com/python/mypy/issues/14034#event-9074903454
Fix performance in union subtyping (#15104)https://github.com/python/mypy/commit/bd6ce237f62366f156f4af074e398d761fb41359
#15104https://github.com/python/mypy/pull/15104
https://docs.github.com/articles/closing-issues-via-commit-messages
bd6ce23https://github.com/python/mypy/commit/bd6ce237f62366f156f4af074e398d761fb41359
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Apr 24, 2023https://github.com/python/mypy/issues/14034#issuecomment-1520453596
#14150https://github.com/python/mypy/pull/14150
wesleywrighthttps://github.com/wesleywright
on Apr 24, 2023https://github.com/python/mypy/issues/14034#event-9083606603
Fix performance in union subtyping (#15104)https://github.com/python/mypy/commit/d887e9c0d090694b66b5fa20ac249b3d749a8518
#15104https://github.com/python/mypy/pull/15104
https://docs.github.com/articles/closing-issues-via-commit-messages
d887e9chttps://github.com/python/mypy/commit/d887e9c0d090694b66b5fa20ac249b3d749a8518
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Apr 26, 2023https://github.com/python/mypy/issues/14034#issuecomment-1522785478
#15128https://github.com/python/mypy/pull/15128
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/14034
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/14034
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
topic-recursive-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-recursive-types%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.