René's URL Explorer Experiment


Title: under some conditions mypy thinks a function that always calls sys.exit() returns · Issue #14025 · python/mypy · GitHub

Open Graph Title: under some conditions mypy thinks a function that always calls sys.exit() returns · Issue #14025 · python/mypy

X Title: under some conditions mypy thinks a function that always calls sys.exit() returns · Issue #14025 · python/mypy

Description: Bug Report I managed to make mypy think error in the following has implicit return, changing pretty much anything makes it work correctly: moving definition of the class C before that of error removing the use of field declared in __init...

Open Graph Description: Bug Report I managed to make mypy think error in the following has implicit return, changing pretty much anything makes it work correctly: moving definition of the class C before that of error remo...

X Description: Bug Report I managed to make mypy think error in the following has implicit return, changing pretty much anything makes it work correctly: moving definition of the class C before that of error remo...

Opengraph URL: https://github.com/python/mypy/issues/14025

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"under some conditions mypy thinks a function that always calls sys.exit() returns","articleBody":"\r\n\r\n**Bug Report**\r\n\r\nI managed to make mypy think `error` in the following has implicit return, changing pretty much anything makes it work correctly:\r\n\r\n * moving definition of the class C before that of error\r\n * removing the use of field declared in `__init__`, even if there's other code there\r\n * adding a declaration of `x` within class body\r\n * moving the call to `sys.exit()` before first use of `x`\r\n * throwing an exception instead of calling `sys.exit()`\r\n\r\nAnd I couldn't make similar code fail in any way when the function returns something. Swapping `\"C\"` with `C` doesn't fix anything either of course.\r\n\r\n**To Reproduce**\r\n\r\nCode with (most of) the changes mentioned above commented out:\r\n\r\n```python\r\nimport sys\r\nfrom typing import NoReturn\r\n\r\n\r\n# def error(c: \"C\") -> int:\r\ndef error(c: \"C\") -> NoReturn:\r\n    x = c.x\r\n    # x = 2 + 2\r\n\r\n    sys.exit(1)\r\n    # raise Exception()\r\n    # return x\r\n\r\n\r\nclass C:\r\n    # x: int\r\n\r\n    def __init__(self, x: int):\r\n        self.x = x\r\n```\r\n\r\nTried it after deleting caches and with `--no-incremental` and it still bugs out. (though i definitely didn't bisect all working cases like that)\r\n\r\n**Expected Behavior**\r\n\r\nIt sees that `error` doesn't return, as in all other variants.\r\n\r\n**Actual Behavior**\r\n\r\n\u003c!-- What went wrong? Paste mypy's output. -->\r\n\r\n```\r\nbug.py:6: error: Implicit return in function which does not return\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 0.982\r\n- Mypy command-line flags: with and without --strict, with and without --incremental\r\n- Mypy configuration options from `mypy.ini` (and other config files): none\r\n- Python version used: 3.10.8\r\n\r\n\u003c!-- You can freely edit this text, please remove all the lines you believe are unnecessary. -->\r\n","author":{"url":"https://github.com/phaker","@type":"Person","name":"phaker"},"datePublished":"2022-11-07T17:24:42Z","url":"https://github.com/python/mypy/issues/14025"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:30a9b997-eed4-dc55-e5e3-8c5636866970
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC7C4:390AA2:22E7861:2F8D4F7:6B002A14
html-safe-nonce0057956117fcfed9dda507d76c5c7f404ed1dc7445ef929b911e8c6323ebd42b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0M0OjM5MEFBMjoyMkU3ODYxOjJGOEQ0Rjc6NkIwMDJBMTQiLCJ2aXNpdG9yX2lkIjoiNTU3ODIyMDA3ODkyMDM3ODkwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacae96161705f3c3d8c61fd92a7dbb089c46fb36f41e64f6237c5ecad9cc8180bb
hovercard-subject-tagissue:1438718745
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/14025/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7d2171a185c4bc612a2ad5f49aefc58388f652c0acb7440533d1dc21d0e821f8/python/mypy/issues/14025
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d2171a185c4bc612a2ad5f49aefc58388f652c0acb7440533d1dc21d0e821f8/python/mypy/issues/14025
og:image:altBug Report I managed to make mypy think error in the following has implicit return, changing pretty much anything makes it work correctly: moving definition of the class C before that of error remo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamephaker
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/14025#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14025
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F14025
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/14025
Reloadhttps://github.com/python/mypy/issues/14025
Reloadhttps://github.com/python/mypy/issues/14025
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14025
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/14025
under some conditions mypy thinks a function that always calls sys.exit() returnshttps://github.com/python/mypy/issues/14025#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/phaker
phakerhttps://github.com/phaker
on Nov 7, 2022https://github.com/python/mypy/issues/14025#issue-1438718745
phakerhttps://github.com/phaker
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Nov 7, 2022https://github.com/python/mypy/issues/14025#event-7754809045
https://github.com/phaker
phakerhttps://github.com/phaker
on Nov 8, 2022https://github.com/python/mypy/issues/14025#issuecomment-1307725973
phakerhttps://github.com/phaker
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 8, 2022https://github.com/python/mypy/issues/14025#event-7766100248
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Nov 8, 2022https://github.com/python/mypy/issues/14025#issuecomment-1307744409
#13575https://github.com/python/mypy/pull/13575
https://github.com/phaker
phakerhttps://github.com/phaker
on Nov 9, 2022https://github.com/python/mypy/issues/14025#issuecomment-1308359512
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/14025
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/14025
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.