René's URL Explorer Experiment


Title: Overload fallback for literal booleans allows forbidden literal signatures · Issue #13893 · python/mypy · GitHub

Open Graph Title: Overload fallback for literal booleans allows forbidden literal signatures · Issue #13893 · python/mypy

X Title: Overload fallback for literal booleans allows forbidden literal signatures · Issue #13893 · python/mypy

Description: I am not sure if this is a mypy issue or is a limitation of PEP 586. I want to use boolean literals to forbid a specific combination of function parameter types and boolean flag values. In my example data is AnyStr, but if data_must_be_b...

Open Graph Description: I am not sure if this is a mypy issue or is a limitation of PEP 586. I want to use boolean literals to forbid a specific combination of function parameter types and boolean flag values. In my examp...

X Description: I am not sure if this is a mypy issue or is a limitation of PEP 586. I want to use boolean literals to forbid a specific combination of function parameter types and boolean flag values. In my examp...

Opengraph URL: https://github.com/python/mypy/issues/13893

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Overload fallback for literal booleans allows forbidden literal signatures","articleBody":"I am not sure if this is a mypy issue or is a limitation of PEP 586. I want to use boolean literals to forbid a specific combination of function parameter types and boolean flag values. In my example `data` is `AnyStr`, but if `data_must_be_bytes=True` it must be `bytes`. (In my real use case `data_must_be_bytes` is actually `data_is_image`; and I want to allow either `bytes` for images, or `AnyStr` for non images)\r\n\r\nAs indicated in [PEP 586](https://peps.python.org/pep-0586/#interactions-with-overloads) and [mypy docs](https://mypy.readthedocs.io/en/stable/literal_types.html#literal-types), I need to add a fallback to allow dealing with the original bool type. However, this fallback will also allow the forbidden combination where `data` is `str` and `data_must_be_bytes=True`\r\n\r\nAssuming that the the necessity of the fallback is out of this discussion's scope, I guess I either need a way explicitly state in the fallback that `data_must_be_bytes` is `bool` except `Literal[True]`, or have mypy not do the fallback from `Literal[True]` to `bool` when a narrower overload is given. Without a way to overcome this issue, there seems to be no benefit in using overloading and literals here, over simpler type annotations. It would also be useful to have the docs call out such cases where the added complexity is redundant.  \r\n\r\n```\r\nfrom typing import overload, Literal, AnyStr\r\n\r\n\r\n@overload\r\ndef f(data: bytes, data_must_be_bytes: Literal[True]) -> int: ...\r\n\r\n\r\n# redundant due to following fallback:\r\n#@overload\r\n#def f(data: AnyStr, data_must_be_bytes: Literal[False]) -> int: ...\r\n\r\n\r\n# necessary fallback for non literals:\r\n@overload\r\ndef f(data: AnyStr, data_must_be_bytes: bool) -> int: ...\r\n\r\n\r\ndef f(data, data_must_be_bytes):\r\n    return 0\r\n\r\nf(data='string', data_must_be_bytes=False)\r\nf(data=b'bytes', data_must_be_bytes=False)\r\nf(data='string', data_must_be_bytes=True) # this passes but i want it to fail\r\nf(data=b'bytes', data_must_be_bytes=True)\r\nf(data='string', data_must_be_bytes=bool(0))\r\nf(data=b'bytes', data_must_be_bytes=bool(0))\r\nf(data='string', data_must_be_bytes=bool(1))\r\nf(data=b'bytes', data_must_be_bytes=bool(1))\r\n```\r\n\r\n[mypy-play](https://mypy-play.net/?mypy=0.981&python=3.10&gist=8cb62c8b34a329369db31d7ec524c37c)","author":{"url":"https://github.com/eyaler","@type":"Person","name":"eyaler"},"datePublished":"2022-10-14T11:27:27Z","url":"https://github.com/python/mypy/issues/13893"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8fd8f7f0-efee-3d92-43bd-4ad40bb0d3f1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB27E:59CDA:33476C2:43AA6D3:6B00385B
html-safe-nonce62745e64654b3c675b303c4361f0f624de539459db2fad874378717e42f7389c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjdFOjU5Q0RBOjMzNDc2QzI6NDNBQTZEMzo2QjAwMzg1QiIsInZpc2l0b3JfaWQiOiI1Nzk5MTk2NDg5ODk2OTY2MjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb60d7f799d8020ce470bec06451eb5b0c1e186ee49fed9a2945a127ef3cb4260
hovercard-subject-tagissue:1409204538
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/13893/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3566108b18568f8d7da1b9ce0c0d395a28236fe3cc83f35a1fdddf3f54070744/python/mypy/issues/13893
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3566108b18568f8d7da1b9ce0c0d395a28236fe3cc83f35a1fdddf3f54070744/python/mypy/issues/13893
og:image:altI am not sure if this is a mypy issue or is a limitation of PEP 586. I want to use boolean literals to forbid a specific combination of function parameter types and boolean flag values. In my examp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeyaler
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/13893#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13893
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13893
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/13893
Reloadhttps://github.com/python/mypy/issues/13893
Reloadhttps://github.com/python/mypy/issues/13893
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13893
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13893
Overload fallback for literal booleans allows forbidden literal signatureshttps://github.com/python/mypy/issues/13893#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/eyaler
eyalerhttps://github.com/eyaler
on Oct 14, 2022https://github.com/python/mypy/issues/13893#issue-1409204538
PEP 586https://peps.python.org/pep-0586/#interactions-with-overloads
mypy docshttps://mypy.readthedocs.io/en/stable/literal_types.html#literal-types
mypy-playhttps://mypy-play.net/?mypy=0.981&python=3.10&gist=8cb62c8b34a329369db31d7ec524c37c
eyalerhttps://github.com/eyaler
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 14, 2022https://github.com/python/mypy/issues/13893#event-7589517496
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Oct 16, 2022https://github.com/python/mypy/issues/13893#issuecomment-1280095910
python/typing#1043https://github.com/python/typing/issues/1043
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on Aug 13, 2023https://github.com/python/mypy/issues/13893#issuecomment-1676481170
JelleZijlstrahttps://github.com/JelleZijlstra
not plannedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Aug 13, 2023https://github.com/python/mypy/issues/13893#event-10080734925
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/13893
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/13893
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.