René's URL Explorer Experiment


Title: Inconsistent results after 0.960 -> 0.971 migration · Issue #13422 · python/mypy · GitHub

Open Graph Title: Inconsistent results after 0.960 -> 0.971 migration · Issue #13422 · python/mypy

X Title: Inconsistent results after 0.960 -> 0.971 migration · Issue #13422 · python/mypy

Description: I am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening. For example, our CI fails with: Run mypy --strict mypy_django_plugin mypy_django_plugin/django/context.py:61: error: Unused "type: ignore" ...

Open Graph Description: I am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening. For example, our CI fails with: Run mypy --strict mypy_django_plugin mypy_django_plugin/django/cont...

X Description: I am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening. For example, our CI fails with: Run mypy --strict mypy_django_plugin mypy_django_plugin/django/cont...

Opengraph URL: https://github.com/python/mypy/issues/13422

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistent results after 0.960 -> 0.971 migration","articleBody":"I am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening.\r\n\r\nFor example, our CI fails with:\r\n\r\n```\r\nRun mypy --strict mypy_django_plugin\r\nmypy_django_plugin/django/context.py:61: error: Unused \"type: ignore\" comment\r\nmypy_django_plugin/django/context.py:62: error: Unused \"type: ignore\" comment\r\nmypy_django_plugin/django/context.py:87: error: Untyped decorator makes function \"model_modules\" untyped\r\nmypy_django_plugin/django/context.py:113: error: Returning Any from function declared to return \"Optional[Type[Any]]\"\r\nmypy_django_plugin/django/context.py:233: error: Untyped decorator makes function \"all_registered_model_classes\" untyped\r\nmypy_django_plugin/django/context.py:245: error: Untyped decorator makes function \"all_registered_model_class_fullnames\" untyped\r\nmypy_django_plugin/django/context.py:251: error: Returning Any from function declared to return \"str\"\r\nmypy_django_plugin/django/context.py:255: error: Returning Any from function declared to return \"bool\"\r\nmypy_django_plugin/django/context.py:268: error: Returning Any from function declared to return \"bool\"\r\nmypy_django_plugin/django/context.py:325: error: Unused \"type: ignore\" comment\r\nmypy_django_plugin/django/context.py:335: error: Returning Any from function declared to return \"Optional[Type[Any]]\"\r\n```\r\n\r\nLink: https://github.com/typeddjango/django-stubs/runs/7838309248?check_suite_focus=true\r\n\r\nLocally it works as expected (python and mypy versions do match):\r\n\r\n```\r\n(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                 \r\n» python --version\r\nPython 3.9.9\r\n\r\n(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                    \r\n» mypy --version                  \r\nmypy 0.971 (compiled: yes)\r\n\r\n(.venv) ~/Documents/github/django-stubs  fix-ci ✗                                    \r\n» mypy --strict mypy_django_plugin\r\nSuccess: no issues found in 20 source files\r\n```\r\n\r\nSince we have quite a complex structure, it might be something on our side.\r\nSo, what do we do?\r\n\r\nWe store all stubs for django in `django-stubs` folder.\r\nAt the same level we have `mypy_django_plugin` that does fancy stuff with ORM / etc.\r\nOur plugin imports a lot of things from django itself (settings, `.setup()`, etc). \r\n\r\nHere's the tricky part: 0.960 recognised these imports and their types.\r\nRight now my local setup with 0.971 does the same thing.\r\n\r\nBut, 0.971 in our CI does not see our stubs. So, all types are just `Any`s. This is unexpected!\r\n\r\nLink: https://github.com/typeddjango/django-stubs\r\nOriginal PR: https://github.com/typeddjango/django-stubs/pull/1108","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2022-08-15T13:28:28Z","url":"https://github.com/python/mypy/issues/13422"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5060355f-8591-d553-fde5-99430c8fc061
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD5FA:36D598:C7B08D:10A91F8:6B004E55
html-safe-nonce4c77441d147519af7b5b0dcf4e5c10bfc2293cb6b502dbb3ae42a86a8818a34e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUZBOjM2RDU5ODpDN0IwOEQ6MTBBOTFGODo2QjAwNEU1NSIsInZpc2l0b3JfaWQiOiI2MTEyNDUyMzA0NzQ3NjQ2NTQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a9152fbb27051b2d785cf4bdd1edaa310e41572ee25dfedac9841fffac9ac14
hovercard-subject-tagissue:1339007658
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/13422/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8201b359502c3b21acfcbadbfb8abfe3ff4356d92c88ec455955d6177e2b7163/python/mypy/issues/13422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8201b359502c3b21acfcbadbfb8abfe3ff4356d92c88ec455955d6177e2b7163/python/mypy/issues/13422
og:image:altI am trying to migrate our huge code base from mypy 0.960 to 0.971, but odd things are happening. For example, our CI fails with: Run mypy --strict mypy_django_plugin mypy_django_plugin/django/cont...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/13422#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13422
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13422
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/13422
Reloadhttps://github.com/python/mypy/issues/13422
Reloadhttps://github.com/python/mypy/issues/13422
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13422
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13422
Inconsistent results after 0.960 -> 0.971 migrationhttps://github.com/python/mypy/issues/13422#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issue-1339007658
https://github.com/typeddjango/django-stubs/runs/7838309248?check_suite_focus=truehttps://github.com/typeddjango/django-stubs/runs/7838309248?check_suite_focus=true
https://github.com/typeddjango/django-stubshttps://github.com/typeddjango/django-stubs
typeddjango/django-stubs#1108https://github.com/typeddjango/django-stubs/pull/1108
sobolevnhttps://github.com/sobolevn
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Aug 15, 2022https://github.com/python/mypy/issues/13422#event-7188685908
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issuecomment-1215015885
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issuecomment-1215484653
#11143https://github.com/python/mypy/pull/11143
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issuecomment-1215628334
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issuecomment-1215639518
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 15, 2022https://github.com/python/mypy/issues/13422#issuecomment-1215662275
https://github.com/intgr
intgrhttps://github.com/intgr
on Aug 22, 2022https://github.com/python/mypy/issues/13422#issuecomment-1222437957
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Aug 22, 2022https://github.com/python/mypy/issues/13422#issuecomment-1222446217
pypa/setuptools#3518https://github.com/pypa/setuptools/issues/3518
https://mail.python.org/archives/list/typing-sig@python.org/thread/IIVBPYDZR5T5BGPAWFVYS5ZPYDXGVHQN/#OSWHT5VSRGKPSPYD7PQWR2M4OCSL5WO3https://mail.python.org/archives/list/typing-sig@python.org/thread/IIVBPYDZR5T5BGPAWFVYS5ZPYDXGVHQN/#OSWHT5VSRGKPSPYD7PQWR2M4OCSL5WO3
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on Aug 13, 2023https://github.com/python/mypy/issues/13422#issuecomment-1676427025
hauntsaninjahttps://github.com/hauntsaninja
not plannedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Aug 13, 2023https://github.com/python/mypy/issues/13422#event-10080463109
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/13422
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/13422
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.