Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy · GitHub
Open Graph Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy
X Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy
Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. (I had a search and didn't find a simila...
Open Graph Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. ...
X Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narr...
Opengraph URL: https://github.com/python/mypy/issues/13360
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No type narrowing for `in` on dict.keys()","articleBody":"**Bug Report**\r\n\r\nA an `if` statement like `if x in some_dict.keys()` doesn't narrow the type of `x` to the type of the key of `some_dict`.\r\nThis is in contrast with `if x in some_dict` which does correctly narrow.\r\n\r\n(I had a search and didn't find a similar existing discussion, apologies if this isn't the case)\r\n\r\n**To Reproduce**\r\n\r\nRun `mypy` over the following:\r\n\r\n```python\r\nfrom collections.abc import KeysView\r\n\r\n\r\ndef get_via_keys(key: str | None, data: dict[str, str]) -> str:\r\n if key in data.keys():\r\n # error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\n return key\r\n return \"value\"\r\n\r\n\r\ndef get_via_keys_explicit_typing(key: str | None, data: dict[str, str]) -> str:\r\n keys: KeysView[str] = data.keys()\r\n if key in keys:\r\n # error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\n return key\r\n return \"value\"\r\n\r\n\r\ndef get_check_dict_membership(key: str | None, data: dict[str, str]) -> str:\r\n if key in data:\r\n # OK\r\n return key\r\n return \"value\"\r\n```\r\n\r\n**Expected Behavior**\r\n\r\n`mypy` correctly narrows the type in each of the `if` statements and the script passes.\r\n\r\n**Actual Behavior**\r\n\r\n`mypy` reports failures as:\r\n\r\n```\r\nscript.py:7: error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\nscript.py:15: error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\nFound 2 errors in 1 file (checked 1 source file)\r\n```\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: `0.971` and `mypy 0.980+dev.e69bd9a7270daac8db409e8d08400d9d32367c32 (compiled: no)` (current `master`)\r\n- Mypy command-line flags: `mypy \u003cname-of-file-above>`\r\n- Mypy configuration options from `mypy.ini` (and other config files): the above was run from the root of this project (so whatever's configured there)\r\n- Python version used: `Python 3.10.5`\r\n- Operating system and version: Arch Linux (kernel 5.18.15)\r\n\r\nThe following allows `get_via_keys` above to pass under `mypy`\r\n\r\n```patch\r\ndiff --git a/mypy/checker.py b/mypy/checker.py\r\nindex e64cea7b4..852fe8fab 100644\r\n--- a/mypy/checker.py\r\n+++ b/mypy/checker.py\r\n@@ -6285,6 +6285,7 @@ def builtin_item_type(tp: Type) -> Optional[Type]:\r\n \"builtins.dict\",\r\n \"builtins.set\",\r\n \"builtins.frozenset\",\r\n+ \"_collections_abc.dict_keys\",\r\n ]:\r\n if not tp.args:\r\n # TODO: fix tuple in lib-stub/builtins.pyi (it should be generic).\r\n```\r\n\r\nThough I'm not sure how appropriate it would be given the note in the docs for that function:\r\n\r\n```\r\nNote: this is only OK for built-in containers, where we know the behavior of __contains__.\r\n```\r\n\r\nAlso, `dict_keys` is undocumented and a quick `git grep --word-regexp 'dict_keys'` didn't show much usage for it outside of `typeshed`.","author":{"url":"https://github.com/matthewhughes934","@type":"Person","name":"matthewhughes934"},"datePublished":"2022-08-08T18:47:35Z","url":"https://github.com/python/mypy/issues/13360"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1fa4e467-08d2-1425-0fef-8261bc89d32b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 868A:BACA4:2325594:2DCD0CE:6AFFF064 |
| html-safe-nonce | 76432fb50565a813670cc0f472f0dcef826c77386a5597264677f11a46643364 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjhBOkJBQ0E0OjIzMjU1OTQ6MkRDRDBDRTo2QUZGRjA2NCIsInZpc2l0b3JfaWQiOiIxNDgxODUzNzA3MDY5OTQzOTA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fde39af1bcb009b8eda21b12f0bbadb7385853b3324e039ebb4b4cd5d44927c6 |
| hovercard-subject-tag | issue:1332254933 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/13360/issue_layout |
| twitter:image | https://opengraph.githubassets.com/64619460d36fa7a1135104957503286811f83c1e0a8443748faf1cb3d8cbde87/python/mypy/issues/13360 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/64619460d36fa7a1135104957503286811f83c1e0a8443748faf1cb3d8cbde87/python/mypy/issues/13360 |
| og:image:alt | Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | matthewhughes934 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width