René's URL Explorer Experiment


Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy · GitHub

Open Graph Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy

X Title: No type narrowing for `in` on dict.keys() · Issue #13360 · python/mypy

Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. (I had a search and didn't find a simila...

Open Graph Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. ...

X Description: Bug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narr...

Opengraph URL: https://github.com/python/mypy/issues/13360

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No type narrowing for `in` on dict.keys()","articleBody":"**Bug Report**\r\n\r\nA an `if` statement like `if x in some_dict.keys()` doesn't narrow the type of `x` to the type of the key of `some_dict`.\r\nThis is in contrast with `if x in some_dict` which does correctly narrow.\r\n\r\n(I had a search and didn't find a similar existing discussion, apologies if this isn't the case)\r\n\r\n**To Reproduce**\r\n\r\nRun `mypy` over the following:\r\n\r\n```python\r\nfrom collections.abc import KeysView\r\n\r\n\r\ndef get_via_keys(key: str | None, data: dict[str, str]) -> str:\r\n    if key in data.keys():\r\n        # error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\n        return key\r\n    return \"value\"\r\n\r\n\r\ndef get_via_keys_explicit_typing(key: str | None, data: dict[str, str]) -> str:\r\n    keys: KeysView[str] = data.keys()\r\n    if key in keys:\r\n        # error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\n        return key\r\n    return \"value\"\r\n\r\n\r\ndef get_check_dict_membership(key: str | None, data: dict[str, str]) -> str:\r\n    if key in data:\r\n        # OK\r\n        return key\r\n    return \"value\"\r\n```\r\n\r\n**Expected Behavior**\r\n\r\n`mypy` correctly narrows the type in each of the `if` statements and the script passes.\r\n\r\n**Actual Behavior**\r\n\r\n`mypy` reports failures as:\r\n\r\n```\r\nscript.py:7: error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\nscript.py:15: error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\nFound 2 errors in 1 file (checked 1 source file)\r\n```\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: `0.971` and `mypy 0.980+dev.e69bd9a7270daac8db409e8d08400d9d32367c32 (compiled: no)` (current  `master`)\r\n- Mypy command-line flags: `mypy \u003cname-of-file-above>`\r\n- Mypy configuration options from `mypy.ini` (and other config files): the above was run from the root of this project (so whatever's configured there)\r\n- Python version used: `Python 3.10.5`\r\n- Operating system and version: Arch Linux (kernel 5.18.15)\r\n\r\nThe following allows `get_via_keys` above to pass under `mypy`\r\n\r\n```patch\r\ndiff --git a/mypy/checker.py b/mypy/checker.py\r\nindex e64cea7b4..852fe8fab 100644\r\n--- a/mypy/checker.py\r\n+++ b/mypy/checker.py\r\n@@ -6285,6 +6285,7 @@ def builtin_item_type(tp: Type) -> Optional[Type]:\r\n             \"builtins.dict\",\r\n             \"builtins.set\",\r\n             \"builtins.frozenset\",\r\n+            \"_collections_abc.dict_keys\",\r\n         ]:\r\n             if not tp.args:\r\n                 # TODO: fix tuple in lib-stub/builtins.pyi (it should be generic).\r\n```\r\n\r\nThough I'm not sure how appropriate it would be given the note in the docs for that function:\r\n\r\n```\r\nNote: this is only OK for built-in containers, where we know the behavior of __contains__.\r\n```\r\n\r\nAlso, `dict_keys` is undocumented and a quick `git grep --word-regexp 'dict_keys'` didn't show much usage for it outside of `typeshed`.","author":{"url":"https://github.com/matthewhughes934","@type":"Person","name":"matthewhughes934"},"datePublished":"2022-08-08T18:47:35Z","url":"https://github.com/python/mypy/issues/13360"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1fa4e467-08d2-1425-0fef-8261bc89d32b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id868A:BACA4:2325594:2DCD0CE:6AFFF064
html-safe-nonce76432fb50565a813670cc0f472f0dcef826c77386a5597264677f11a46643364
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjhBOkJBQ0E0OjIzMjU1OTQ6MkRDRDBDRTo2QUZGRjA2NCIsInZpc2l0b3JfaWQiOiIxNDgxODUzNzA3MDY5OTQzOTA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfde39af1bcb009b8eda21b12f0bbadb7385853b3324e039ebb4b4cd5d44927c6
hovercard-subject-tagissue:1332254933
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/13360/issue_layout
twitter:imagehttps://opengraph.githubassets.com/64619460d36fa7a1135104957503286811f83c1e0a8443748faf1cb3d8cbde87/python/mypy/issues/13360
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/64619460d36fa7a1135104957503286811f83c1e0a8443748faf1cb3d8cbde87/python/mypy/issues/13360
og:image:altBug Report A an if statement like if x in some_dict.keys() doesn't narrow the type of x to the type of the key of some_dict. This is in contrast with if x in some_dict which does correctly narrow. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematthewhughes934
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/13360#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13360
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F13360
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/13360
Reloadhttps://github.com/python/mypy/issues/13360
Reloadhttps://github.com/python/mypy/issues/13360
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13360
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/13360
No type narrowing for in on dict.keys()https://github.com/python/mypy/issues/13360#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/matthewhughes934
matthewhughes934https://github.com/matthewhughes934
on Aug 8, 2022https://github.com/python/mypy/issues/13360#issue-1332254933
matthewhughes934https://github.com/matthewhughes934
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Aug 8, 2022https://github.com/python/mypy/issues/13360#event-7149485803
matthewhughes934https://github.com/matthewhughes934
on Aug 8, 2022https://github.com/python/mypy/issues/13360#event-7149888066
matthewhughes934https://github.com/matthewhughes934
on Aug 8, 2022https://github.com/python/mypy/issues/13360#event-7149888652
matthewhughes934https://github.com/matthewhughes934
on Aug 8, 2022https://github.com/python/mypy/issues/13360#event-7149889405
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Aug 9, 2022https://github.com/python/mypy/issues/13360#issuecomment-1209112881
AlexWaygoodhttps://github.com/AlexWaygood
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Aug 9, 2022https://github.com/python/mypy/issues/13360#event-7153688859
matthewhughes934https://github.com/matthewhughes934
on Aug 9, 2022https://github.com/python/mypy/issues/13360#event-7158263687
Add type inference for `dict.keys` membershiphttps://github.com/matthewhughes934/mypy/commit/903b0c8519cb702a88a6fbf7137107ecc0b384d1
903b0c8https://github.com/matthewhughes934/mypy/commit/903b0c8519cb702a88a6fbf7137107ecc0b384d1
Add type inference for `dict.keys` membershiphttps://github.com/matthewhughes934/mypy/commit/01efd355ac37bd7a1c86fd9f9b55fab46798f23c
01efd35https://github.com/matthewhughes934/mypy/commit/01efd355ac37bd7a1c86fd9f9b55fab46798f23c
Add type inference for `dict.keys` membershiphttps://github.com/matthewhughes934/mypy/commit/75ca813a0428a8db2be7c356535e123fb5da4bac
75ca813https://github.com/matthewhughes934/mypy/commit/75ca813a0428a8db2be7c356535e123fb5da4bac
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
507fc5chttps://github.com/python/mypy/commit/507fc5cf256bd4d1749a6109ef45c8462dd82185
on Oct 27, 2022https://github.com/python/mypy/issues/13360#event-7684830465
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/13360
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/13360
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.