René's URL Explorer Experiment


Title: Error If Return Annotation Is Provided (Generics + TypeVar + isinstance) · Issue #12873 · python/mypy · GitHub

Open Graph Title: Error If Return Annotation Is Provided (Generics + TypeVar + isinstance) · Issue #12873 · python/mypy

X Title: Error If Return Annotation Is Provided (Generics + TypeVar + isinstance) · Issue #12873 · python/mypy

Description: I get this strange error whereby adding a return annotation causes mypy to fail to identify the code after the "isinstance" block. Mypy gives an error on the last line of ErrorIfReturnIsAnnotated.foo() while it doesn't give any errors fo...

Open Graph Description: I get this strange error whereby adding a return annotation causes mypy to fail to identify the code after the "isinstance" block. Mypy gives an error on the last line of ErrorIfReturnIsAnnotated.f...

X Description: I get this strange error whereby adding a return annotation causes mypy to fail to identify the code after the "isinstance" block. Mypy gives an error on the last line of ErrorIfReturnIsA...

Opengraph URL: https://github.com/python/mypy/issues/12873

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Error If Return Annotation Is Provided (Generics + TypeVar + isinstance)","articleBody":"I get this strange error whereby adding a return annotation causes mypy to fail to identify the code after the \"isinstance\" block.\r\nMypy gives an error on the last line of ErrorIfReturnIsAnnotated.foo() while it doesn't give any errors for WorksIfNoReturnAnnotation.foo()\r\n\r\nThe only difference in those two classes are that one of them declares an explicit None return annotation.\r\n\r\nEnvironment\r\n- Mypy version used: 0.950 and 0.960\r\n- Mypy command-line flags: None\r\n- Mypy configuration options from `mypy.ini` (and other config files): None\r\n- Python version used: Python 3.10.4\r\n- Operating system and version: Windows 10 (Version 21H2)\r\n\r\nFull simplified test code to reproduce the bug\r\n\r\n```\r\nfrom abc import ABCMeta\r\nfrom typing import Generic, TypeVar, Union\r\n\r\n\r\nclass BaseEngine(metaclass=ABCMeta):\r\n    pass\r\n\r\n\r\nclass BaseEngineVariantA(BaseEngine):\r\n    pass\r\n\r\n\r\nclass BaseEngineVariantB(BaseEngine):\r\n    pass\r\n\r\n\r\nclass VariantAConcreteEngine(BaseEngineVariantA):\r\n    pass\r\n\r\n\r\nT = TypeVar('T', bound=Union[BaseEngineVariantA, BaseEngineVariantB])\r\n\r\n\r\nclass IBase(Generic[T], metaclass=ABCMeta):\r\n    def __init__(self, engine: T):\r\n        self.engine = engine\r\n\r\n\r\nclass IAction(IBase[T], metaclass=ABCMeta):\r\n    pass\r\n\r\n\r\nclass ErrorIfReturnIsAnnotated(IBase[T]):\r\n    def __init__(self, something: T, actions_injected: type[IAction[T]]) -> None:\r\n        self.something = something\r\n        self.actions_injected = actions_injected\r\n\r\n    def foo(self) -> None:\r\n        if not isinstance(self.something, VariantAConcreteEngine):\r\n            raise Exception(\"HI\")\r\n\r\n        self.actions_injected(self.something)  # Gives a mypy error of - error: Argument 1 to \"IAction\" has incompatible type \"VariantAConcreteEngine\"; expected \"T\"\r\n\r\n\r\nclass WorksIfNoReturnAnnotation(IBase[T]):\r\n    def __init__(self, something: T, actions_injected: type[IAction[T]]) -> None:\r\n        self.something = something\r\n        self.actions_injected = actions_injected\r\n\r\n    def foo(self):\r\n        if not isinstance(self.something, VariantAConcreteEngine):\r\n            raise Exception(\"HI\")\r\n\r\n        self.actions_injected(self.something)  # No errors\r\n\r\n```","author":{"url":"https://github.com/julzt0244","@type":"Person","name":"julzt0244"},"datePublished":"2022-05-26T13:59:05Z","url":"https://github.com/python/mypy/issues/12873"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:22527953-0327-7252-ba91-ef3bd60f314c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD528:308C72:6B86F:94E51:6B005136
html-safe-nonce61457279203bea2586204d09dca8d79a46f81d647c681d31b4ca4e89acf5e980
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTI4OjMwOEM3Mjo2Qjg2Rjo5NEU1MTo2QjAwNTEzNiIsInZpc2l0b3JfaWQiOiI1NTA3NjQ5NzM3NTY3Nzg1MjcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4cac91af69af9975b656f452a7cd172c182f6eabb38225454734e9e03d6be2a5
hovercard-subject-tagissue:1249610591
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12873/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5b0dc22b0838060b288c1f1916ab1cbcaccfd4df42aab2152820acb9d5f80c58/python/mypy/issues/12873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b0dc22b0838060b288c1f1916ab1cbcaccfd4df42aab2152820acb9d5f80c58/python/mypy/issues/12873
og:image:altI get this strange error whereby adding a return annotation causes mypy to fail to identify the code after the "isinstance" block. Mypy gives an error on the last line of ErrorIfReturnIsAnnotated.f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejulzt0244
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/12873#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12873
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12873
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/12873
Reloadhttps://github.com/python/mypy/issues/12873
Reloadhttps://github.com/python/mypy/issues/12873
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12873
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12873
Error If Return Annotation Is Provided (Generics + TypeVar + isinstance)https://github.com/python/mypy/issues/12873#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/julzt0244
julzt0244https://github.com/julzt0244
on May 26, 2022https://github.com/python/mypy/issues/12873#issue-1249610591
julzt0244https://github.com/julzt0244
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 26, 2022https://github.com/python/mypy/issues/12873#event-6685873369
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on May 26, 2022https://github.com/python/mypy/issues/12873#issuecomment-1138616292
https://mypy.readthedocs.io/en/stable/common_issues.html#no-errors-reported-for-obviously-wrong-codehttps://mypy.readthedocs.io/en/stable/common_issues.html#no-errors-reported-for-obviously-wrong-code
JelleZijlstrahttps://github.com/JelleZijlstra
not plannedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on May 26, 2022https://github.com/python/mypy/issues/12873#event-6685927569
https://github.com/julzt0244
julzt0244https://github.com/julzt0244
on May 26, 2022https://github.com/python/mypy/issues/12873#issuecomment-1138622363
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on May 26, 2022https://github.com/python/mypy/issues/12873#issuecomment-1138623320
https://github.com/julzt0244
julzt0244https://github.com/julzt0244
on May 26, 2022https://github.com/python/mypy/issues/12873#issuecomment-1138625667
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/12873
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/12873
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.