René's URL Explorer Experiment


Title: Avoid type checking dependencies when errors aren't reported · Issue #12854 · python/mypy · GitHub

Open Graph Title: Avoid type checking dependencies when errors aren't reported · Issue #12854 · python/mypy

X Title: Avoid type checking dependencies when errors aren't reported · Issue #12854 · python/mypy

Description: Feature When we're type checking code that we aren't going to report errors for (like any code in site-packages), we can improve performance by avoiding doing most of the work of type checking. Pitch I tried type checking mypy with an un...

Open Graph Description: Feature When we're type checking code that we aren't going to report errors for (like any code in site-packages), we can improve performance by avoiding doing most of the work of type checking. Pit...

X Description: Feature When we're type checking code that we aren't going to report errors for (like any code in site-packages), we can improve performance by avoiding doing most of the work of type check...

Opengraph URL: https://github.com/python/mypy/issues/12854

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Avoid type checking dependencies when errors aren't reported","articleBody":"**Feature**\r\n\r\nWhen we're type checking code that we aren't going to report errors for (like any code in site-packages), we can improve performance by avoiding doing most of the work of type checking.\r\n\r\n**Pitch**\r\n\r\nI tried type checking mypy with an uncompiled mypy from master (19e9f2136fd46c662f1066a4894edf48173942f4) itself using this command:\r\n```\r\nmypy mypy mypyc --config-file mypy_self_check.ini --no-incremental --timing-stats timing_data.txt\r\n```\r\n\r\nThe results I got using the per-file timing stats were that of the approximately 63.6 seconds spent type checking, 44.3 seconds were spent type checking modules in mypy or mypyc, and the remaining 19.3 seconds were spent in other modules.\r\n\r\nWhile 19.3 seconds isn't a majority of the build time, it is still a not insignificant amount of time spent type checking dependencies, even though that work will mostly get thrown away since we don't report errors in any of those dependencies.\r\n\r\nThere are probably a couple things we can skip doing for code that doesn't have errors reported:\r\n1. Avoid semantic analysis and type checking inside functions, since that shouldn't affect what other modules see.\r\n2. Skip particularly expensive checks at module level when type checking (we can't really completely skip type checking because we probably still need to run type inference on that code, and I think we group those together).\r\n3. Avoid loading modules that are never used directly in the code being checked (currently we sometimes analyze modules that are imported directly or indirectly by another dependency module that is directly used in checked code).","author":{"url":"https://github.com/pranavrajpal","@type":"Person","name":"pranavrajpal"},"datePublished":"2022-05-23T01:59:32Z","url":"https://github.com/python/mypy/issues/12854"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4d0ddf78-22a0-da65-473b-1a7946152ca8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9F8E:1756E4:195E9FD:217885E:6B002D58
html-safe-nonceeb1af8f633e3b9299c91985cce929910b22b4a60d964018c4ca4bef5cca81c8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjhFOjE3NTZFNDoxOTVFOUZEOjIxNzg4NUU6NkIwMDJENTgiLCJ2aXNpdG9yX2lkIjoiMzAyNDQwNDI4OTYwMzc3NTgzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfdaa505a16353fb69bb2f356f728dc35f0ecff94418c849d1844a0c94361645c
hovercard-subject-tagissue:1244471041
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12854/issue_layout
twitter:imagehttps://opengraph.githubassets.com/54c9967000d85344cd2b4a033e2a5c1ffad7296416b399769acc20dfc7b4cf4d/python/mypy/issues/12854
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/54c9967000d85344cd2b4a033e2a5c1ffad7296416b399769acc20dfc7b4cf4d/python/mypy/issues/12854
og:image:altFeature When we're type checking code that we aren't going to report errors for (like any code in site-packages), we can improve performance by avoiding doing most of the work of type checking. Pit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepranavrajpal
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/12854#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12854
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12854
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/12854
Reloadhttps://github.com/python/mypy/issues/12854
Reloadhttps://github.com/python/mypy/issues/12854
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12854
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12854
Avoid type checking dependencies when errors aren't reportedhttps://github.com/python/mypy/issues/12854#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com/pranavrajpal
pranavrajpalhttps://github.com/pranavrajpal
on May 23, 2022https://github.com/python/mypy/issues/12854#issue-1244471041
19e9f21https://github.com/python/mypy/commit/19e9f2136fd46c662f1066a4894edf48173942f4
pranavrajpalhttps://github.com/pranavrajpal
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on May 23, 2022https://github.com/python/mypy/issues/12854#event-6657151978
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on May 23, 2022https://github.com/python/mypy/issues/12854#issuecomment-1134133811
#10922https://github.com/python/mypy/pull/10922
AlexWaygoodhttps://github.com/AlexWaygood
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
on May 23, 2022https://github.com/python/mypy/issues/12854#event-6661932789
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 13, 2023https://github.com/python/mypy/issues/12854#issuecomment-1676471799
#14150https://github.com/python/mypy/pull/14150
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/12854
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/12854
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.