René's URL Explorer Experiment


Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy · GitHub

Open Graph Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy

X Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy

Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads to a type error from typing import NewTyp...

Open Graph Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads t...

X Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually lea...

Opengraph URL: https://github.com/python/mypy/issues/12824

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Invalid handling type narrowing with inf/float due to duck typing","articleBody":"**Bug Report**\r\n\r\nDue to [duck typing](https://mypy.readthedocs.io/en/stable/duck_type_compatibility.html#duck-type-compatibility) handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly.\r\n\r\n\r\n**To Reproduce**\r\nConsider this code, that actually leads to a type error\r\n\r\n```python\r\nfrom typing import NewType\r\n\r\nEuro = NewType(\"Euro\", float)\r\n\r\ndef to_eur(user_in: int | float | str) -> Euro:\r\n    reveal_type(user_in) # int | float | str as expected\r\n    if isinstance(user_in, float):\r\n        reveal_type(user_in) # float\r\n        return Euro(user_in)\r\n    reveal_type(user_in) # str, but expected str | int\r\n    converted = float(user_in.rstrip(\"€\"))\r\n    return Euro(converted)\r\n    \r\n\r\nprint(to_eur(10))  # Raises type error as int has no method rstrip\r\n```\r\n\r\n**Expected Behavior**\r\nI would expect that MyPy would warn me and that the expected reveal_type after the the isinstance call is `int | float`\r\nThis should be even the case, if `int` is not explicitly given.\r\n\r\nConsider the modification of above:\r\n\r\n```python\r\nfrom typing import NewType\r\n\r\nEuro = NewType(\"Euro\", float)\r\n\r\ndef to_eur(user_in: float | str) -> Euro:\r\n    reveal_type(user_in) # float | str as expected\r\n    if isinstance(user_in, float):\r\n        reveal_type(user_in) # float\r\n        return Euro(user_in)\r\n    reveal_type(user_in) # str\r\n    converted = float(user_in.rstrip(\"€\"))\r\n    return Euro(converted)\r\n    \r\n\r\nprint(to_eur(10))   # Raises type error as int has no method rstrip\r\n```\r\nwould still raise a runtime type error and no typing error at all.\r\n\r\nAlso handling all duck types explicitly as unions when type narrowing would probably handle the non reachable bugs described in\r\n#12643.\r\nThis is also suggested in #11516\r\n\r\n**Actual Behavior**\r\nNo error / warning raised by MyPy\r\n\r\n\r\n**Your Environment**\r\n\r\nSee [MyPy Playground](https://mypy-play.net/?mypy=latest&python=3.10&flags=strict%2Cstrict-equality%2Cwarn-incomplete-stub%2Cwarn-redundant-casts%2Cwarn-return-any%2Cwarn-unreachable%2Cwarn-unused-configs%2Cwarn-unused-ignores&gist=d92c6b0d410e37de179fb11d1a342337)\r\n\r\n\r\n- Mypy version used: 0.950\r\n- Mypy command-line flags: no\r\n- Python version used: 3.10\r\n- Operating system and version: Fedora/Online\r\n\r\n\r\nMaybe related issues:\r\nhttps://github.com/python/mypy/issues/11511\r\n\r\n","author":{"url":"https://github.com/CarliJoy","@type":"Person","name":"CarliJoy"},"datePublished":"2022-05-20T08:30:13Z","url":"https://github.com/python/mypy/issues/12824"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:96cab265-f749-5598-0a80-d03cb0c6b159
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBA4A:1C3DC0:460A5C:5E1807:6B002CBA
html-safe-nonce2e53deb15bf42844e582c42b68f2dbbef9047f67ee1b56488686224fc702b09a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTRBOjFDM0RDMDo0NjBBNUM6NUUxODA3OjZCMDAyQ0JBIiwidmlzaXRvcl9pZCI6IjgxMDY2MjMzODg1NjAxNDE0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc351349380194ee9154f18d3ca5f3aa32718783d4e6cd5696deaf88b8817be50
hovercard-subject-tagissue:1242813669
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12824/issue_layout
twitter:imagehttps://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/12824
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/12824
og:image:altBug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCarliJoy
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/12824#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12824
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12824
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/12824
Reloadhttps://github.com/python/mypy/issues/12824
Reloadhttps://github.com/python/mypy/issues/12824
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12824
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12824
#13781https://github.com/python/mypy/pull/13781
Invalid handling type narrowing with inf/float due to duck typinghttps://github.com/python/mypy/issues/12824#top
#13781https://github.com/python/mypy/pull/13781
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/CarliJoy
CarliJoyhttps://github.com/CarliJoy
on May 20, 2022https://github.com/python/mypy/issues/12824#issue-1242813669
duck typinghttps://mypy.readthedocs.io/en/stable/duck_type_compatibility.html#duck-type-compatibility
#12643https://github.com/python/mypy/issues/12643
#11516https://github.com/python/mypy/issues/11516
MyPy Playgroundhttps://mypy-play.net/?mypy=latest&python=3.10&flags=strict%2Cstrict-equality%2Cwarn-incomplete-stub%2Cwarn-redundant-casts%2Cwarn-return-any%2Cwarn-unreachable%2Cwarn-unused-configs%2Cwarn-unused-ignores&gist=d92c6b0d410e37de179fb11d1a342337
#11511https://github.com/python/mypy/issues/11511
CarliJoyhttps://github.com/CarliJoy
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 20, 2022https://github.com/python/mypy/issues/12824#event-6648714178
AlexWaygoodhttps://github.com/AlexWaygood
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on May 20, 2022https://github.com/python/mypy/issues/12824#event-6648735914
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
on May 20, 2022https://github.com/python/mypy/issues/12824#issuecomment-1132745375
PEP 484https://peps.python.org/pep-0484/#the-numeric-tower
#3186https://github.com/python/mypy/issues/3186
emmatypinghttps://github.com/emmatyping
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 20, 2022https://github.com/python/mypy/issues/12824#event-6649556379
https://github.com/CarliJoy
CarliJoyhttps://github.com/CarliJoy
on May 20, 2022https://github.com/python/mypy/issues/12824#issuecomment-1132758709
PEP 484https://peps.python.org/pep-0484/#the-numeric-tower
#3186https://github.com/python/mypy/issues/3186
@ethanhshttps://github.com/ethanhs
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
on May 20, 2022https://github.com/python/mypy/issues/12824#issuecomment-1132777242
emmatypinghttps://github.com/emmatyping
on May 20, 2022https://github.com/python/mypy/issues/12824#event-6649823188
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on May 20, 2022https://github.com/python/mypy/issues/12824#issuecomment-1133059640
@ethanhshttps://github.com/ethanhs
numeric towerhttps://peps.python.org/pep-0484/#the-numeric-tower
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#13781https://github.com/python/mypy/pull/13781
on Oct 3, 2022https://github.com/python/mypy/issues/12824#event-7506522440
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 3, 2022https://github.com/python/mypy/issues/12824#event-7506522855
Ignore promotions when simplifying unions (#13781)https://github.com/python/mypy/commit/08c566cfa8a3e9cbf0bbad1db3cdcdff7d1ad2f2
#13781https://github.com/python/mypy/pull/13781
https://docs.github.com/articles/closing-issues-via-commit-messages
08c566chttps://github.com/python/mypy/commit/08c566cfa8a3e9cbf0bbad1db3cdcdff7d1ad2f2
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/12824
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/12824
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.