Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy · GitHub
Open Graph Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy
X Title: Invalid handling type narrowing with inf/float due to duck typing · Issue #12824 · python/mypy
Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads to a type error from typing import NewTyp...
Open Graph Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads t...
X Description: Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually lea...
Opengraph URL: https://github.com/python/mypy/issues/12824
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Invalid handling type narrowing with inf/float due to duck typing","articleBody":"**Bug Report**\r\n\r\nDue to [duck typing](https://mypy.readthedocs.io/en/stable/duck_type_compatibility.html#duck-type-compatibility) handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly.\r\n\r\n\r\n**To Reproduce**\r\nConsider this code, that actually leads to a type error\r\n\r\n```python\r\nfrom typing import NewType\r\n\r\nEuro = NewType(\"Euro\", float)\r\n\r\ndef to_eur(user_in: int | float | str) -> Euro:\r\n reveal_type(user_in) # int | float | str as expected\r\n if isinstance(user_in, float):\r\n reveal_type(user_in) # float\r\n return Euro(user_in)\r\n reveal_type(user_in) # str, but expected str | int\r\n converted = float(user_in.rstrip(\"€\"))\r\n return Euro(converted)\r\n \r\n\r\nprint(to_eur(10)) # Raises type error as int has no method rstrip\r\n```\r\n\r\n**Expected Behavior**\r\nI would expect that MyPy would warn me and that the expected reveal_type after the the isinstance call is `int | float`\r\nThis should be even the case, if `int` is not explicitly given.\r\n\r\nConsider the modification of above:\r\n\r\n```python\r\nfrom typing import NewType\r\n\r\nEuro = NewType(\"Euro\", float)\r\n\r\ndef to_eur(user_in: float | str) -> Euro:\r\n reveal_type(user_in) # float | str as expected\r\n if isinstance(user_in, float):\r\n reveal_type(user_in) # float\r\n return Euro(user_in)\r\n reveal_type(user_in) # str\r\n converted = float(user_in.rstrip(\"€\"))\r\n return Euro(converted)\r\n \r\n\r\nprint(to_eur(10)) # Raises type error as int has no method rstrip\r\n```\r\nwould still raise a runtime type error and no typing error at all.\r\n\r\nAlso handling all duck types explicitly as unions when type narrowing would probably handle the non reachable bugs described in\r\n#12643.\r\nThis is also suggested in #11516\r\n\r\n**Actual Behavior**\r\nNo error / warning raised by MyPy\r\n\r\n\r\n**Your Environment**\r\n\r\nSee [MyPy Playground](https://mypy-play.net/?mypy=latest&python=3.10&flags=strict%2Cstrict-equality%2Cwarn-incomplete-stub%2Cwarn-redundant-casts%2Cwarn-return-any%2Cwarn-unreachable%2Cwarn-unused-configs%2Cwarn-unused-ignores&gist=d92c6b0d410e37de179fb11d1a342337)\r\n\r\n\r\n- Mypy version used: 0.950\r\n- Mypy command-line flags: no\r\n- Python version used: 3.10\r\n- Operating system and version: Fedora/Online\r\n\r\n\r\nMaybe related issues:\r\nhttps://github.com/python/mypy/issues/11511\r\n\r\n","author":{"url":"https://github.com/CarliJoy","@type":"Person","name":"CarliJoy"},"datePublished":"2022-05-20T08:30:13Z","url":"https://github.com/python/mypy/issues/12824"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:96cab265-f749-5598-0a80-d03cb0c6b159 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BA4A:1C3DC0:460A5C:5E1807:6B002CBA |
| html-safe-nonce | 2e53deb15bf42844e582c42b68f2dbbef9047f67ee1b56488686224fc702b09a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTRBOjFDM0RDMDo0NjBBNUM6NUUxODA3OjZCMDAyQ0JBIiwidmlzaXRvcl9pZCI6IjgxMDY2MjMzODg1NjAxNDE0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c351349380194ee9154f18d3ca5f3aa32718783d4e6cd5696deaf88b8817be50 |
| hovercard-subject-tag | issue:1242813669 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12824/issue_layout |
| twitter:image | https://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/12824 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/12824 |
| og:image:alt | Bug Report Due to duck typing handling type narrowing within a function accepting both int and float (even explicitly) doesn't work correctly. To Reproduce Consider this code, that actually leads t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | CarliJoy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width