René's URL Explorer Experiment


Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy · GitHub

Open Graph Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy

X Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy

Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy runs without issues: main.py:1: error: Ca...

Open Graph Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r...

X Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r...

Opengraph URL: https://github.com/python/mypy/issues/12257

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash when deserialising ParamSpec in ClassDef","articleBody":"\u003c!--\r\n  If you're new to mypy and you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form\r\n  instead.\r\n  Please also consider:\r\n\r\n  - checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\r\n  - searching our issue tracker: https://github.com/python/mypy/issues to see if\r\n    it's already been reported\r\n  - asking on gitter chat: https://gitter.im/python/typing\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nNote: If the problem you are reporting is about a specific library function, then the typeshed tracker is better suited\r\nfor this report: https://github.com/python/typeshed/issues\r\n-->\r\n\r\nMypy crashes with `AssertionError` after running it for the second time with `namespace-packages` option enabled. Looks like some typevar is improperly serialized in cache.\r\nFirst time mypy runs without issues:\r\n```\r\nmain.py:1: error: Cannot find implementation or library stub for module named \"humanize\"\r\nmain.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\nSecond time it crashes:\r\nTraceback from dev version:\r\n```py\r\nTraceback (most recent call last):\r\n  File \"/home/eugene/mypy_test/.venv/bin/mypy\", line 8, in \u003cmodule>\r\n    sys.exit(console_entry())\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/__main__.py\", line 12, in console_entry\r\n    main(None, sys.stdout, sys.stderr)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/main.py\", line 96, in main\r\n    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/main.py\", line 173, in run_build\r\n    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 180, in build\r\n    result = _build(\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 256, in _build\r\n    graph = dispatch(sources, manager, stdout)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 2727, in dispatch\r\n    process_graph(graph, manager)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 3064, in process_graph\r\n    process_fresh_modules(graph, prev_scc, manager)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 3139, in process_fresh_modules\r\n    graph[id].load_tree()\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 1995, in load_tree\r\n    self.tree = MypyFile.deserialize(data)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 356, in deserialize\r\n    tree.names = SymbolTable.deserialize(data['names'])\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 3373, in deserialize\r\n    st[key] = SymbolTableNode.deserialize(value)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 3314, in deserialize\r\n    node = SymbolNode.deserialize(data['node'])\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 248, in deserialize\r\n    return method(data)\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 2849, in deserialize\r\n    defn = ClassDef.deserialize(data['defn'])\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 1036, in deserialize\r\n    [mypy.types.TypeVarType.deserialize(v) for v in data['type_vars']],\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 1036, in \u003clistcomp>\r\n    [mypy.types.TypeVarType.deserialize(v) for v in data['type_vars']],\r\n  File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/types.py\", line 524, in deserialize\r\n    assert data['.class'] == 'TypeVarType'\r\nAssertionError\r\n```\r\n\r\nI added `print(data)` above the assert check, here's a few last lines before crash, last line causes it:\r\n```python\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.CogT', 'id': 1, 'name': 'CogT', 'upper_bound': 'discord.ext.commands.cog.Cog', 'values': [], 'variance': 0}\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.T', 'id': 3, 'name': 'T', 'upper_bound': 'builtins.object', 'values': [], 'variance': 0}\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.CogT', 'id': 1, 'name': 'CogT', 'upper_bound': 'discord.ext.commands.cog.Cog', 'values': [], 'variance': 0}\r\n{'.class': 'ParamSpecType', 'flavor': 0, 'fullname': 'discord.ext.commands.core.P', 'id': 2, 'name': 'P', 'upper_bound': 'builtins.object'}\r\nTraceback (most recent call last):\r\n...\r\n```\r\nSo mypy doesn't like P typevar, it is defined here: https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/ext/commands/core.py#L111\r\n~~Note that this is `typing_extensions.ParamSpec`, not `typing.ParamSpec`.~~ patching library to use `typing.ParamSpec` produced same crash.\r\n\r\nI am unsure what exactly causes error, so I can't produce a smaller example of this crash. I will try to narrow it down in further comments.\r\n\r\n**To Reproduce**\r\n\r\n0. create and activate venv\r\n1. install mypy\r\n2. `pip install discord.py @ git+https://github.com/Rapptz/discord.py@45d498c1b76deaf3b394d17ccf56112fa691d160`\r\n3. `mypy main.py --namespace-packages`\r\n4. `mypy main.py --namespace-packages` (run it again)\r\n\r\n`main.py`\r\n```py\r\n# does not matter if it is installed or no, but assertion error does not happen if this import is not there for some reason\r\nimport humanize\r\n\r\nfrom discord.ext import commands\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nmypy to not crash.\r\n\r\n**Actual Behavior**\r\n\r\nmypy crashes with AssertionError.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: both `0.931` and latest master `0.940+dev.feca706d5f2540003ae8b24009d56dac7c067eba`\r\n- Mypy command-line flags: `--namespace-packages`\r\n- Mypy configuration options from `mypy.ini` (and other config files):\r\n- Python version used: `3.8.12` / `3.10.2`\r\n- Operating system and version: Arch Linux\r\n- `pip freeze` (new venv, after installing problematic package): \r\n```\r\naiohttp==3.7.4.post0\r\nasync-timeout==3.0.1\r\nattrs==21.4.0\r\nchardet==4.0.0\r\ndiscord.py==2.0.0a3575+g45d498c1\r\nidna==3.3\r\nmultidict==6.0.2\r\nmypy @ git+https://github.com/python/mypy.git@feca706d5f2540003ae8b24009d56dac7c067eba\r\nmypy-extensions==0.4.3\r\ntomli==2.0.1\r\ntyping-extensions==4.1.1\r\nyarl==1.7.2\r\n```","author":{"url":"https://github.com/Fogapod","@type":"Person","name":"Fogapod"},"datePublished":"2022-02-27T10:02:32Z","url":"https://github.com/python/mypy/issues/12257"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:edc325af-599c-706f-15ae-ec02fdfba1aa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEAD2:D33AC:5E16D7:7E57E1:6B0033FD
html-safe-noncedf8f6bb82df036fe0ad85e9b04bf7dbae5f3764b7a2264e5321c38cc20c09883
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUQyOkQzM0FDOjVFMTZENzo3RTU3RTE6NkIwMDMzRkQiLCJ2aXNpdG9yX2lkIjoiNjA1Mjk3NjkyNDc3NzUyNjI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb73aed721ebf0eead46640acf23c2c1e046c20626fdd19cbfce4644ad7f1fbff
hovercard-subject-tagissue:1153136879
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12257/issue_layout
twitter:imagehttps://opengraph.githubassets.com/562230e11720661050d584dabc9b9992a33c8fa19c23345f11089a614ec47e9d/python/mypy/issues/12257
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/562230e11720661050d584dabc9b9992a33c8fa19c23345f11089a614ec47e9d/python/mypy/issues/12257
og:image:altBug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFogapod
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/12257#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12257
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12257
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/12257
Reloadhttps://github.com/python/mypy/issues/12257
Reloadhttps://github.com/python/mypy/issues/12257
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12257
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12257
#11847https://github.com/python/mypy/pull/11847
Crash when deserialising ParamSpec in ClassDefhttps://github.com/python/mypy/issues/12257#top
#11847https://github.com/python/mypy/pull/11847
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
topic-paramspecPEP 612, ParamSpec, Concatenatehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-paramspec%22
https://github.com/Fogapod
Fogapodhttps://github.com/Fogapod
on Feb 27, 2022https://github.com/python/mypy/issues/12257#issue-1153136879
https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/ext/commands/core.py#L111https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/ext/commands/core.py#L111
Fogapodhttps://github.com/Fogapod
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Feb 27, 2022https://github.com/python/mypy/issues/12257#event-6149886852
JelleZijlstrahttps://github.com/JelleZijlstra
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
on Feb 27, 2022https://github.com/python/mypy/issues/12257#event-6150454490
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Feb 27, 2022https://github.com/python/mypy/issues/12257#issuecomment-1053704295
mypy/mypy/nodes.pyhttps://github.com/python/mypy/blob/14de8c6f1f24648299528881561ddcd52172701d/mypy/nodes.py#L1036
14de8c6https://github.com/python/mypy/commit/14de8c6f1f24648299528881561ddcd52172701d
hauntsaninjahttps://github.com/hauntsaninja
on Feb 27, 2022https://github.com/python/mypy/issues/12257#event-6151044097
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Mar 1, 2022https://github.com/python/mypy/issues/12257#issuecomment-1054919423
#11847https://github.com/python/mypy/pull/11847
https://github.com/Fogapod
Fogapodhttps://github.com/Fogapod
on Mar 6, 2022https://github.com/python/mypy/issues/12257#issuecomment-1059951137
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
on Mar 6, 2022https://github.com/python/mypy/issues/12257#issuecomment-1059952876
@Fogapodhttps://github.com/Fogapod
#11847https://github.com/python/mypy/pull/11847
https://github.com/python/mypy/pull/11847/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68R1036-R1038https://github.com/python/mypy/pull/11847/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68R1036-R1038
https://github.com/Fogapod
Fogapodhttps://github.com/Fogapod
on Mar 6, 2022https://github.com/python/mypy/issues/12257#issuecomment-1059954724
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
on Mar 6, 2022https://github.com/python/mypy/issues/12257#issuecomment-1059955290
#11847https://github.com/python/mypy/pull/11847
AlexWaygoodhttps://github.com/AlexWaygood
topic-paramspecPEP 612, ParamSpec, Concatenatehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-paramspec%22
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Mar 24, 2022https://github.com/python/mypy/issues/12257#event-6299491046
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11847https://github.com/python/mypy/pull/11847
on Apr 7, 2022https://github.com/python/mypy/issues/12257#event-6386990362
JukkaLhttps://github.com/JukkaL
on Apr 7, 2022https://github.com/python/mypy/issues/12257#event-6386991098
Basic ParamSpec Concatenate and literal support (#11847)https://github.com/python/mypy/commit/07d88787774fabbd3108d18621b30df9b42e7c83
#11847https://github.com/python/mypy/pull/11847
https://docs.github.com/articles/closing-issues-via-commit-messages
07d8878https://github.com/python/mypy/commit/07d88787774fabbd3108d18621b30df9b42e7c83
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/12257
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/12257
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
topic-paramspecPEP 612, ParamSpec, Concatenatehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-paramspec%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.