Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy · GitHub
Open Graph Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy
X Title: Crash when deserialising ParamSpec in ClassDef · Issue #12257 · python/mypy
Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy runs without issues: main.py:1: error: Ca...
Open Graph Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r...
X Description: Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r...
Opengraph URL: https://github.com/python/mypy/issues/12257
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash when deserialising ParamSpec in ClassDef","articleBody":"\u003c!--\r\n If you're new to mypy and you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form\r\n instead.\r\n Please also consider:\r\n\r\n - checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html\r\n - searching our issue tracker: https://github.com/python/mypy/issues to see if\r\n it's already been reported\r\n - asking on gitter chat: https://gitter.im/python/typing\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nNote: If the problem you are reporting is about a specific library function, then the typeshed tracker is better suited\r\nfor this report: https://github.com/python/typeshed/issues\r\n-->\r\n\r\nMypy crashes with `AssertionError` after running it for the second time with `namespace-packages` option enabled. Looks like some typevar is improperly serialized in cache.\r\nFirst time mypy runs without issues:\r\n```\r\nmain.py:1: error: Cannot find implementation or library stub for module named \"humanize\"\r\nmain.py:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\nSecond time it crashes:\r\nTraceback from dev version:\r\n```py\r\nTraceback (most recent call last):\r\n File \"/home/eugene/mypy_test/.venv/bin/mypy\", line 8, in \u003cmodule>\r\n sys.exit(console_entry())\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/__main__.py\", line 12, in console_entry\r\n main(None, sys.stdout, sys.stderr)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/main.py\", line 96, in main\r\n res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/main.py\", line 173, in run_build\r\n res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 180, in build\r\n result = _build(\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 256, in _build\r\n graph = dispatch(sources, manager, stdout)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 2727, in dispatch\r\n process_graph(graph, manager)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 3064, in process_graph\r\n process_fresh_modules(graph, prev_scc, manager)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 3139, in process_fresh_modules\r\n graph[id].load_tree()\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/build.py\", line 1995, in load_tree\r\n self.tree = MypyFile.deserialize(data)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 356, in deserialize\r\n tree.names = SymbolTable.deserialize(data['names'])\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 3373, in deserialize\r\n st[key] = SymbolTableNode.deserialize(value)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 3314, in deserialize\r\n node = SymbolNode.deserialize(data['node'])\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 248, in deserialize\r\n return method(data)\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 2849, in deserialize\r\n defn = ClassDef.deserialize(data['defn'])\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 1036, in deserialize\r\n [mypy.types.TypeVarType.deserialize(v) for v in data['type_vars']],\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/nodes.py\", line 1036, in \u003clistcomp>\r\n [mypy.types.TypeVarType.deserialize(v) for v in data['type_vars']],\r\n File \"/home/eugene/mypy_test/.venv/lib/python3.8/site-packages/mypy/types.py\", line 524, in deserialize\r\n assert data['.class'] == 'TypeVarType'\r\nAssertionError\r\n```\r\n\r\nI added `print(data)` above the assert check, here's a few last lines before crash, last line causes it:\r\n```python\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.CogT', 'id': 1, 'name': 'CogT', 'upper_bound': 'discord.ext.commands.cog.Cog', 'values': [], 'variance': 0}\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.T', 'id': 3, 'name': 'T', 'upper_bound': 'builtins.object', 'values': [], 'variance': 0}\r\n{'.class': 'TypeVarType', 'fullname': 'discord.ext.commands.core.CogT', 'id': 1, 'name': 'CogT', 'upper_bound': 'discord.ext.commands.cog.Cog', 'values': [], 'variance': 0}\r\n{'.class': 'ParamSpecType', 'flavor': 0, 'fullname': 'discord.ext.commands.core.P', 'id': 2, 'name': 'P', 'upper_bound': 'builtins.object'}\r\nTraceback (most recent call last):\r\n...\r\n```\r\nSo mypy doesn't like P typevar, it is defined here: https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/ext/commands/core.py#L111\r\n~~Note that this is `typing_extensions.ParamSpec`, not `typing.ParamSpec`.~~ patching library to use `typing.ParamSpec` produced same crash.\r\n\r\nI am unsure what exactly causes error, so I can't produce a smaller example of this crash. I will try to narrow it down in further comments.\r\n\r\n**To Reproduce**\r\n\r\n0. create and activate venv\r\n1. install mypy\r\n2. `pip install discord.py @ git+https://github.com/Rapptz/discord.py@45d498c1b76deaf3b394d17ccf56112fa691d160`\r\n3. `mypy main.py --namespace-packages`\r\n4. `mypy main.py --namespace-packages` (run it again)\r\n\r\n`main.py`\r\n```py\r\n# does not matter if it is installed or no, but assertion error does not happen if this import is not there for some reason\r\nimport humanize\r\n\r\nfrom discord.ext import commands\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nmypy to not crash.\r\n\r\n**Actual Behavior**\r\n\r\nmypy crashes with AssertionError.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: both `0.931` and latest master `0.940+dev.feca706d5f2540003ae8b24009d56dac7c067eba`\r\n- Mypy command-line flags: `--namespace-packages`\r\n- Mypy configuration options from `mypy.ini` (and other config files):\r\n- Python version used: `3.8.12` / `3.10.2`\r\n- Operating system and version: Arch Linux\r\n- `pip freeze` (new venv, after installing problematic package): \r\n```\r\naiohttp==3.7.4.post0\r\nasync-timeout==3.0.1\r\nattrs==21.4.0\r\nchardet==4.0.0\r\ndiscord.py==2.0.0a3575+g45d498c1\r\nidna==3.3\r\nmultidict==6.0.2\r\nmypy @ git+https://github.com/python/mypy.git@feca706d5f2540003ae8b24009d56dac7c067eba\r\nmypy-extensions==0.4.3\r\ntomli==2.0.1\r\ntyping-extensions==4.1.1\r\nyarl==1.7.2\r\n```","author":{"url":"https://github.com/Fogapod","@type":"Person","name":"Fogapod"},"datePublished":"2022-02-27T10:02:32Z","url":"https://github.com/python/mypy/issues/12257"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:edc325af-599c-706f-15ae-ec02fdfba1aa |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EAD2:D33AC:5E16D7:7E57E1:6B0033FD |
| html-safe-nonce | df8f6bb82df036fe0ad85e9b04bf7dbae5f3764b7a2264e5321c38cc20c09883 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUQyOkQzM0FDOjVFMTZENzo3RTU3RTE6NkIwMDMzRkQiLCJ2aXNpdG9yX2lkIjoiNjA1Mjk3NjkyNDc3NzUyNjI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b73aed721ebf0eead46640acf23c2c1e046c20626fdd19cbfce4644ad7f1fbff |
| hovercard-subject-tag | issue:1153136879 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12257/issue_layout |
| twitter:image | https://opengraph.githubassets.com/562230e11720661050d584dabc9b9992a33c8fa19c23345f11089a614ec47e9d/python/mypy/issues/12257 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/562230e11720661050d584dabc9b9992a33c8fa19c23345f11089a614ec47e9d/python/mypy/issues/12257 |
| og:image:alt | Bug Report Mypy crashes with AssertionError after running it for the second time with namespace-packages option enabled. Looks like some typevar is improperly serialized in cache. First time mypy r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fogapod |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width