René's URL Explorer Experiment


Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy · GitHub

Open Graph Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy

X Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy

Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On running stubgen for this extension, the gener...

Open Graph Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On runni...

X Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On r...

Opengraph URL: https://github.com/python/mypy/issues/12150

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Stubgen bug] Fix behavior for Instance Variables in C extensions","articleBody":"Stubgen generates wrong stubs for instance variables defined in C extensions.\r\n\r\nIn the attached `extension.C`, I've created a class named _Custom_ which has 3 instance variables: _var1_,_var2_,_var3_. On running stubgen for this extension, the generated .pyi file contains: \r\n\r\n```\r\nfrom typing import Any, ClassVar\r\n\r\nclass Custom:\r\n    // This is wrong. Var{1,2,3} are not Class Variables but are rather instance variables.\r\n    var1: ClassVar[getset_descriptor] = ...\r\n    var2: ClassVar[getset_descriptor] = ...\r\n    var3: ClassVar[member_descriptor] = ...   \r\n    // This is wrong. \r\n\r\n    def display(self, *args, **kwargs) -> Any: ...\r\n```\r\n\r\n**Detailed Reproducer:**\r\n 1. In some test directory (say $DIR), download the attached file _extension.zip_ to extension folder.\r\n 3. Compile the extension by running: `g++ -fPIC -std=c++11 -I. -I/opt/python/python-3.9/include/python3.9 -Iextension -c extension/extension.C -o extension.o` in directory $DIR.\r\n 4. Create the .so file by running: `g++ -shared  -L/opt/python/python-3.9/lib64 -Wl,-R/opt/python/python-3.9/lib64 extension.o -o extension.so` in directory $DIR.\r\n 5. Run stubgen using `env PYTHONPATH=$DIR stubgen -m extension`\r\n 6. Notice that the generated $DIR/out/extension.pyi declares var{1,2,3} as 'Class Variables' which is wrong.\r\n\r\nOn digging into this, I found this is due to a wrong check in `stubgenc.py#is_c_property`.\r\n```\r\ndef is_c_property(obj: object) -> bool:\r\n    return inspect.isdatadescriptor(obj) and hasattr(obj, 'fget')\r\n```\r\nThe check should contain \"or\" (instead of \"and\") since the instance variables in case of C extension doesn't have the \"fget\" attribute but `inspect.isdatadescription` return True.\r\nOn making this change locally, stubgen runs fine. \r\n\r\nIf this looks good to you, I can raise a PR for the same.\r\n\r\n[extension.zip](https://github.com/python/mypy/files/8023192/extension.zip)","author":{"url":"https://github.com/shubz1998","@type":"Person","name":"shubz1998"},"datePublished":"2022-02-08T11:08:26Z","url":"https://github.com/python/mypy/issues/12150"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3a38d52d-8de4-a7c4-39be-34ca3525560a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id815C:24366C:27B027:3787AD:6B006A66
html-safe-nonce03e8d28ce886c92f285590660c1e0b39517ea2f2bad2d167d620522736f858e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTVDOjI0MzY2QzoyN0IwMjc6Mzc4N0FEOjZCMDA2QTY2IiwidmlzaXRvcl9pZCI6Ijc3MjY3MjYzMDI3OTg5OTgxMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7691214cc9bcb823e4470fa4ce9037b2257ff4e43e6dc69fc5a4ab0658986346
hovercard-subject-tagissue:1127109194
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12150/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b8a9dc94deb4d67460507a205f2c710d835f4ad0e0291798260d4eb08ba02836/python/mypy/issues/12150
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b8a9dc94deb4d67460507a205f2c710d835f4ad0e0291798260d4eb08ba02836/python/mypy/issues/12150
og:image:altStubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On runni...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshubz1998
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/12150#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12150
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F12150
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/12150
Reloadhttps://github.com/python/mypy/issues/12150
Reloadhttps://github.com/python/mypy/issues/12150
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12150
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/12150
#12524https://github.com/python/mypy/pull/12524
[Stubgen bug] Fix behavior for Instance Variables in C extensionshttps://github.com/python/mypy/issues/12150#top
#12524https://github.com/python/mypy/pull/12524
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
https://github.com/shubz1998
shubz1998https://github.com/shubz1998
on Feb 8, 2022https://github.com/python/mypy/issues/12150#issue-1127109194
extension.ziphttps://github.com/python/mypy/files/8023192/extension.zip
https://github.com/shubz1998
shubz1998https://github.com/shubz1998
on Feb 15, 2022https://github.com/python/mypy/issues/12150#issuecomment-1039944104
hauntsaninjahttps://github.com/hauntsaninja
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
on Feb 15, 2022https://github.com/python/mypy/issues/12150#event-6073626967
https://github.com/shubz1998
shubz1998https://github.com/shubz1998
on Mar 15, 2022https://github.com/python/mypy/issues/12150#issuecomment-1068045210
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Mar 15, 2022https://github.com/python/mypy/issues/12150#issuecomment-1068351092
shubz1998https://github.com/shubz1998
on Apr 5, 2022https://github.com/python/mypy/issues/12150#event-6369150208
Fix stubgen's is_c_property checkhttps://github.com/shubz1998/mypy/commit/e45a7cda6d3102fe47a4f7fa42425be88d323e63
https://docs.github.com/articles/closing-issues-via-commit-messages
e45a7cdhttps://github.com/shubz1998/mypy/commit/e45a7cda6d3102fe47a4f7fa42425be88d323e63
Fix stubgenhttps://github.com/shubz1998/mypy/commit/db4be747df432ee499e06713e374a8e47a9844dd
https://docs.github.com/articles/closing-issues-via-commit-messages
db4be74https://github.com/shubz1998/mypy/commit/db4be747df432ee499e06713e374a8e47a9844dd
Fix Stubgen's behavior for Instance Variables in C extensionshttps://github.com/shubz1998/mypy/commit/cc739fb583e272788953484828103b36996d7b96
https://docs.github.com/articles/closing-issues-via-commit-messages
cc739fbhttps://github.com/shubz1998/mypy/commit/cc739fb583e272788953484828103b36996d7b96
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12524https://github.com/python/mypy/pull/12524
on Apr 11, 2022https://github.com/python/mypy/issues/12150#event-6410223252
JelleZijlstrahttps://github.com/JelleZijlstra
on Apr 11, 2022https://github.com/python/mypy/issues/12150#event-6410224226
Fix Stubgen's behavior for Instance Variables in C extensions (#12524)https://github.com/python/mypy/commit/74df7fb1172993af3b2456765fb8368481ef0ab9
#12524https://github.com/python/mypy/pull/12524
https://docs.github.com/articles/closing-issues-via-commit-messages
74df7fbhttps://github.com/python/mypy/commit/74df7fb1172993af3b2456765fb8368481ef0ab9
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/12150
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/12150
topic-stubgenhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-stubgen%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.