Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy · GitHub
Open Graph Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy
X Title: [Stubgen bug] Fix behavior for Instance Variables in C extensions · Issue #12150 · python/mypy
Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On running stubgen for this extension, the gener...
Open Graph Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On runni...
X Description: Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On r...
Opengraph URL: https://github.com/python/mypy/issues/12150
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Stubgen bug] Fix behavior for Instance Variables in C extensions","articleBody":"Stubgen generates wrong stubs for instance variables defined in C extensions.\r\n\r\nIn the attached `extension.C`, I've created a class named _Custom_ which has 3 instance variables: _var1_,_var2_,_var3_. On running stubgen for this extension, the generated .pyi file contains: \r\n\r\n```\r\nfrom typing import Any, ClassVar\r\n\r\nclass Custom:\r\n // This is wrong. Var{1,2,3} are not Class Variables but are rather instance variables.\r\n var1: ClassVar[getset_descriptor] = ...\r\n var2: ClassVar[getset_descriptor] = ...\r\n var3: ClassVar[member_descriptor] = ... \r\n // This is wrong. \r\n\r\n def display(self, *args, **kwargs) -> Any: ...\r\n```\r\n\r\n**Detailed Reproducer:**\r\n 1. In some test directory (say $DIR), download the attached file _extension.zip_ to extension folder.\r\n 3. Compile the extension by running: `g++ -fPIC -std=c++11 -I. -I/opt/python/python-3.9/include/python3.9 -Iextension -c extension/extension.C -o extension.o` in directory $DIR.\r\n 4. Create the .so file by running: `g++ -shared -L/opt/python/python-3.9/lib64 -Wl,-R/opt/python/python-3.9/lib64 extension.o -o extension.so` in directory $DIR.\r\n 5. Run stubgen using `env PYTHONPATH=$DIR stubgen -m extension`\r\n 6. Notice that the generated $DIR/out/extension.pyi declares var{1,2,3} as 'Class Variables' which is wrong.\r\n\r\nOn digging into this, I found this is due to a wrong check in `stubgenc.py#is_c_property`.\r\n```\r\ndef is_c_property(obj: object) -> bool:\r\n return inspect.isdatadescriptor(obj) and hasattr(obj, 'fget')\r\n```\r\nThe check should contain \"or\" (instead of \"and\") since the instance variables in case of C extension doesn't have the \"fget\" attribute but `inspect.isdatadescription` return True.\r\nOn making this change locally, stubgen runs fine. \r\n\r\nIf this looks good to you, I can raise a PR for the same.\r\n\r\n[extension.zip](https://github.com/python/mypy/files/8023192/extension.zip)","author":{"url":"https://github.com/shubz1998","@type":"Person","name":"shubz1998"},"datePublished":"2022-02-08T11:08:26Z","url":"https://github.com/python/mypy/issues/12150"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3a38d52d-8de4-a7c4-39be-34ca3525560a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 815C:24366C:27B027:3787AD:6B006A66 |
| html-safe-nonce | 03e8d28ce886c92f285590660c1e0b39517ea2f2bad2d167d620522736f858e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTVDOjI0MzY2QzoyN0IwMjc6Mzc4N0FEOjZCMDA2QTY2IiwidmlzaXRvcl9pZCI6Ijc3MjY3MjYzMDI3OTg5OTgxMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7691214cc9bcb823e4470fa4ce9037b2257ff4e43e6dc69fc5a4ab0658986346 |
| hovercard-subject-tag | issue:1127109194 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/12150/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b8a9dc94deb4d67460507a205f2c710d835f4ad0e0291798260d4eb08ba02836/python/mypy/issues/12150 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b8a9dc94deb4d67460507a205f2c710d835f4ad0e0291798260d4eb08ba02836/python/mypy/issues/12150 |
| og:image:alt | Stubgen generates wrong stubs for instance variables defined in C extensions. In the attached extension.C, I've created a class named Custom which has 3 instance variables: var1,var2,var3. On runni... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shubz1998 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width