Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy · GitHub
Open Graph Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy
X Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy
Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg) # Revealed type is "builtins.int" elif ...
Open Graph Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg)...
X Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg,...
Opengraph URL: https://github.com/python/mypy/issues/11995
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing fails when narrowing Optional NewType","articleBody":"**Bug Report**\r\n\r\n```python3\r\nfrom typing import Union, NewType\r\n\r\nInt = NewType(\"Int\", int)\r\nFloat = NewType(\"Float\", float)\r\n\r\ndef raw_types(arg: Union[int, float, None]) -> None:\r\n if isinstance(arg, int):\r\n reveal_type(arg) # Revealed type is \"builtins.int\"\r\n elif isinstance(arg, float):\r\n reveal_type(arg) # Revealed type is \"builtins.float\"\r\n else:\r\n reveal_type(arg) # Revealed type is \"None\"\r\n\r\ndef new_types(arg: Union[Int, Float, None]) -> None:\r\n if isinstance(arg, int):\r\n reveal_type(arg) # Revealed type is \"__main__.Int\"\r\n elif isinstance(arg, float):\r\n reveal_type(arg) # Revealed type is \"Union[__main__.Int, __main__.Float]\" (NARROWING FAILED)\r\n else:\r\n reveal_type(arg) # Revealed type is \"None\"\r\n\r\ndef new_types_not_optional(arg: Union[Int, Float]) -> None:\r\n if isinstance(arg, int):\r\n reveal_type(arg) # Revealed type is \"__main__.Int\"\r\n elif isinstance(arg, float):\r\n reveal_type(arg) # Revealed type is \"__main__.Float\"\r\n else:\r\n reveal_type(arg)\r\n```\r\n\r\nThe bug is fairly straightforward. When narrowing a `Union` of `NewType` types with `isinstance`, the narrowing fails if one of the possible types of the variable is `None`.\r\n\r\n**To Reproduce**\r\n\r\nhttps://mypy-play.net/?mypy=0.931&python=3.10&gist=557b54a098f8ed366fa62ff380ec12c8\r\n\r\n**Expected Behavior**\r\n\r\nAll revealed types after `isinstance(arg, float)` would be `builtins.float` or `__main__.Float`.\r\n\r\n**Actual Behavior**\r\n\r\nThe revealed type in the buggy case is still `Union[__main__.Int, __main__.Float]`.\r\n","author":{"url":"https://github.com/bbatliner","@type":"Person","name":"bbatliner"},"datePublished":"2022-01-14T17:40:38Z","url":"https://github.com/python/mypy/issues/11995"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:58b5a70c-caf6-3833-ce70-8db22dd499c0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AFA2:4E648:71F16:9F21A:6B004EBD |
| html-safe-nonce | 0ed279b6cbfb83bdd12f2d5b11d32117765818e179e97441937b515cd9a0b795 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkEyOjRFNjQ4OjcxRjE2OjlGMjFBOjZCMDA0RUJEIiwidmlzaXRvcl9pZCI6IjQ1NTM5MzAwMjMwMzUyMjc4MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 46453d99aae4a226899abad1f7bef121bb5dd06bcb68d414bdca38b9a8a4c840 |
| hovercard-subject-tag | issue:1103949801 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/11995/issue_layout |
| twitter:image | https://opengraph.githubassets.com/865c5aeb9c0e451ac0c1c27dc1cb26a1bf78df578eeb6672ff0c179385b468e3/python/mypy/issues/11995 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/865c5aeb9c0e451ac0c1c27dc1cb26a1bf78df578eeb6672ff0c179385b468e3/python/mypy/issues/11995 |
| og:image:alt | Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg)... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bbatliner |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width