René's URL Explorer Experiment


Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy · GitHub

Open Graph Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy

X Title: Type narrowing fails when narrowing Optional NewType · Issue #11995 · python/mypy

Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg) # Revealed type is "builtins.int" elif ...

Open Graph Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg)...

X Description: Bug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg,...

Opengraph URL: https://github.com/python/mypy/issues/11995

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing fails when narrowing Optional NewType","articleBody":"**Bug Report**\r\n\r\n```python3\r\nfrom typing import Union, NewType\r\n\r\nInt = NewType(\"Int\", int)\r\nFloat = NewType(\"Float\", float)\r\n\r\ndef raw_types(arg: Union[int, float, None]) -> None:\r\n    if isinstance(arg, int):\r\n        reveal_type(arg)  # Revealed type is \"builtins.int\"\r\n    elif isinstance(arg, float):\r\n        reveal_type(arg)  # Revealed type is \"builtins.float\"\r\n    else:\r\n        reveal_type(arg)  # Revealed type is \"None\"\r\n\r\ndef new_types(arg: Union[Int, Float, None]) -> None:\r\n    if isinstance(arg, int):\r\n        reveal_type(arg)  # Revealed type is \"__main__.Int\"\r\n    elif isinstance(arg, float):\r\n        reveal_type(arg)  # Revealed type is \"Union[__main__.Int, __main__.Float]\" (NARROWING FAILED)\r\n    else:\r\n        reveal_type(arg)  # Revealed type is \"None\"\r\n\r\ndef new_types_not_optional(arg: Union[Int, Float]) -> None:\r\n    if isinstance(arg, int):\r\n        reveal_type(arg)  # Revealed type is \"__main__.Int\"\r\n    elif isinstance(arg, float):\r\n        reveal_type(arg)  # Revealed type is \"__main__.Float\"\r\n    else:\r\n        reveal_type(arg)\r\n```\r\n\r\nThe bug is fairly straightforward. When narrowing a `Union` of `NewType` types with `isinstance`, the narrowing fails if one of the possible types of the variable is `None`.\r\n\r\n**To Reproduce**\r\n\r\nhttps://mypy-play.net/?mypy=0.931&python=3.10&gist=557b54a098f8ed366fa62ff380ec12c8\r\n\r\n**Expected Behavior**\r\n\r\nAll revealed types after `isinstance(arg, float)` would be `builtins.float` or `__main__.Float`.\r\n\r\n**Actual Behavior**\r\n\r\nThe revealed type in the buggy case is still `Union[__main__.Int, __main__.Float]`.\r\n","author":{"url":"https://github.com/bbatliner","@type":"Person","name":"bbatliner"},"datePublished":"2022-01-14T17:40:38Z","url":"https://github.com/python/mypy/issues/11995"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:58b5a70c-caf6-3833-ce70-8db22dd499c0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAFA2:4E648:71F16:9F21A:6B004EBD
html-safe-nonce0ed279b6cbfb83bdd12f2d5b11d32117765818e179e97441937b515cd9a0b795
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkEyOjRFNjQ4OjcxRjE2OjlGMjFBOjZCMDA0RUJEIiwidmlzaXRvcl9pZCI6IjQ1NTM5MzAwMjMwMzUyMjc4MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac46453d99aae4a226899abad1f7bef121bb5dd06bcb68d414bdca38b9a8a4c840
hovercard-subject-tagissue:1103949801
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/11995/issue_layout
twitter:imagehttps://opengraph.githubassets.com/865c5aeb9c0e451ac0c1c27dc1cb26a1bf78df578eeb6672ff0c179385b468e3/python/mypy/issues/11995
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/865c5aeb9c0e451ac0c1c27dc1cb26a1bf78df578eeb6672ff0c179385b468e3/python/mypy/issues/11995
og:image:altBug Report from typing import Union, NewType Int = NewType("Int", int) Float = NewType("Float", float) def raw_types(arg: Union[int, float, None]) -> None: if isinstance(arg, int): reveal_type(arg)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebbatliner
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/11995#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11995
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11995
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/11995
Reloadhttps://github.com/python/mypy/issues/11995
Reloadhttps://github.com/python/mypy/issues/11995
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11995
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11995
Type narrowing fails when narrowing Optional NewTypehttps://github.com/python/mypy/issues/11995#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/bbatliner
bbatlinerhttps://github.com/bbatliner
on Jan 14, 2022https://github.com/python/mypy/issues/11995#issue-1103949801
https://mypy-play.net/?mypy=0.931&python=3.10&gist=557b54a098f8ed366fa62ff380ec12c8https://mypy-play.net/?mypy=0.931&python=3.10&gist=557b54a098f8ed366fa62ff380ec12c8
bbatlinerhttps://github.com/bbatliner
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Jan 14, 2022https://github.com/python/mypy/issues/11995#event-5896311105
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jan 15, 2022https://github.com/python/mypy/issues/11995#issuecomment-1013716480
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jan 15, 2022https://github.com/python/mypy/issues/11995#issuecomment-1013720076
mypy/mypy/meet.pyhttps://github.com/python/mypy/blob/17850b3bd77ae9efb5d21f656c4e4e05ac48d894/mypy/meet.py#L530
17850b3https://github.com/python/mypy/commit/17850b3bd77ae9efb5d21f656c4e4e05ac48d894
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jan 15, 2022https://github.com/python/mypy/issues/11995#issuecomment-1013728248
JelleZijlstrahttps://github.com/JelleZijlstra
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Mar 19, 2022https://github.com/python/mypy/issues/11995#event-6270126703
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on Aug 12, 2023https://github.com/python/mypy/issues/11995#issuecomment-1676146010
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 13, 2023https://github.com/python/mypy/issues/11995#issuecomment-1676192821
#13781https://github.com/python/mypy/pull/13781
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 13, 2023https://github.com/python/mypy/issues/11995#event-10078747323
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/11995
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/11995
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.