René's URL Explorer Experiment


Title: Coding style suggestion about nesting constructs · Issue #1184 · python/mypy · GitHub

Open Graph Title: Coding style suggestion about nesting constructs · Issue #1184 · python/mypy

X Title: Coding style suggestion about nesting constructs · Issue #1184 · python/mypy

Description: There are a lot of different patterns in the mypy codebase where some stack is maintained by a pair of functions that push something onto the stack (or bump a counter or something) and pop it off again. So you'll see code like this: self...

Open Graph Description: There are a lot of different patterns in the mypy codebase where some stack is maintained by a pair of functions that push something onto the stack (or bump a counter or something) and pop it off a...

X Description: There are a lot of different patterns in the mypy codebase where some stack is maintained by a pair of functions that push something onto the stack (or bump a counter or something) and pop it off a...

Opengraph URL: https://github.com/python/mypy/issues/1184

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Coding style suggestion about nesting constructs","articleBody":"There are a lot of different patterns in the mypy codebase where some stack is maintained by a pair of functions that push something onto the stack (or bump a counter or something) and pop it off again. So you'll see code like this:\n\n``` python\n            self.msg.disable_errors()\n            arg_types = self.infer_arg_types_in_context(None, args)\n            self.msg.enable_errors()\n```\n\nI wonder if this pattern couldn't be made clearer in the code by using context managers. In this case, we would write e.g.\n\n``` python\n            with self.msg.disable_errors():\n                arg_types = self.infer_arg_types_in_context(None, args)\n```\n\nThe implementation would be very simple:\n\n``` python\n@contextmanager\ndef disable_errors(self) -> None:\n    self.disable_count += 1\n    yield\n    self.disable_count -= 1\n```\n\n(I'm picking on this example because it came up recently, but there are a lot of function pairs like this; e.g. check_func_item() (https://github.com/JukkaL/mypy/blob/master/mypy/checker.py#L542) has four different stacks it manipulates.)\n","author":{"url":"https://github.com/gvanrossum","@type":"Person","name":"gvanrossum"},"datePublished":"2016-01-28T18:02:00Z","url":"https://github.com/python/mypy/issues/1184"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0fe5449a-0d5a-0a71-263d-9a9f386883f9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE154:22FAD4:ADE6F:E9E37:6B001C4B
html-safe-nonce5fffb95a10f64b126e88b60bd402c8b5154501a79ea87d6aabe88e0fba47296d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTU0OjIyRkFENDpBREU2RjpFOUUzNzo2QjAwMUM0QiIsInZpc2l0b3JfaWQiOiI0NTg2NjYzNjE1Mzk4NjEyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf176b9a39b2af4c5f2c4d27910b279e04987ce714b02cb6185fc51b699a6418a
hovercard-subject-tagissue:129527577
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/1184/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4ee87503ec6bbe93db3229b04b4db1a4a7be27171d021b8630c3509c575edeec/python/mypy/issues/1184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4ee87503ec6bbe93db3229b04b4db1a4a7be27171d021b8630c3509c575edeec/python/mypy/issues/1184
og:image:altThere are a lot of different patterns in the mypy codebase where some stack is maintained by a pair of functions that push something onto the stack (or bump a counter or something) and pop it off a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/1184#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1184
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F1184
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/1184
Reloadhttps://github.com/python/mypy/issues/1184
Reloadhttps://github.com/python/mypy/issues/1184
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1184
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/1184
Coding style suggestion about nesting constructshttps://github.com/python/mypy/issues/1184#top
good-first-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-first-issue%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jan 28, 2016https://github.com/python/mypy/issues/1184#issue-129527577
https://github.com/JukkaL/mypy/blob/master/mypy/checker.py#L542https://github.com/JukkaL/mypy/blob/master/mypy/checker.py#L542
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jan 28, 2016https://github.com/python/mypy/issues/1184#issuecomment-176344000
JukkaLhttps://github.com/JukkaL
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
on Jan 28, 2016https://github.com/python/mypy/issues/1184#event-530185231
ddfisherhttps://github.com/ddfisher
on Mar 1, 2016https://github.com/python/mypy/issues/1184#event-573890120
gvanrossumhttps://github.com/gvanrossum
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 6, 2017https://github.com/python/mypy/issues/1184#event-914705461
gvanrossumhttps://github.com/gvanrossum
on Mar 29, 2017https://github.com/python/mypy/issues/1184#event-1021273913
hauntsaninjahttps://github.com/hauntsaninja
good-first-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-first-issue%22
on Oct 22, 2020https://github.com/python/mypy/issues/1184#event-3906836942
https://github.com/kishdubey
kishdubeyhttps://github.com/kishdubey
on Nov 4, 2020https://github.com/python/mypy/issues/1184#issuecomment-721930423
https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L862https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L862
https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L2803https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L2803
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Nov 4, 2020https://github.com/python/mypy/issues/1184#issuecomment-721938807
https://github.com/dixith
dixithhttps://github.com/dixith
on Mar 25, 2021https://github.com/python/mypy/issues/1184#issuecomment-807435092
@kishdubeyhttps://github.com/kishdubey
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Mar 26, 2021https://github.com/python/mypy/issues/1184#issuecomment-808404257
@dixithhttps://github.com/dixith
JukkaLhttps://github.com/JukkaL
on Sep 6, 2021https://github.com/python/mypy/issues/1184#event-5261923802
Use context manager for Scope (#11053)https://github.com/python/mypy/commit/725a24a82fdf79521db5d0c43549e8731f793c55
#11053https://github.com/python/mypy/pull/11053
725a24ahttps://github.com/python/mypy/commit/725a24a82fdf79521db5d0c43549e8731f793c55
JukkaLhttps://github.com/JukkaL
on Sep 22, 2021https://github.com/python/mypy/issues/1184#event-5342662464
Refactor: Use context manager for mypyc.irbuild.enter_method and mypy…https://github.com/python/mypy/commit/44edc1a6242bad378fb809e12babbbc2baa54178
44edc1ahttps://github.com/python/mypy/commit/44edc1a6242bad378fb809e12babbbc2baa54178
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jun 15, 2022https://github.com/python/mypy/issues/1184#issuecomment-1156454443
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 15, 2022https://github.com/python/mypy/issues/1184#event-6812869188
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/1184
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/1184
good-first-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-first-issue%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.