René's URL Explorer Experiment


Title: Mypy doesn't seem to use types from @overload-ed __sub__ · Issue #11613 · python/mypy · GitHub

Open Graph Title: Mypy doesn't seem to use types from @overload-ed __sub__ · Issue #11613 · python/mypy

X Title: Mypy doesn't seem to use types from @overload-ed __sub__ · Issue #11613 · python/mypy

Description: Bug Report The __sub__ method on the Arrow class from the arrow package has several @overloads: @overload def __sub__(self, other: Union[timedelta, relativedelta]) -> "Arrow": pass # pragma: no cover @overload def __sub__(self, other: Un...

Open Graph Description: Bug Report The __sub__ method on the Arrow class from the arrow package has several @overloads: @overload def __sub__(self, other: Union[timedelta, relativedelta]) -> "Arrow": pass # pragma: no cov...

X Description: Bug Report The __sub__ method on the Arrow class from the arrow package has several @overloads: @overload def __sub__(self, other: Union[timedelta, relativedelta]) -> "Arrow": pass # p...

Opengraph URL: https://github.com/python/mypy/issues/11613

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mypy doesn't seem to use types from @overload-ed __sub__","articleBody":"**Bug Report**\r\n\r\nThe `__sub__` method on the `Arrow` class from the `arrow` package [has several `@overload`s](https://github.com/arrow-py/arrow/blob/d688de482c5379455dfad8163f56749e81b9e806/arrow/arrow.py#L1730):\r\n\r\n```python\r\n@overload\r\ndef __sub__(self, other: Union[timedelta, relativedelta]) -> \"Arrow\":\r\n    pass  # pragma: no cover\r\n\r\n@overload\r\ndef __sub__(self, other: Union[dt_datetime, \"Arrow\"]) -> timedelta:\r\n    pass  # pragma: no cover\r\n\r\ndef __sub__(self, other: Any) -> Union[timedelta, \"Arrow\"]:\r\n\r\n    if isinstance(other, (timedelta, relativedelta)):\r\n        return self.fromdatetime(self._datetime - other, self._datetime.tzinfo)\r\n\r\n    elif isinstance(other, dt_datetime):\r\n        return self._datetime - other\r\n\r\n    elif isinstance(other, Arrow):\r\n        return self._datetime - other._datetime\r\n\r\n    return NotImplemented\r\n```\r\n\r\nIn particular, one `Arrow` object minus another `Arrow` object will always yield a `timedelta`. However, it seems mypy does not see this, and mistakes the type for `Arrow`.\r\n\r\n\r\n**To Reproduce**\r\n\r\nI discovered the issue when finding the time diff between two arrow timestamps:\r\n\r\n``` python\r\nimport arrow\r\n\r\na1 = arrow.get()\r\na2 = arrow.get()\r\n\r\ndiff = a2 - a1\r\nprint(diff.total_seconds())\r\n```\r\n\r\nWhich, when run with mypy yields:\r\n\r\n```\r\n$ mypy test.py\r\ntest.py:6: error: \"int\" not callable\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\nSetting the type explicitly reviles that mypy thinks the type is `Arrow`, and not `timedelta`:\r\n\r\n``` python\r\nfrom datetime import timedelta\r\nimport arrow\r\n\r\na1 = arrow.get()\r\na2 = arrow.get()\r\n\r\ndiff: timedelta = a2 - a1\r\nprint(diff.total_seconds())\r\n```\r\n\r\nRunning mypy:\r\n\r\n```\r\n$ mypy test.py\r\ntest.py:7: error: Incompatible types in assignment (expression has type \"Arrow\", variable has type \"timedelta\")\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\n\r\n**Expected Behavior**\r\n\r\nThe second `@overload` on `Arrow`'s `__sub__` method specifies that the diff of two `Arrow` objects is a `timedelta`. There should be no type error assigning that to a `timedelta` variable.\r\n\r\n\r\n**Actual Behavior**\r\n\r\nMypy mistakenly thinks the diff is `Arrow`, which creates a false positive.\r\n\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 0.910\r\n- Mypy command-line flags: None\r\n- Mypy configuration options from `mypy.ini` (and other config files): None\r\n- Python version used: 3.9.6\r\n- Operating system and version: Mac OS 11.6 (Big Sur)\r\n","author":{"url":"https://github.com/mathialo","@type":"Person","name":"mathialo"},"datePublished":"2021-11-25T12:41:05Z","url":"https://github.com/python/mypy/issues/11613"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c86825d9-2d36-0fbc-7df0-d4b837a05797
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBB26:1DD784:FDC94:153A67:6B001D8E
html-safe-nonce3db0ad2461f3eb58e19762ac25e9be63f0cf041bb0e3d3c6312b8b616b6a9047
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjI2OjFERDc4NDpGREM5NDoxNTNBNjc6NkIwMDFEOEUiLCJ2aXNpdG9yX2lkIjoiMTQ5OTU2ODM2ODQwMTc4NDIwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf6e658703a56f4afba8246f233ebba17cef3f3fc7126717c28d470fe89881378
hovercard-subject-tagissue:1063541518
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/11613/issue_layout
twitter:imagehttps://opengraph.githubassets.com/672da531135751cf9ac09bbfcf557d6ce03a94ff89eaad6512f7e82a89007dbb/python/mypy/issues/11613
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/672da531135751cf9ac09bbfcf557d6ce03a94ff89eaad6512f7e82a89007dbb/python/mypy/issues/11613
og:image:altBug Report The __sub__ method on the Arrow class from the arrow package has several @overloads: @overload def __sub__(self, other: Union[timedelta, relativedelta]) -> "Arrow": pass # pragma: no cov...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemathialo
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/11613#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11613
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11613
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/11613
Reloadhttps://github.com/python/mypy/issues/11613
Reloadhttps://github.com/python/mypy/issues/11613
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11613
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11613
Mypy doesn't seem to use types from @overload-ed __sub__https://github.com/python/mypy/issues/11613#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
https://github.com/mathialo
mathialohttps://github.com/mathialo
on Nov 25, 2021https://github.com/python/mypy/issues/11613#issue-1063541518
has several @overloadshttps://github.com/arrow-py/arrow/blob/d688de482c5379455dfad8163f56749e81b9e806/arrow/arrow.py#L1730
mathialohttps://github.com/mathialo
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Nov 25, 2021https://github.com/python/mypy/issues/11613#event-5672742548
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Dec 6, 2021https://github.com/python/mypy/issues/11613#issuecomment-986654131
@mathialohttps://github.com/mathialo
JelleZijlstrahttps://github.com/JelleZijlstra
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
on Mar 19, 2022https://github.com/python/mypy/issues/11613#event-6270169542
https://github.com/tbekolay
tbekolayhttps://github.com/tbekolay
on Apr 5, 2022https://github.com/python/mypy/issues/11613#issuecomment-1088953602
__sub__ overloads in arrow.pyhttps://github.com/arrow-py/arrow/blob/master/arrow/arrow.py#L1730
@mathialohttps://github.com/mathialo
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Apr 5, 2022https://github.com/python/mypy/issues/11613#issuecomment-1088995136
https://github.com/tbekolay
tbekolayhttps://github.com/tbekolay
on Apr 5, 2022https://github.com/python/mypy/issues/11613#issuecomment-1089174016
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Apr 5, 2022https://github.com/python/mypy/issues/11613#issuecomment-1089268913
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Jun 27, 2024https://github.com/python/mypy/issues/11613#issuecomment-2192914115
#17392https://github.com/python/mypy/pull/17392
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/11613
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/11613
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.