René's URL Explorer Experiment


Title: The `[unreachable]` check fails for module scope code and allows unreachable raising of Exceptions · Issue #11331 · python/mypy · GitHub

Open Graph Title: The `[unreachable]` check fails for module scope code and allows unreachable raising of Exceptions · Issue #11331 · python/mypy

X Title: The `[unreachable]` check fails for module scope code and allows unreachable raising of Exceptions · Issue #11331 · python/mypy

Description: Bug Report There are seemingly trivial cases of unreachable code not being detected at module level, or when the code consists of raise statements. To Reproduce from typing import Final from typing import NoReturn def foo() -> NoReturn: ...

Open Graph Description: Bug Report There are seemingly trivial cases of unreachable code not being detected at module level, or when the code consists of raise statements. To Reproduce from typing import Final from typing...

X Description: Bug Report There are seemingly trivial cases of unreachable code not being detected at module level, or when the code consists of raise statements. To Reproduce from typing import Final from typing...

Opengraph URL: https://github.com/python/mypy/issues/11331

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"The `[unreachable]` check fails for module scope code and allows unreachable raising of Exceptions","articleBody":"\u003c!--\r\n  If you're new to mypy and you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form\r\n  instead.\r\n-->\r\n\r\n**Bug Report**\r\n\r\n\u003c!--\r\nNote: If the problem you are reporting is about a specific library function, then the typeshed tracker is better suited\r\nfor this report: https://github.com/python/typeshed/issues\r\n-->\r\n\r\nThere are seemingly trivial cases of unreachable code not being detected at module level, or when the code consists of `raise` statements.\r\n\r\n**To Reproduce**\r\n\r\n```py\r\nfrom typing import Final\r\nfrom typing import NoReturn\r\n\r\n\r\ndef foo() -> NoReturn:\r\n    raise Exception(\"foo\")\r\n\r\n\r\ndef bar() -> NoReturn:\r\n    foo()\r\n\r\n    # Should trigger [unreachable] but doesn't\r\n    raise Exception(\"I shouldn't pass static analysis\")\r\n\r\n\r\ndef baz() -> NoReturn:\r\n    raise Exception(\"baz\")\r\n\r\n    # Should trigger [unreachable] but doesn't\r\n    raise Exception(\"I shouldn't pass static analysis\")\r\n\r\n\r\ndef qux() -> None:\r\n    foo()\r\n\r\n    # Should trigger [unreachable] but doesn't\r\n    raise Exception(\"I shouldn't pass static analysis\")\r\n\r\n\r\nfoo()\r\n\r\n# Should trigger [unreachable] but doesn't\r\nraise Exception(\"foo\")\r\n\r\n# Should trigger [unreachable] but doesn't(!)\r\nMEANING: Final[int] = 42\r\n\r\n\r\n```\r\n\r\n**Expected Behavior**\r\n\r\n\u003c!--\r\n  How did you expect your project to behave?\r\n  It’s fine if you’re not sure your understanding is correct.\r\n  Write down what you thought would happen. If you just expected no errors, you can delete this section.\r\n-->\r\n\r\nAs seen in my example, I would expect the optional `[unreachable]` check to detect the following examples of unreachable code:\r\n- General module level code following an exception being raised directly, or a `NoReturn` callable being called.\r\n- Unreachable exception raising (occurring after some prior exception having been raised)\r\n\r\n**Actual Behavior**\r\n\r\n\u003c!--\r\n  Did something go wrong?\r\n  Is something broken, or not behaving as you expected?\r\n-->\r\n\r\nThe example above type checks with `warn_unreachable = True`.\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: `0.910`\r\n- Mypy command-line flags: n/a\r\n- Mypy configuration options from `mypy.ini` (and other config files):\r\n```\r\n[mypy]\r\npython_version = 3.8\r\npretty = True\r\nwarn_redundant_casts = True\r\nwarn_unused_ignores = True\r\nignore_missing_imports = True\r\nstrict_optional = True\r\nno_implicit_optional = True\r\nshow_error_context = True\r\nshow_column_numbers = True\r\ndisallow_untyped_calls = True\r\ndisallow_untyped_defs = True\r\nwarn_return_any = True\r\nwarn_unreachable = True\r\nshow_none_errors = True\r\nshow_error_codes = True\r\nfollow_imports = normal\r\nnamespace_packages = True\r\nexplicit_package_bases = True\r\n```\r\n- Python version used: `3.8.10`\r\n- Operating system and version:\r\n`Ubuntu 21.04`\r\n\r\n\u003c!--\r\nYou can freely edit this text, please remove all the lines\r\nyou believe are unnecessary.\r\n-->\r\n","author":{"url":"https://github.com/harahu","@type":"Person","name":"harahu"},"datePublished":"2021-10-14T08:57:50Z","url":"https://github.com/python/mypy/issues/11331"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ba457310-a904-0f43-f18e-b66ba9898a4e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE954:CEC0A:1D64F32:26069AE:6AFFCEA1
html-safe-noncec57300b024f6166af88e1b65e2e310de0bbd594071656d4b75a11dc79347535e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTU0OkNFQzBBOjFENjRGMzI6MjYwNjlBRTo2QUZGQ0VBMSIsInZpc2l0b3JfaWQiOiI1NjAxNzUwNDE4MDI4NzQ0MzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac566d04c0b4024eb5ca9017bf67b753eeb25dee9383bbc05aa325dd66dfefda3d
hovercard-subject-tagissue:1026140863
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/11331/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a4745ad1026de937d85f6b7ada948f53f2583bd471b18f448199eab27c6d91dd/python/mypy/issues/11331
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4745ad1026de937d85f6b7ada948f53f2583bd471b18f448199eab27c6d91dd/python/mypy/issues/11331
og:image:altBug Report There are seemingly trivial cases of unreachable code not being detected at module level, or when the code consists of raise statements. To Reproduce from typing import Final from typing...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameharahu
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/11331#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11331
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11331
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/11331
Reloadhttps://github.com/python/mypy/issues/11331
Reloadhttps://github.com/python/mypy/issues/11331
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11331
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11331
#11361https://github.com/python/mypy/pull/11361
The [unreachable] check fails for module scope code and allows unreachable raising of Exceptionshttps://github.com/python/mypy/issues/11331#top
#11361https://github.com/python/mypy/pull/11361
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/harahu
harahuhttps://github.com/harahu
on Oct 14, 2021https://github.com/python/mypy/issues/11331#issue-1026140863
harahuhttps://github.com/harahu
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 14, 2021https://github.com/python/mypy/issues/11331#event-5462326971
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11361https://github.com/python/mypy/pull/11361
on Oct 31, 2021https://github.com/python/mypy/issues/11331#event-5545769414
hauntsaninjahttps://github.com/hauntsaninja
on Oct 31, 2021https://github.com/python/mypy/issues/11331#event-5545769457
Check module bodies to be reachable (#11361)https://github.com/python/mypy/commit/e9c7e1007b724becec9d6a3e5eacfdca69c0c9fc
#11361https://github.com/python/mypy/pull/11361
https://docs.github.com/articles/closing-issues-via-commit-messages
e9c7e10https://github.com/python/mypy/commit/e9c7e1007b724becec9d6a3e5eacfdca69c0c9fc
tushar-deepsourcehttps://github.com/tushar-deepsource
on Jan 20, 2022https://github.com/python/mypy/issues/11331#event-5924011527
Check module bodies to be reachable (python#11361)https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11
python#11361https://github.com/python/mypy/pull/11361
https://docs.github.com/articles/closing-issues-via-commit-messages
35558cdhttps://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/11331
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/11331
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.