René's URL Explorer Experiment


Title: Type narrowing of a union type works incorrectly in presence of a list · Issue #11272 · python/mypy · GitHub

Open Graph Title: Type narrowing of a union type works incorrectly in presence of a list · Issue #11272 · python/mypy

X Title: Type narrowing of a union type works incorrectly in presence of a list · Issue #11272 · python/mypy

Description: Bug Report Minimum example: # Standard library modules from typing import List, Union Types = Union[str, List[str]] def f(x: Types) -> None: if isinstance(x, str): reveal_type(x) print("a string!") elif isinstance(x, list): reveal_type(x...

Open Graph Description: Bug Report Minimum example: # Standard library modules from typing import List, Union Types = Union[str, List[str]] def f(x: Types) -> None: if isinstance(x, str): reveal_type(x) print("a string!")...

X Description: Bug Report Minimum example: # Standard library modules from typing import List, Union Types = Union[str, List[str]] def f(x: Types) -> None: if isinstance(x, str): reveal_type(x) print("a s...

Opengraph URL: https://github.com/python/mypy/issues/11272

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing of a union type works incorrectly in presence of a list","articleBody":"**Bug Report**\r\n\r\nMinimum example:\r\n```\r\n# Standard library modules\r\nfrom typing import List, Union\r\n\r\nTypes = Union[str, List[str]]\r\n\r\n\r\ndef f(x: Types) -> None:\r\n    if isinstance(x, str):\r\n        reveal_type(x)\r\n        print(\"a string!\")\r\n    elif isinstance(x, list):\r\n        reveal_type(x)\r\n        print(\"a list!\")\r\n    else:\r\n        reveal_type(x)\r\n        print(\"unreachable code\")\r\n```\r\n\r\nThe output of `mypy test.py` is:\r\n```\r\ntest.py:9: note: Revealed type is \"builtins.str\"\r\ntest.py:12: note: Revealed type is \"builtins.list[builtins.str]\"\r\ntest.py:15: note: Revealed type is \"builtins.list[builtins.str]\"\r\n```\r\n\r\nThe detected type for line 15 is actually incorrect, the code is (or better should be) unreachable and `List[str]` has already been dealt with in the second branch.\r\n\r\n**To Reproduce**\r\n\r\n1. Save the above code to `test.py`\r\n2. Run `mypy test.py`\r\n\r\n**Expected Behavior**\r\n\r\nI expect that it correctly recognises the code as unreachable.\r\n\r\n**Actual Behavior**\r\n\r\nmypy thinks that the type in the branch is reachable with type `List[str]`.\r\n\r\nAn interesting variation of the above is using `Types = Union[str, List[str], List[int]]`. Then the output is:\r\n```\r\ntest.py:9: note: Revealed type is \"builtins.str\"\r\ntest.py:12: note: Revealed type is \"Union[builtins.list[builtins.str], builtins.list[builtins.int]]\"\r\ntest.py:15: note: Revealed type is \"\u003cnothing>\"\r\n```\r\nwhich is correct.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: mypy 0.910\r\n- Mypy command-line flags: none\r\n- Mypy configuration options from `mypy.ini` (and other config files): none\r\n- Python version used: Python 3.9.7\r\n- Operating system and version: MacOS 11.5.2\r\n","author":{"url":"https://github.com/yasinzaehringer-paradime","@type":"Person","name":"yasinzaehringer-paradime"},"datePublished":"2021-10-05T16:09:12Z","url":"https://github.com/python/mypy/issues/11272"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:242305e0-eb3b-b15b-dcfc-90d88ea2b9aa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBB72:2046A4:E36994:130486B:6B005601
html-safe-nonce0fee6a18afe85f8d4997372701ab77c39fbe217d4bcdc56294e7d5985873a4c5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjcyOjIwNDZBNDpFMzY5OTQ6MTMwNDg2Qjo2QjAwNTYwMSIsInZpc2l0b3JfaWQiOiI4MzAxMzAzODUzNjc3MDQxMTUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac78ecff72e350c2bb6e126106824d3d5d0bbca39fa9a1a1b26aede3ce2ddb8972
hovercard-subject-tagissue:1016512176
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/11272/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bdf0724eb493a1b66315e1e02eda7bac062ef2ddf641640bd6571a73476f9c04/python/mypy/issues/11272
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bdf0724eb493a1b66315e1e02eda7bac062ef2ddf641640bd6571a73476f9c04/python/mypy/issues/11272
og:image:altBug Report Minimum example: # Standard library modules from typing import List, Union Types = Union[str, List[str]] def f(x: Types) -> None: if isinstance(x, str): reveal_type(x) print("a string!")...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyasinzaehringer-paradime
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/11272#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11272
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F11272
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/11272
Reloadhttps://github.com/python/mypy/issues/11272
Reloadhttps://github.com/python/mypy/issues/11272
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11272
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/11272
#11273https://github.com/python/mypy/pull/11273
Type narrowing of a union type works incorrectly in presence of a listhttps://github.com/python/mypy/issues/11272#top
#11273https://github.com/python/mypy/pull/11273
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/yasinzaehringer-paradime
yasinzaehringer-paradimehttps://github.com/yasinzaehringer-paradime
on Oct 5, 2021https://github.com/python/mypy/issues/11272#issue-1016512176
yasinzaehringer-paradimehttps://github.com/yasinzaehringer-paradime
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 5, 2021https://github.com/python/mypy/issues/11272#event-5411874758
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11273https://github.com/python/mypy/pull/11273
on Oct 31, 2021https://github.com/python/mypy/issues/11272#event-5545708081
hauntsaninjahttps://github.com/hauntsaninja
on Oct 31, 2021https://github.com/python/mypy/issues/11272#event-5545708105
Fixes type narrowing for overlaping runtime types (#11273)https://github.com/python/mypy/commit/f4a21a4010405a3e98d0345de6c8f7ca955ce892
#11273https://github.com/python/mypy/pull/11273
https://docs.github.com/articles/closing-issues-via-commit-messages
f4a21a4https://github.com/python/mypy/commit/f4a21a4010405a3e98d0345de6c8f7ca955ce892
tushar-deepsourcehttps://github.com/tushar-deepsource
on Jan 20, 2022https://github.com/python/mypy/issues/11272#event-5924011503
Fixes type narrowing for overlaping runtime types (python#11273)https://github.com/DeepSourceCorp/mypy/commit/d8e7cd56b9b0e3cbcfdefdd5aa9621020119f1ed
python#11273https://github.com/python/mypy/pull/11273
https://docs.github.com/articles/closing-issues-via-commit-messages
d8e7cd5https://github.com/DeepSourceCorp/mypy/commit/d8e7cd56b9b0e3cbcfdefdd5aa9621020119f1ed
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/11272
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/11272
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.