René's URL Explorer Experiment


Title: type guarded value is same type as `typing.TypeGuard[T]`? · Issue #10899 · python/mypy · GitHub

Open Graph Title: type guarded value is same type as `typing.TypeGuard[T]`? · Issue #10899 · python/mypy

X Title: type guarded value is same type as `typing.TypeGuard[T]`? · Issue #10899 · python/mypy

Description: Bug Report Okay so, let's say for a second you have this code: from typing_extensions import TypeGuard def type_guard_function(a: object) -> TypeGuard[int]: return isinstance(a, int) reveal_type(type_guard_function) n: object = 5 reveal_...

Open Graph Description: Bug Report Okay so, let's say for a second you have this code: from typing_extensions import TypeGuard def type_guard_function(a: object) -> TypeGuard[int]: return isinstance(a, int) reveal_type(ty...

X Description: Bug Report Okay so, let's say for a second you have this code: from typing_extensions import TypeGuard def type_guard_function(a: object) -> TypeGuard[int]: return isinstance(a, int) reveal_...

Opengraph URL: https://github.com/python/mypy/issues/10899

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"type guarded value is same type as `typing.TypeGuard[T]`?","articleBody":"**Bug Report**\r\n\r\nOkay so, let's say for a second you have this code:\r\n```py\r\nfrom typing_extensions import TypeGuard\r\n\r\ndef type_guard_function(a: object) -> TypeGuard[int]:\r\n    return isinstance(a, int)\r\n\r\nreveal_type(type_guard_function)\r\n\r\nn: object = 5\r\nreveal_type(n)\r\n\r\nif type_guard_function(n):\r\n    reveal_type(n)\r\nelse:\r\n    reveal_type(n)\r\n```\r\n\r\nNow then, it turns out that in this bit:\r\n```py\r\nif type_guard_function(n):\r\n    reveal_type(n)\r\n```\r\n\r\nmypy actually says `n` is a `TypeGuard`! If you look at `ConditionalTypeBinder#frames` during the `reveal_type`, you'll note a: `{('Var', \u003cmypy.nodes.Var object at 0x7f7a76e32580>): TypeGuard(builtins.int)}`.\r\n\r\n`ConditionalTypeBinder` stores types. To prove this to yourself, add a `n = '5'` after `n: object = 5`. You'll see a frame now looks like: `{('Var', \u003cmypy.nodes.Var object at 0x7f7a76e32580>): builtins.str}` (note that since it's the same variable, it's the same memory address :P)...\r\n\r\nAnyways, this seems completely off, because in `types.py`'s `TypeStrVisitor`, you have this:\r\n```py\r\n    def visit_type_guard_type(self, t: TypeGuardType) -> str:\r\n        return 'TypeGuard[{}]'.format(t.type_guard.accept(self))\r\n```\r\n\r\nHere are the relevant lines to the above:\r\n\r\n1) Type narrowing working around `TypeGuardType`:\r\n\r\nhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/checkexpr.py#L4188-L4190\r\n\r\nThis is what causes `reveal_type(n)` in the if statement to be `int`.\r\n\r\n2) The implementation that adds `TypeGuardType` to the value in the first place:\r\n\r\nhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/checker.py#L4147\r\n\r\n3) `TypeStrVisitor#visit_type_guard_type`\r\n\r\nhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/types.py#L2197-L2198\r\n\r\n**Expected Behavior**\r\n\r\nThis doesn't happen. `TypeGuardType` is only for `TypeGuard[T]`. Instead, there's another way to signal to type narrowing that a value became the way it is because of a type guard (necessary because of differences in behavior).\r\n\r\n**Actual Behavior**\r\n\r\nThis does happen. Chaos ensues, causing things like #10647 and #10665. (confirmed this by removing relevant line number 2 and testing both -- no crashes. However, I did this as described in https://github.com/python/mypy/pull/10671#discussion_r654746773 and well, the tests show the problem themselves.)\r\n\r\n**Your Environment**\r\n\r\nThe source code.\r\n\r\n\r\nI was redirected here by the contributing document, as this is a moderate (I think?) effort change, and I have no clue what exactly _should_ change. Like, should type guarded values use their own ProperType? Should there be a bool flag somewhere? No clue.\r\n\r\nFull disclaimer that I probably messed a few things up in my explanation, and that I may have misspoken a few terms. Hopefully I'm wrong and this isn't actually an issue :cold_sweat: .","author":{"url":"https://github.com/A5rocks","@type":"Person","name":"A5rocks"},"datePublished":"2021-08-01T01:04:45Z","url":"https://github.com/python/mypy/issues/10899"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7c9e3354-4eb3-2b80-2242-72cf7208817c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBD5A:133248:2CD727:3D5FD9:6B006A2B
html-safe-nonce929ceceb9587816a975f0bc6bd81381d78890cbb32d0a616fcd36360345f4416
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDVBOjEzMzI0ODoyQ0Q3Mjc6M0Q1RkQ5OjZCMDA2QTJCIiwidmlzaXRvcl9pZCI6IjMzMjExNjIwODI4MDM1NDI1NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac65bdfd5c3c098fec2adc53d26db07adf85a976169a91a4e14f627c34076d985b
hovercard-subject-tagissue:957353054
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/10899/issue_layout
twitter:imagehttps://opengraph.githubassets.com/10f54a54fa752f0dc2dfcc4f6d2250aa72768da24d5a3a3bd4263b7d86e0a043/python/mypy/issues/10899
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10f54a54fa752f0dc2dfcc4f6d2250aa72768da24d5a3a3bd4263b7d86e0a043/python/mypy/issues/10899
og:image:altBug Report Okay so, let's say for a second you have this code: from typing_extensions import TypeGuard def type_guard_function(a: object) -> TypeGuard[int]: return isinstance(a, int) reveal_type(ty...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameA5rocks
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/10899#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10899
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10899
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/10899
Reloadhttps://github.com/python/mypy/issues/10899
Reloadhttps://github.com/python/mypy/issues/10899
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10899
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10899
#11061https://github.com/python/mypy/pull/11061
type guarded value is same type as typing.TypeGuard[T]?https://github.com/python/mypy/issues/10899#top
#11061https://github.com/python/mypy/pull/11061
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Aug 1, 2021https://github.com/python/mypy/issues/10899#issue-957353054
mypy/mypy/checkexpr.pyhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/checkexpr.py#L4188-L4190
7edceadhttps://github.com/python/mypy/commit/7edceadf6ef7de2baab498a5d11b794f891854f5
mypy/mypy/checker.pyhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/checker.py#L4147
7edceadhttps://github.com/python/mypy/commit/7edceadf6ef7de2baab498a5d11b794f891854f5
mypy/mypy/types.pyhttps://github.com/python/mypy/blob/7edceadf6ef7de2baab498a5d11b794f891854f5/mypy/types.py#L2197-L2198
7edceadhttps://github.com/python/mypy/commit/7edceadf6ef7de2baab498a5d11b794f891854f5
#10647https://github.com/python/mypy/issues/10647
#10665https://github.com/python/mypy/issues/10665
#10671 (comment)https://github.com/python/mypy/pull/10671#discussion_r654746773
A5rockshttps://github.com/A5rocks
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Aug 1, 2021https://github.com/python/mypy/issues/10899#event-5094851240
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Sep 6, 2021https://github.com/python/mypy/issues/10899#issuecomment-913273407
#10647https://github.com/python/mypy/issues/10647
#10496https://github.com/python/mypy/pull/10496
#10496https://github.com/python/mypy/pull/10496
#10496https://github.com/python/mypy/pull/10496
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
on Sep 6, 2021https://github.com/python/mypy/issues/10899#issuecomment-913283089
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11061https://github.com/python/mypy/pull/11061
on Sep 14, 2021https://github.com/python/mypy/issues/10899#event-5297389554
hauntsaninjahttps://github.com/hauntsaninja
on Sep 14, 2021https://github.com/python/mypy/issues/10899#event-5297389696
Fix type guard crashes (#11061)https://github.com/python/mypy/commit/05f38571f1b7af46dbadaeba0f74626d3a9e07c9
#11061https://github.com/python/mypy/pull/11061
https://docs.github.com/articles/closing-issues-via-commit-messages
05f3857https://github.com/python/mypy/commit/05f38571f1b7af46dbadaeba0f74626d3a9e07c9
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/10899
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/10899
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.