René's URL Explorer Experiment


Title: Type narrowing behavior for data descriptor assignment is incorrect in some cases · Issue #10399 · python/mypy · GitHub

Open Graph Title: Type narrowing behavior for data descriptor assignment is incorrect in some cases · Issue #10399 · python/mypy

X Title: Type narrowing behavior for data descriptor assignment is incorrect in some cases · Issue #10399 · python/mypy

Description: Mypy normally performs type narrowing for assignment statements when the LHS is a member access (e.g. a.b = x). However, it appears to avoid type narrowing in certain circumstances when b is a descriptor. This special casing leads to inc...

Open Graph Description: Mypy normally performs type narrowing for assignment statements when the LHS is a member access (e.g. a.b = x). However, it appears to avoid type narrowing in certain circumstances when b is a desc...

X Description: Mypy normally performs type narrowing for assignment statements when the LHS is a member access (e.g. a.b = x). However, it appears to avoid type narrowing in certain circumstances when b is a desc...

Opengraph URL: https://github.com/python/mypy/issues/10399

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type narrowing behavior for data descriptor assignment is incorrect in some cases","articleBody":"Mypy normally performs type narrowing for assignment statements when the LHS is a member access (e.g. `a.b = x`). However, it appears to avoid type narrowing in certain circumstances when `b` is a descriptor. This special casing leads to incorrect behaviors in some cases. (Look for \"!!!\" in the sample below.)\r\n\r\n```python\r\nfrom typing import Any, Protocol, Union\r\n\r\nclass HasName(Protocol):\r\n    def __name__(self) -> str:\r\n        ...\r\n\r\nclass Animal:\r\n    def __name__(self) -> str:\r\n        ...\r\n\r\nclass Dog(Animal):\r\n    def __name__(self) -> str:\r\n        ...\r\n\r\n    def run(self) -> None:\r\n        print(\"Run Spot Run!\")\r\n\r\n    def bark(self) -> None:\r\n        print(\"Ruff!\")\r\n\r\nclass Cat:\r\n    def __name__(self) -> str:\r\n        ...\r\n\r\n    def run(self) -> None:\r\n        print(\"Run Kitty Run!\")\r\n\r\n    def purr(self) -> None:\r\n        print(\"Purr!\")\r\n\r\nclass AnimalMember:\r\n    def __get__(self, instance: Any, owner: Any) -> Animal:\r\n        ...\r\n\r\n    def __set__(self, instance: Any, value: HasName) -> None:\r\n        ...\r\n\r\nclass Struct:\r\n    member = AnimalMember()\r\n\r\ndef test_descriptor(cat: Cat, dog: Dog, cat_or_dog: Union[Cat, Dog]):\r\n    inst = Struct()\r\n\r\n    inst.member = cat_or_dog\r\n    reveal_type(inst.member)  # mypy: Revealed type is 'Animal'\r\n    inst.member.run()  # mypy: \"Animal\" has no attribute \"run\"\r\n    inst.member.bark()  # mypy: \"Animal\" has no attribute \"bark\"\r\n    inst.member.purr()  # mypy: \"Animal\" has no attribute \"purr\"\r\n\r\n    inst.member = cat\r\n    reveal_type(inst.member)  # mypy: Revealed type is 'Animal'\r\n    inst.member.run()  # mypy: \"Animal\" has no attribute \"run\"\r\n    inst.member.bark()  # mypy: \"Animal\" has no attribute \"bark\"\r\n    inst.member.purr()  # mypy: \"Animal\" has no attribute \"purr\"\r\n\r\n    inst.member = dog\r\n    reveal_type(inst.member)  # mypy: Revealed type is 'Dog'\r\n    inst.member.run()  # mypy: no error\r\n    inst.member.bark()  # mypy: no error\r\n    inst.member.purr()  # mypy: \"Dog\" has no attribute \"purr\"\r\n\r\n    inst.member = cat_or_dog\r\n    reveal_type(inst.member)  # mypy: Revealed type is 'Dog' !!!!\r\n    inst.member.run()  # mypy: no error\r\n    inst.member.bark()  # mypy: no error\r\n    inst.member.purr()  # mypy: \"Dog\" has no attribute \"purr\"\r\n\r\n    inst.member = cat\r\n    reveal_type(inst.member)  # mypy: Revealed type is 'Dog' !!!!\r\n    inst.member.run()  # mypy: no error\r\n    inst.member.bark()  # mypy: no error !!!!\r\n    inst.member.purr()  # mypy: \"Dog\" has no attribute \"purr\" !!!!\r\n```\r\n\r\nRefer to [this bug report in the pyright repo](https://github.com/microsoft/pyright/issues/1814) for details and a discussion of opitons. I'm interested in thoughts on a more robust heuristic that we can use across type checkers to handle this case properly.","author":{"url":"https://github.com/erictraut","@type":"Person","name":"erictraut"},"datePublished":"2021-05-02T02:17:48Z","url":"https://github.com/python/mypy/issues/10399"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9c9e62b6-7723-6371-5ad3-5f605ee59256
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA5B2:1756E4:E023CA:123B0A8:6AFFFABF
html-safe-nonce583b5e58c8a40dcd113fe4766d0deb78e0b24028cbf8268cb009fde05b3c8ae7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUIyOjE3NTZFNDpFMDIzQ0E6MTIzQjBBODo2QUZGRkFCRiIsInZpc2l0b3JfaWQiOiIyNzA1MTgwNTE0NjE2MDgxMDg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1d357a7287f8990b3c91d0d1aad4c9b353ed97a2fb6f4188ae06fe6f1450e0ca
hovercard-subject-tagissue:873818337
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/10399/issue_layout
twitter:imagehttps://opengraph.githubassets.com/81feb9422eec627bf581220badedb6dafb35f5b267ac135e18dc5d5a65be98be/python/mypy/issues/10399
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81feb9422eec627bf581220badedb6dafb35f5b267ac135e18dc5d5a65be98be/python/mypy/issues/10399
og:image:altMypy normally performs type narrowing for assignment statements when the LHS is a member access (e.g. a.b = x). However, it appears to avoid type narrowing in certain circumstances when b is a desc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerictraut
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/10399#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10399
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10399
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/10399
Reloadhttps://github.com/python/mypy/issues/10399
Reloadhttps://github.com/python/mypy/issues/10399
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10399
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10399
#19296https://github.com/python/mypy/pull/19296
Type narrowing behavior for data descriptor assignment is incorrect in some caseshttps://github.com/python/mypy/issues/10399#top
#19296https://github.com/python/mypy/pull/19296
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on May 2, 2021https://github.com/python/mypy/issues/10399#issue-873818337
this bug report in the pyright repohttps://github.com/microsoft/pyright/issues/1814
erictrauthttps://github.com/erictraut
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 2, 2021https://github.com/python/mypy/issues/10399#event-4674248804
JelleZijlstrahttps://github.com/JelleZijlstra
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
on Mar 19, 2022https://github.com/python/mypy/issues/10399#event-6270147982
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#19296https://github.com/python/mypy/pull/19296
on Jun 19, 2025https://github.com/python/mypy/issues/10399#event-18236528327
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 19, 2025https://github.com/python/mypy/issues/10399#event-18236528329
Re-widen custom properties after narrowing (#19296)https://github.com/python/mypy/commit/96fcd59585d1460440967f5dd6bdc82d43703187
#19296https://github.com/python/mypy/pull/19296
96fcd59https://github.com/python/mypy/commit/96fcd59585d1460440967f5dd6bdc82d43703187
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/10399
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/10399
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.