Title: "Source file found twice under different module names" with namespace package installed in virtualenv by "pip install -e ." · Issue #10172 · python/mypy · GitHub
Open Graph Title: "Source file found twice under different module names" with namespace package installed in virtualenv by "pip install -e ." · Issue #10172 · python/mypy
X Title: "Source file found twice under different module names" with namespace package installed in virtualenv by "pip install -e ." · Issue #10172 · python/mypy
Description: Bug Report At work, we have a standard project layout using namespace packages with dev/build/test dependencies declared in setup.py. It's a bit complex, but it worked well up until mypy 0.790. Since mypy 0.800, mypy is complaining: "Sou...
Open Graph Description: Bug Report At work, we have a standard project layout using namespace packages with dev/build/test dependencies declared in setup.py. It's a bit complex, but it worked well up until mypy 0.790. Sin...
X Description: Bug Report At work, we have a standard project layout using namespace packages with dev/build/test dependencies declared in setup.py. It's a bit complex, but it worked well up until mypy 0.790....
Opengraph URL: https://github.com/python/mypy/issues/10172
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"\"Source file found twice under different module names\" with namespace package installed in virtualenv by \"pip install -e .\"","articleBody":"**Bug Report**\r\n\r\nAt work, we have a standard project layout using namespace packages with dev/build/test dependencies declared in setup.py. It's a bit complex, but it worked well up until mypy 0.790. Since mypy 0.800, mypy is complaining: \"Source file found twice under different module names\".\r\n\r\nThis appears to be a rather obscure corner case requiring:\r\n* implicit namespace packages\r\n* dev dependencies declared in setup.py, rather than a requirements file\r\n* use of `pip install -e .[dev]` to install those dependencies\r\n* running mypy on directories and files (not packages or modules)\r\n\r\nRemove any of those conditions and mypy behaves as expected (ie. back to what we had under 0.790). But since it worked nicely under 0.790, it sure feels like a regression to me.\r\n\r\nHere's a simplified version of the project layout, for a package `fn.common` with one module and unit tests:\r\n```\r\n.\r\n├── fn\r\n│ └── common\r\n│ ├── __init__.py\r\n│ ├── py.typed\r\n│ └── utils.py\r\n├── setup.py\r\n└── tests\r\n ├── __init__.py\r\n └── test_utils.py\r\n```\r\n`fn` is an implicit namespace package named after the company. We're Python 3 only, so we have no need for legacy namespace packages. Every project, whether library or application, puts all production code in `fn/\u003csomething>`. Nice and clean and tidy and consistent.\r\n\r\nThe source code of the package isn't important. (There are type hints and no type errors.)\r\n\r\nWhat matters is the contents of `setup.py`, the way we initialize our virtualenv, and how we run mypy. Here's `setup.py`:\r\n```\r\nimport os\r\nfrom setuptools import setup\r\n\r\ninstall_requires = [] # type: ignore\r\ndev_requires = [\"mypy==0.790\"]\r\n\r\npackages = [\"fn.common\"]\r\npackage_data = {\"fn.common\": [\"py.typed\"]}\r\n\r\nsetup(\r\n name=\"fnlib-common\",\r\n description=\"\",\r\n url=\"\",\r\n author=\"\",\r\n author_email=\"\",\r\n packages=packages,\r\n package_data=package_data,\r\n install_requires=install_requires,\r\n extras_require={\"dev\": dev_requires},\r\n)\r\n```\r\n\r\nThis lets us create a virtualenv as follows:\r\n```\r\n$ /usr/local/bin/python3.8 -m venv venv\r\n$ source venv/bin/activate\r\n$ pip install -e '.[dev]'\r\n```\r\n\r\nSince I've pinned mypy to 0.790, it works fine:\r\n```\r\n$ mypy --ignore-missing-imports --check-untyped-defs fn tests *.py\r\nSuccess: no issues found in 5 source files\r\n```\r\n\r\nIf I upgrade to 0.812, it stops working:\r\n```\r\n$ pip install mypy==0.812\r\n$ mypy --ignore-missing-imports --check-untyped-defs fn tests *.py\r\nfn/common/__init__.py: error: Source file found twice under different module names: 'common' and 'fn.common'\r\nFound 1 error in 1 file (errors prevented further checking)\r\n```\r\n\r\nThe first release showing this behaviour was 0.800. I used `git bisect` to track down the responsible commit: https://github.com/python/mypy/commit/e4131a5cb7371943413191591426eb9c6a6be159.\r\n\r\n**To Reproduce**\r\n\r\n1. get my source code:\r\n```\r\n$ wget https://www.gerg.ca/mypy/fnlib-common.tar.gz\r\n$ tar -xzvf ~/fnlib-common.tar.gz\r\n$ cd fnlib-common\r\n```\r\n2. setup virtualenv:\r\n```\r\n$ python3 -m venv venv\r\n$ source venv/bin/activate\r\n$ pip install -e '.[dev]' # installs mypy 0.790\r\n```\r\n3. run with mypy 0.790: no problem\r\n```\r\n$ mypy --ignore-missing-imports fn tests *.py\r\nSuccess: no issues found in 5 source files\r\n```\r\n4. upgrade to mypy >= 0.800 and see the problem\r\n```\r\n$ pip install mypy==0.800 # or later\r\n$ mypy --ignore-missing-imports fn tests *.py\r\nfn/common/__init__.py: error: Source file found twice under different module names: 'common' and 'fn.common'\r\nFound 1 error in 1 file (errors prevented further checking)\r\n```\r\n\r\n**Expected Behavior**\r\n\r\nSame output from mypy >= 0.800 as from mypy 0.790, i.e. no errors.\r\n\r\n**Actual Behavior**\r\n\r\nErrors from mypy >= 0.800.\r\n\r\n**Your Environment**\r\n\r\nhost 1:\r\n```\r\n$ lsb_release -a\r\nDistributor ID:\tUbuntu\r\nDescription:\tUbuntu 20.04.2 LTS\r\nRelease:\t20.04\r\nCodename:\tfocal\r\n\r\n$ /usr/local/bin/python3.8 --version\r\nPython 3.8.6+\r\n```\r\n\r\nhost 2:\r\n```\r\n$ lsb_release -a\r\nNo LSB modules are available.\r\nDistributor ID:\tDebian\r\nDescription:\tDebian GNU/Linux 10 (buster)\r\nRelease:\t10\r\nCodename:\tbuster\r\n\r\n$ /usr/bin/python3.7 --version\r\nPython 3.7.3\r\n```\r\n\r\nSame results on host 1 and host 2.\r\n\r\nNo mypy config files -- command-line only.\r\n","author":{"url":"https://github.com/gward","@type":"Person","name":"gward"},"datePublished":"2021-03-05T23:28:23Z","url":"https://github.com/python/mypy/issues/10172"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a0681ecb-5122-df93-b47a-99b1182beb76 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D4BC:1EE22E:5247B:71464:6B005133 |
| html-safe-nonce | 4a69a7ea4f1173dab8c92a57b1876e3e48e035589742d0753d4355a90dd59c17 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEJDOjFFRTIyRTo1MjQ3Qjo3MTQ2NDo2QjAwNTEzMyIsInZpc2l0b3JfaWQiOiI4ODI0NTUwNjk5OTE3Mzk4MzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 933246eb1e97ec0141a28379cf179a4745450a4670a39563a09869185cb3aafb |
| hovercard-subject-tag | issue:823489388 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/10172/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e7d17cf99fd0f23b36eb36e18a2285853a9586af32ecdd380f5dad345a0af13a/python/mypy/issues/10172 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7d17cf99fd0f23b36eb36e18a2285853a9586af32ecdd380f5dad345a0af13a/python/mypy/issues/10172 |
| og:image:alt | Bug Report At work, we have a standard project layout using namespace packages with dev/build/test dependencies declared in setup.py. It's a bit complex, but it worked well up until mypy 0.790. Sin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gward |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width