René's URL Explorer Experiment


Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy · GitHub

Open Graph Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy

X Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy

Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR up-to-date and passing tests again and ...

Open Graph Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR...

X Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought...

Opengraph URL: https://github.com/python/mypy/issues/10104

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Code review request: support for asdict returning TypedDict","articleBody":"I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :)\r\n\r\nI have brought this PR up-to-date and passing tests again and would like to request a re-review: https://github.com/python/mypy/pull/8583/\r\n\r\n@JukkaL Perhaps you have the time at some point to take a look or could ping someone who does?\r\n\r\nAlthough the feature is already mentioned in #5152, I'll try to pitch it.\r\n\r\nThe pitch:\r\n====\r\n\r\nI have a dataclass that happens to have the same (or a subset of the same) fields as another class.\r\nThe list is potentially long, and each one has a different type.\r\nI would like to construct the class out of the dataclass, without having to explicitly list each field as an argument to the class's constructor. It's easy to do this at run-time, but I would like to ensure that it is also statically checked.\r\n\r\nTo avoid listing each field manually, I can take advantage of splatting the `TypedDict`.\r\nThis should allow mypy to type-check that I do in fact pass the correct arguments to the class constructor.\r\n\r\n```python\r\n@dataclass\r\nclass FooEntity:\r\n  bar: str\r\n  # long list of fields...\r\n\r\nclass Foo:\r\n  def __init__(bar: str, ...): pass\r\n\r\ndef create_foo_from_entity(foo: FooEntity) -> Foo:\r\n  return Foo(**asdict(foo))\r\n```\r\n\r\nI could think of a similar example with a function instead of a class constructor.\r\n\r\nYou could also have a case where a function is expected to return a certain `TypedDict` (let's say it's part of an existing API), and you have decided to use dataclasses as your internal representation, among other reasons, because they can have methods, are mutable, and possible to build-up incrementally. To avoid having to explicitly construct the `TypedDict` from the dataclass (which may include nested dataclasses), you could just call `asdict` on it and still be assured that the types match what is expected.\r\n\r\nI can't otherwise see many use cases for this, as I would assume that many people just directly serialize the return value of `asdict`, and so don't use it in a precisely-typed manner.\r\n\r\nFinally, as a future idea, it would be interesting to be able to use a type annotation `AsDict[MyDataclass]` to represent the `TypedDict` returned by calling `asdict(instance_of_my_dataclass)`. This would allow the information about which `TypedDict` was returned to flow across function boundaries.","author":{"url":"https://github.com/syastrov","@type":"Person","name":"syastrov"},"datePublished":"2021-02-18T01:29:37Z","url":"https://github.com/python/mypy/issues/10104"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:31033dab-5fda-e9f6-876f-cd80fa63f558
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C56:2A087:E0972A:12DD82C:6B00584A
html-safe-noncecdd049e39441c430b552dd581e3ceeb26be5e4234752b85f96e4dc550b079c33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzU2OjJBMDg3OkUwOTcyQToxMkREODJDOjZCMDA1ODRBIiwidmlzaXRvcl9pZCI6IjgwOTkyNzgyMzMyNTE1NzQ1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdd3ad7c93db392e93905dd0ab8b8a374f42b72a85fef421bcf9708d7b3c81e2b
hovercard-subject-tagissue:810672458
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/10104/issue_layout
twitter:imagehttps://opengraph.githubassets.com/101d393c07566a71da6b35d9c7d96ad969631ded6060cfd789273d1321702ed6/python/mypy/issues/10104
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/101d393c07566a71da6b35d9c7d96ad969631ded6060cfd789273d1321702ed6/python/mypy/issues/10104
og:image:altI'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesyastrov
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/10104#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10104
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F10104
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/10104
Reloadhttps://github.com/python/mypy/issues/10104
Reloadhttps://github.com/python/mypy/issues/10104
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10104
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/10104
Code review request: support for asdict returning TypedDicthttps://github.com/python/mypy/issues/10104#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-dataclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-dataclasses%22
https://github.com/syastrov
syastrovhttps://github.com/syastrov
on Feb 18, 2021https://github.com/python/mypy/issues/10104#issue-810672458
#8583https://github.com/python/mypy/pull/8583
@JukkaLhttps://github.com/JukkaL
#5152https://github.com/python/mypy/issues/5152
syastrovhttps://github.com/syastrov
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Feb 18, 2021https://github.com/python/mypy/issues/10104#event-4344329952
JelleZijlstrahttps://github.com/JelleZijlstra
topic-dataclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-dataclasses%22
on Mar 19, 2022https://github.com/python/mypy/issues/10104#event-6270084470
https://github.com/tony
tonyhttps://github.com/tony
on Jul 30, 2022https://github.com/python/mypy/issues/10104#issuecomment-1200284491
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on Aug 25, 2023https://github.com/python/mypy/issues/10104#issuecomment-1693611743
https://github.com/m-aciek
m-aciekhttps://github.com/m-aciek
on Aug 31, 2025https://github.com/python/mypy/issues/10104#issuecomment-3240045259
@tonyhttps://github.com/tony
ubertypedhttps://github.com/ViliamV/ubertyped
https://github.com/m-aciek
m-aciekhttps://github.com/m-aciek
on Aug 31, 2025https://github.com/python/mypy/issues/10104#issuecomment-3240066134
Intersection typehttps://github.com/python/typing/issues/213
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/10104
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/10104
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-dataclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-dataclasses%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.