Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy · GitHub
Open Graph Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy
X Title: Code review request: support for asdict returning TypedDict · Issue #10104 · python/mypy
Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR up-to-date and passing tests again and ...
Open Graph Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR...
X Description: I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought...
Opengraph URL: https://github.com/python/mypy/issues/10104
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Code review request: support for asdict returning TypedDict","articleBody":"I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :)\r\n\r\nI have brought this PR up-to-date and passing tests again and would like to request a re-review: https://github.com/python/mypy/pull/8583/\r\n\r\n@JukkaL Perhaps you have the time at some point to take a look or could ping someone who does?\r\n\r\nAlthough the feature is already mentioned in #5152, I'll try to pitch it.\r\n\r\nThe pitch:\r\n====\r\n\r\nI have a dataclass that happens to have the same (or a subset of the same) fields as another class.\r\nThe list is potentially long, and each one has a different type.\r\nI would like to construct the class out of the dataclass, without having to explicitly list each field as an argument to the class's constructor. It's easy to do this at run-time, but I would like to ensure that it is also statically checked.\r\n\r\nTo avoid listing each field manually, I can take advantage of splatting the `TypedDict`.\r\nThis should allow mypy to type-check that I do in fact pass the correct arguments to the class constructor.\r\n\r\n```python\r\n@dataclass\r\nclass FooEntity:\r\n bar: str\r\n # long list of fields...\r\n\r\nclass Foo:\r\n def __init__(bar: str, ...): pass\r\n\r\ndef create_foo_from_entity(foo: FooEntity) -> Foo:\r\n return Foo(**asdict(foo))\r\n```\r\n\r\nI could think of a similar example with a function instead of a class constructor.\r\n\r\nYou could also have a case where a function is expected to return a certain `TypedDict` (let's say it's part of an existing API), and you have decided to use dataclasses as your internal representation, among other reasons, because they can have methods, are mutable, and possible to build-up incrementally. To avoid having to explicitly construct the `TypedDict` from the dataclass (which may include nested dataclasses), you could just call `asdict` on it and still be assured that the types match what is expected.\r\n\r\nI can't otherwise see many use cases for this, as I would assume that many people just directly serialize the return value of `asdict`, and so don't use it in a precisely-typed manner.\r\n\r\nFinally, as a future idea, it would be interesting to be able to use a type annotation `AsDict[MyDataclass]` to represent the `TypedDict` returned by calling `asdict(instance_of_my_dataclass)`. This would allow the information about which `TypedDict` was returned to flow across function boundaries.","author":{"url":"https://github.com/syastrov","@type":"Person","name":"syastrov"},"datePublished":"2021-02-18T01:29:37Z","url":"https://github.com/python/mypy/issues/10104"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:31033dab-5fda-e9f6-876f-cd80fa63f558 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8C56:2A087:E0972A:12DD82C:6B00584A |
| html-safe-nonce | cdd049e39441c430b552dd581e3ceeb26be5e4234752b85f96e4dc550b079c33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzU2OjJBMDg3OkUwOTcyQToxMkREODJDOjZCMDA1ODRBIiwidmlzaXRvcl9pZCI6IjgwOTkyNzgyMzMyNTE1NzQ1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dd3ad7c93db392e93905dd0ab8b8a374f42b72a85fef421bcf9708d7b3c81e2b |
| hovercard-subject-tag | issue:810672458 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/10104/issue_layout |
| twitter:image | https://opengraph.githubassets.com/101d393c07566a71da6b35d9c7d96ad969631ded6060cfd789273d1321702ed6/python/mypy/issues/10104 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/101d393c07566a71da6b35d9c7d96ad969631ded6060cfd789273d1321702ed6/python/mypy/issues/10104 |
| og:image:alt | I'm sorry for abusing the issue tracker, but I'm not sure how else to notify someone who could perform a code-review (I did try pinging/mentions). And no worries of course :) I have brought this PR... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | syastrov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width