René's URL Explorer Experiment


Title: Fix .files and inferred packages_distributions for .egg-info packages by jherland · Pull Request #437 · python/importlib_metadata · GitHub

Open Graph Title: Fix .files and inferred packages_distributions for .egg-info packages by jherland · Pull Request #437 · python/importlib_metadata

X Title: Fix .files and inferred packages_distributions for .egg-info packages by jherland · Pull Request #437 · python/importlib_metadata

Description: The first three commits fix #115 for the case where a .egg-info package includes installed-files.txt: We prefer installed-files.txt over SOURCES.txt as a source for Distribution.files, as the former is deemed more accurate when it is available. The last two commits attempts to fix #115 for the case where we have no choice but to parse SOURCES.txt: This assumes that Distribution.files should never contain a path to a non-existent file. We simply remove non-existent files with a filter, thus removing any entries from SOURCES.txt that refer to files that were part of the source package, but not part of the final installation. Commits: tests/fixtures: Fix FilesDef type to include bytes values Add tests for egg-info package with no installed modules Distribution.files: Prefer *.egg-info/installed-files.txt to SOURCES.txt Add tests for egg-info package with .files from inaccurate SOURCES.txt Distribution.files: Only return files that actually exist

Open Graph Description: The first three commits fix #115 for the case where a .egg-info package includes installed-files.txt: We prefer installed-files.txt over SOURCES.txt as a source for Distribution.files, as the forme...

X Description: The first three commits fix #115 for the case where a .egg-info package includes installed-files.txt: We prefer installed-files.txt over SOURCES.txt as a source for Distribution.files, as the forme...

Opengraph URL: https://github.com/python/importlib_metadata/pull/437

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dca91d9f-d8ea-c92d-3e78-be7db11264ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB538:220721:9C1FBB:D65598:6B00A544
html-safe-nonce07259800bf7b2541deb418b0cc33a3a82ca9924772e986f6bc6a72e24cb29d91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTM4OjIyMDcyMTo5QzFGQkI6RDY1NTk4OjZCMDBBNTQ0IiwidmlzaXRvcl9pZCI6IjMzMzQ0NDM3MjgwMDA1NTg0MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3a20bf4d35b492d89b61ed9df5df664abe69423142c002ef997dfcc3b7548989
hovercard-subject-tagpull_request:1271877994
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/importlib_metadata/pull/437/files
twitter:imagehttps://avatars.githubusercontent.com/u/547031?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/547031?s=400&v=4
og:image:altThe first three commits fix #115 for the case where a .egg-info package includes installed-files.txt: We prefer installed-files.txt over SOURCES.txt as a source for Distribution.files, as the forme...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/importlib_metadata git https://github.com/python/importlib_metadata.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id306448340
octolytics-dimension-repository_nwopython/importlib_metadata
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id306448340
octolytics-dimension-repository_network_root_nwopython/importlib_metadata
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f575159976167242d488c0b062eb355c4e198b7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/importlib_metadata/pull/437/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fimportlib_metadata%2Fpull%2F437%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fimportlib_metadata%2Fpull%2F437%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fimportlib_metadata
Reloadhttps://github.com/python/importlib_metadata/pull/437/files
Reloadhttps://github.com/python/importlib_metadata/pull/437/files
Reloadhttps://github.com/python/importlib_metadata/pull/437/files
pythonhttps://github.com/python
importlib_metadatahttps://github.com/python/importlib_metadata
Codehttps://github.com/python/importlib_metadata
Issues8 (8)https://github.com/python/importlib_metadata/issues
Pull requests6 (6)https://github.com/python/importlib_metadata/pulls
Actionshttps://github.com/python/importlib_metadata/actions
Projectshttps://github.com/python/importlib_metadata/projects
Wikihttps://github.com/python/importlib_metadata/wiki
Security and qualityhttps://github.com/python/importlib_metadata/security
Insightshttps://github.com/python/importlib_metadata/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fimportlib_metadata%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fimportlib_metadata%2Fissues%2Fnew%2Fchoose
jaracohttps://github.com/jaraco
python:mainhttps://github.com/python/importlib_metadata/tree/main
jherland:egg-metadata-workhttps://github.com/jherland/importlib_metadata/tree/egg-metadata-work
Conversation 34 https://github.com/python/importlib_metadata/pull/437
Commits 23 https://github.com/python/importlib_metadata/pull/437/commits
Checks 0 https://github.com/python/importlib_metadata/pull/437/checks
Files changed https://github.com/python/importlib_metadata/pull/437/files
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
Fix .files and inferred packages_distributions for .egg-info packages https://github.com/python/importlib_metadata/pull/437/files#top
Show all changes 23 commits https://github.com/python/importlib_metadata/pull/437/files
fed3a41 tests/fixtures: Fix FilesDef type to include bytes values jherland Mar 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/fed3a41fa037ccf0f601b89a899ce6f22ff266af
578322a Add tests for egg-info package with no installed modules jherland Mar 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/578322a37d6b26acf8cede13e327dce105f3577d
61b0f29 Distribution.files: Prefer *.egg-info/installed-files.txt to SOURCES.txt jherland Mar 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/61b0f297960d678d260f31319e7d53584d901e36
8026db2 Add tests for egg-info package with .files from inaccurate SOURCES.txt jherland Mar 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/8026db2b63274af61d32007c3d7e8fc8b57bdd26
22d9ea5 Distribution.files: Only return files that actually exist jherland Mar 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/22d9ea5e307412c0e46c6cb90db54ec082d1d536
a107ce5 Merge branch 'main' into egg-metadata-work jaraco Mar 18, 2023 https://github.com/python/importlib_metadata/pull/437/commits/a107ce55d30ef2ad97d0df8c967c63b97f852d68
b391f77 squash! Add tests for egg-info package with no installed modules jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/b391f77d078b461da972226dbf6f0649e78eb5db
110f00d Add test case demonstrating inferring module names from installed-fil… jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/110f00d24304fdf446a640513f6bf7aef18ba9c3
eeb2ed1 Fix issues with inferring module names from installed-files.txt jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/eeb2ed1593e25e4be3c7da8db073260a4ae8ec1e
a2dc88a squash! Add tests for egg-info package with .files from inaccurate SO… jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/a2dc88a299d6cb83052d91928b12cde0a6e5a2de
f62bf95 squash! Add tests for egg-info package with no installed modules jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/f62bf95d921fd8aca553813533f110d9010c2412
61eca31 squash! Distribution.files: Only return files that actually exist jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/61eca31a7456ccc39e3fda8e098497a4f28482b4
9b165a9 Refactor logic for skipping missing files out of magic_files() jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/9b165a91af49bb11b7cf06b5661801f603aaeba6
33eb7b4 Rewrite docstrings to clarify the expected output format, and why we … jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/33eb7b4a0312017048d849cf1aef0321282d329d
fa9cca4 test_packages_distributions_all_module_types() must create existing f… jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/fa9cca4ebb6c5aaf43197b04c4e28bf62bdb11ce
70ff991 test_packages_distributions_all_module_types: Create valid import names jherland Mar 19, 2023 https://github.com/python/importlib_metadata/pull/437/commits/70ff991377f8d0848865c8c210edd2c7c41c119c
5dbe83c Revert "test_packages_distributions_all_module_types: Create valid im… jaraco Apr 9, 2023 https://github.com/python/importlib_metadata/pull/437/commits/5dbe83cdb0565e13f5a57629a6a9a334e07ebe93
4e7f79f Revert "test_packages_distributions_all_module_types() must create ex… jaraco Apr 9, 2023 https://github.com/python/importlib_metadata/pull/437/commits/4e7f79f5998cb08c2d84ca250c83a2820dd32e8a
812db6f Merge branch 'main' into egg-metadata-work jaraco Apr 9, 2023 https://github.com/python/importlib_metadata/pull/437/commits/812db6f0617a1f1107b89d04676e261e41249379
387f3bd Merge branch 'main' into egg-metadata-work jaraco Apr 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/387f3bde6280630b4b9d38957651a1ee6d8774c6
8818432 ⚫ Fade to black. jaraco Apr 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/8818432f9c71f77bbb79fcf56a9aa53e4b9a6bd5
3d7ee19 Refactor to avoid missed coverage jaraco Apr 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/3d7ee19cd58ceb67f91a6766e9f6035a918b95f2
b8a8b5d Update changelog. jaraco Apr 10, 2023 https://github.com/python/importlib_metadata/pull/437/commits/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456
Clear filters https://github.com/python/importlib_metadata/pull/437/files
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
CHANGES.rst https://github.com/python/importlib_metadata/pull/437/files#diff-ff3c479edefad986d2fe6fe7ead575a46b086e3bbcf0ccc86d85efc4a4c63c79
__init__.py https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
fixtures.py https://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
test_api.py https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
test_main.py https://github.com/python/importlib_metadata/pull/437/files#diff-41d180f6f7233d175c2dfe36c45c4ea80eed4754fa7ed4eed46ccde1b2a778c7
CHANGES.rsthttps://github.com/python/importlib_metadata/pull/437/files#diff-ff3c479edefad986d2fe6fe7ead575a46b086e3bbcf0ccc86d85efc4a4c63c79
View file https://github.com/jherland/importlib_metadata/blob/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456/CHANGES.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/importlib_metadata/pull/437/{{ revealButtonHref }}
https://github.com/python/importlib_metadata/pull/437/files#diff-ff3c479edefad986d2fe6fe7ead575a46b086e3bbcf0ccc86d85efc4a4c63c79
importlib_metadata/__init__.pyhttps://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
View file https://github.com/jherland/importlib_metadata/blob/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456/importlib_metadata/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/importlib_metadata/pull/437/{{ revealButtonHref }}
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
https://github.com/python/importlib_metadata/pull/437/files#diff-bf79a43449f7a7e1e76063e303fbdd35bec7eb50f2e9ddba26e3048def32ed06
tests/fixtures.pyhttps://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
View file https://github.com/jherland/importlib_metadata/blob/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456/tests/fixtures.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/importlib_metadata/pull/437/{{ revealButtonHref }}
https://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
https://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
https://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
https://github.com/python/importlib_metadata/pull/437/files#diff-5dbc88d6e5c3615caf10e32a9d6fc6ff683f5b5814948928cb84c3ab91c038b6
tests/test_api.pyhttps://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
View file https://github.com/jherland/importlib_metadata/blob/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456/tests/test_api.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/importlib_metadata/pull/437/{{ revealButtonHref }}
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
https://github.com/python/importlib_metadata/pull/437/files#diff-3451cc474d5698222168f66a293339a6bd296ee2c56f56409866bbae99917a79
tests/test_main.pyhttps://github.com/python/importlib_metadata/pull/437/files#diff-41d180f6f7233d175c2dfe36c45c4ea80eed4754fa7ed4eed46ccde1b2a778c7
View file https://github.com/jherland/importlib_metadata/blob/b8a8b5d35e6ca31a4a7cdfa5a3ee61562e8e7456/tests/test_main.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/importlib_metadata/pull/437/{{ revealButtonHref }}
https://github.com/python/importlib_metadata/pull/437/files#diff-41d180f6f7233d175c2dfe36c45c4ea80eed4754fa7ed4eed46ccde1b2a778c7
Please reload this pagehttps://github.com/python/importlib_metadata/pull/437/files
https://github.com/python/importlib_metadata/pull/437/files#diff-41d180f6f7233d175c2dfe36c45c4ea80eed4754fa7ed4eed46ccde1b2a778c7
https://github.com/python/importlib_metadata/pull/437/files#diff-41d180f6f7233d175c2dfe36c45c4ea80eed4754fa7ed4eed46ccde1b2a778c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.