René's URL Explorer Experiment


Title: Abstract methods in non-abstract imporlib.metadata.Distribution · Issue #419 · python/importlib_metadata · GitHub

Open Graph Title: Abstract methods in non-abstract imporlib.metadata.Distribution · Issue #419 · python/importlib_metadata

X Title: Abstract methods in non-abstract imporlib.metadata.Distribution · Issue #419 · python/importlib_metadata

Description: The empty methods read_text and locatate_file of Distribution class are decorated with abc.abstractmethod. But Distribution class doesn't have metaclass=abc.ABCMeta. PEP 3119, Introducing Abstract Base Classes, states.: The abstractmetho...

Open Graph Description: The empty methods read_text and locatate_file of Distribution class are decorated with abc.abstractmethod. But Distribution class doesn't have metaclass=abc.ABCMeta. PEP 3119, Introducing Abstract ...

X Description: The empty methods read_text and locatate_file of Distribution class are decorated with abc.abstractmethod. But Distribution class doesn't have metaclass=abc.ABCMeta. PEP 3119, Introducing Abstr...

Opengraph URL: https://github.com/python/importlib_metadata/issues/419

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Abstract methods in non-abstract imporlib.metadata.Distribution","articleBody":"The empty methods **read_text** and **locatate_file** of **Distribution** class are decorated with _abc.abstractmethod_. But _Distribution_ class doesn't have  _metaclass=abc.ABCMeta_.\r\n\r\n[PEP 3119](https://peps.python.org/pep-3119/), Introducing Abstract Base Classes, states.:\r\n> The abstractmethod decorator should only be used inside a class body, and only for classes whose metaclass is (derived from) ABCMeta. \r\n\r\nConsidering the facts that methods **read_text** and **locate_file** are used in other methods of _Distribution_ class and both are empty, only things containing are docstrings, I think the author of the class intended to use the _abstractmethod_ functionality to enforce an implementation of the aforementioned methods. So, in my opinion, the _Distribution_ class should have _metaclass=abc.ABCMeta_.\r\n\r\n(Other possibility is that the aforementioned methods are intended as stubs. Then the _abstractmethod_ decorator may be deleted.)\r\n\r\nI've created the PR in case the issue is right, i.e. the class should contain _metaclass=abc.ABCMeta_.\r\n\r\n\r\n\u003c!-- gh-linked-prs -->\r\n### Linked PRs\r\n* python/cpython#100466\r\n\u003c!-- /gh-linked-prs -->\r\n","author":{"url":"https://github.com/busywhitespace","@type":"Person","name":"busywhitespace"},"datePublished":"2022-12-23T15:48:12Z","url":"https://github.com/python/importlib_metadata/issues/419"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9206d154-7e40-0bf7-c6aa-217dc3e8f4f2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC84A:22F2F8:D6D05:127FB4:6B0080D6
html-safe-nonce49dfa510f72cb39c7b333c1f43d470454d9babe91615dc0be243d207258d91c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODRBOjIyRjJGODpENkQwNToxMjdGQjQ6NkIwMDgwRDYiLCJ2aXNpdG9yX2lkIjoiMTk1MzYwOTIyNTQ4NTcxMzYyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac10b4565539d842c70743e5ff25bcb63a1ec1fc919aef50fcff48a4e673042527
hovercard-subject-tagissue:1515695062
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/importlib_metadata/419/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e6c80259725168c7f34bb7ef6ab4a0a3be96b52c052c8168b0610e1da85861ea/python/importlib_metadata/issues/419
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e6c80259725168c7f34bb7ef6ab4a0a3be96b52c052c8168b0610e1da85861ea/python/importlib_metadata/issues/419
og:image:altThe empty methods read_text and locatate_file of Distribution class are decorated with abc.abstractmethod. But Distribution class doesn't have metaclass=abc.ABCMeta. PEP 3119, Introducing Abstract ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebusywhitespace
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-preview
go-importgithub.com/python/importlib_metadata git https://github.com/python/importlib_metadata.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id306448340
octolytics-dimension-repository_nwopython/importlib_metadata
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id306448340
octolytics-dimension-repository_network_root_nwopython/importlib_metadata
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/importlib_metadata/issues/419#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fimportlib_metadata%2Fissues%2F419
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fimportlib_metadata%2Fissues%2F419
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fimportlib_metadata
Reloadhttps://github.com/python/importlib_metadata/issues/419
Reloadhttps://github.com/python/importlib_metadata/issues/419
Reloadhttps://github.com/python/importlib_metadata/issues/419
pythonhttps://github.com/python
importlib_metadatahttps://github.com/python/importlib_metadata
Codehttps://github.com/python/importlib_metadata
Issues8 (8)https://github.com/python/importlib_metadata/issues
Pull requests6 (6)https://github.com/python/importlib_metadata/pulls
Actionshttps://github.com/python/importlib_metadata/actions
Projectshttps://github.com/python/importlib_metadata/projects
Wikihttps://github.com/python/importlib_metadata/wiki
Security and qualityhttps://github.com/python/importlib_metadata/security
Insightshttps://github.com/python/importlib_metadata/insights
https://github.com/python/importlib_metadata
New issuehttps://github.com/login?return_to=https://github.com/python/importlib_metadata/issues/419
New issuehttps://github.com/login?return_to=https://github.com/python/importlib_metadata/issues/419
#420https://github.com/python/importlib_metadata/pull/420
Abstract methods in non-abstract imporlib.metadata.Distributionhttps://github.com/python/importlib_metadata/issues/419#top
#420https://github.com/python/importlib_metadata/pull/420
https://github.com/jaraco
https://github.com/busywhitespace
busywhitespacehttps://github.com/busywhitespace
on Dec 23, 2022https://github.com/python/importlib_metadata/issues/419#issue-1515695062
PEP 3119https://peps.python.org/pep-3119/
gh-100465: Set metaclass of importlib.metadata.Distribution to abc.ABCMeta cpython#100466https://github.com/python/cpython/pull/100466
brettcannonhttps://github.com/brettcannon
jaracohttps://github.com/jaraco
on Dec 23, 2022https://github.com/python/importlib_metadata/issues/419#event-8134386696
https://github.com/jaraco
jaracohttps://github.com/jaraco
on Dec 24, 2022https://github.com/python/importlib_metadata/issues/419#issuecomment-1368485266
https://github.com/busywhitespace
busywhitespacehttps://github.com/busywhitespace
on Dec 25, 2022https://github.com/python/importlib_metadata/issues/419#issuecomment-1368485267
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Dec 25, 2022https://github.com/python/importlib_metadata/issues/419#issuecomment-1368485269
https://github.com/busywhitespace
busywhitespacehttps://github.com/busywhitespace
on Dec 25, 2022https://github.com/python/importlib_metadata/issues/419#issuecomment-1368485270
@AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/jaraco
jaracohttps://github.com/jaraco
on Jan 1, 2023https://github.com/python/importlib_metadata/issues/419#issuecomment-1368485271
pypa/pip#11684https://github.com/pypa/pip/issues/11684
jaracohttps://github.com/jaraco
python/cpythonhttps://github.com/python/cpython
on Jan 1, 2023https://github.com/python/importlib_metadata/issues/419#event-8134386730
jaracohttps://github.com/jaraco
on Jan 1, 2023https://github.com/python/importlib_metadata/issues/419#event-8134453299
Add ABCMeta to Distribution. Fixes #419.https://github.com/python/importlib_metadata/commit/1e924140e96c2fb134d88d766bb4004ea0915da6
#419https://github.com/python/importlib_metadata/issues/419
https://docs.github.com/articles/closing-issues-via-commit-messages
1e92414https://github.com/python/importlib_metadata/commit/1e924140e96c2fb134d88d766bb4004ea0915da6
Update changelog. Ref #419.https://github.com/python/importlib_metadata/commit/100bdaa5d29e94f8d8ed1a5edacecf446226dadb
#419https://github.com/python/importlib_metadata/issues/419
https://docs.github.com/articles/closing-issues-via-commit-messages
100bdaahttps://github.com/python/importlib_metadata/commit/100bdaa5d29e94f8d8ed1a5edacecf446226dadb
Add ABCMeta to Distribution. Fixes #419.https://github.com/python/importlib_metadata/commit/8a9d1699aa47d71da6fb385b8510bf95fed6e3e2
#419https://github.com/python/importlib_metadata/issues/419
https://docs.github.com/articles/closing-issues-via-commit-messages
8a9d169https://github.com/python/importlib_metadata/commit/8a9d1699aa47d71da6fb385b8510bf95fed6e3e2
Update changelog. Ref #419.https://github.com/python/importlib_metadata/commit/2d52ecd7a581e97012830e7d18932408729d0e9a
#419https://github.com/python/importlib_metadata/issues/419
https://docs.github.com/articles/closing-issues-via-commit-messages
2d52ecdhttps://github.com/python/importlib_metadata/commit/2d52ecd7a581e97012830e7d18932408729d0e9a
jaracohttps://github.com/jaraco
completedhttps://github.com/python/importlib_metadata/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#420https://github.com/python/importlib_metadata/pull/420
on Jan 1, 2023https://github.com/python/importlib_metadata/issues/419#event-8134462162
https://github.com/jaraco
jaracohttps://github.com/jaraco
on Apr 13, 2023https://github.com/python/importlib_metadata/issues/419#issuecomment-1506972788
#422https://github.com/python/importlib_metadata/issues/422
jaracohttps://github.com/jaraco
on Dec 26, 2023https://github.com/python/importlib_metadata/issues/419#event-11339988274
Make Distribution properly abstract. Ref #419.https://github.com/python/importlib_metadata/commit/5f84fe8a3cf7d5fef740556b87b3079bacba79c6
#419https://github.com/python/importlib_metadata/issues/419
5f84fe8https://github.com/python/importlib_metadata/commit/5f84fe8a3cf7d5fef740556b87b3079bacba79c6
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/importlib_metadata/issues/419
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/importlib_metadata/issues/419
jaracohttps://github.com/jaraco
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.