René's URL Explorer Experiment


Title: GH-100000: Cleanup and polish various watchers code by itamaro · Pull Request #99998 · python/cpython · GitHub

Open Graph Title: GH-100000: Cleanup and polish various watchers code by itamaro · Pull Request #99998 · python/cpython

X Title: GH-100000: Cleanup and polish various watchers code by itamaro · Pull Request #99998 · python/cpython

Description: This includes: Followup on @markshannon's comment, improving code watchers dispatch efficiency (read callback only if watcher is on the active watchers bits, and bail out early from dispatch loop) Apply same optimization to func watchers dispatch loop as well Remove dict watchers array that was never used Add initialization of type watchers array Add (PyCFunction) cast to a few test functions Change an invariant test in type watchers dispatch loop to an assert Issue: gh-100000

Open Graph Description: This includes: Followup on @markshannon's comment, improving code watchers dispatch efficiency (read callback only if watcher is on the active watchers bits, and bail out early from dispatch l...

X Description: This includes: Followup on @markshannon's comment, improving code watchers dispatch efficiency (read callback only if watcher is on the active watchers bits, and bail out early from dispat...

Opengraph URL: https://github.com/python/cpython/pull/99998

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2deea8e4-14a3-7e25-1dea-0a9584b251ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DE8:3191F6:B27FC:F5691:696962CC
html-safe-noncee1492b5bd603c70c8e52126fd7c787ad1045ff7753d44ab7883ef037b097380e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REU4OjMxOTFGNjpCMjdGQzpGNTY5MTo2OTY5NjJDQyIsInZpc2l0b3JfaWQiOiIzNjQ4MzU0ODA0NTEwMDU3MTY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf31a6e7b189f5e48fa6ec226343199ef204accc67bf58dbd85084aa30c460b52
hovercard-subject-tagpull_request:1145488383
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/99998/files
twitter:imagehttps://avatars.githubusercontent.com/u/290943?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/290943?s=400&v=4
og:image:altThis includes: Followup on @markshannon's comment, improving code watchers dispatch efficiency (read callback only if watcher is on the active watchers bits, and bail out early from dispatch l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None48487c1ad776a7975b7132d95f4240ff3ae37cd5b8e3cb597102a4edb76738f1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release669463fcc54773a88c1f5a44eef6b99a5504b9c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/99998/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99998%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F99998%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/99998/files
Reloadhttps://github.com/python/cpython/pull/99998/files
Reloadhttps://github.com/python/cpython/pull/99998/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/99998/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/99998/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
itamaro:watchers-polishhttps://github.com/itamaro/cpython/tree/watchers-polish
Conversation 7 https://github.com/python/cpython/pull/99998
Commits 7 https://github.com/python/cpython/pull/99998/commits
Checks 0 https://github.com/python/cpython/pull/99998/checks
Files changed https://github.com/python/cpython/pull/99998/files
Please reload this pagehttps://github.com/python/cpython/pull/99998/files
GH-100000: Cleanup and polish various watchers code https://github.com/python/cpython/pull/99998/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/99998/files
468ef72 Cleanup nits in watchers-related code itamaro Nov 23, 2022 https://github.com/python/cpython/pull/99998/commits/468ef723a49f3b375af273aee7a362885ac70d99
d380f0c Optimize code watchers notification itamaro Dec 4, 2022 https://github.com/python/cpython/pull/99998/commits/d380f0cfdacf5051e2ee3844a0a09126cdc2f856
8e2e17a Replace invariant test with assert in type watchers notification itamaro Dec 4, 2022 https://github.com/python/cpython/pull/99998/commits/8e2e17a4fe748dddf4b7f900bef650814f6b894e
0eaed3e Optimize func watchers notification itamaro Dec 5, 2022 https://github.com/python/cpython/pull/99998/commits/0eaed3ec2d0da98ef990cf4e4e4a67386d5dce61
28b1d8d Merge branch 'main' into watchers-polish itamaro Dec 5, 2022 https://github.com/python/cpython/pull/99998/commits/28b1d8d2d4e24152400c6e4bb93a960705d7d5bf
40044c0 Replace invariant test with assert in function watchers dispatch itamaro Dec 5, 2022 https://github.com/python/cpython/pull/99998/commits/40044c09b4cd796df47a1eddff10b59d319dc7f0
80f9519 Merge branch 'main' into watchers-polish itamaro Dec 13, 2022 https://github.com/python/cpython/pull/99998/commits/80f9519756fa0f48eb8092f4e890a27d6f7fc794
Clear filters https://github.com/python/cpython/pull/99998/files
Please reload this pagehttps://github.com/python/cpython/pull/99998/files
Please reload this pagehttps://github.com/python/cpython/pull/99998/files
pycore_interp.h https://github.com/python/cpython/pull/99998/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
watchers.c https://github.com/python/cpython/pull/99998/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
codeobject.c https://github.com/python/cpython/pull/99998/files#diff-6f869eb8beb7cbe4bc6817584b99ad567f88962fa67f7beca25d009dc401234d
funcobject.c https://github.com/python/cpython/pull/99998/files#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
typeobject.c https://github.com/python/cpython/pull/99998/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
pystate.c https://github.com/python/cpython/pull/99998/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L317
Include/internal/pycore_interp.hhttps://github.com/python/cpython/pull/99998/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Include/internal/pycore_interp.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
https://github.com/python/cpython/pull/99998/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
Modules/_testcapi/watchers.chttps://github.com/python/cpython/pull/99998/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Modules/_testcapi/watchers.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/pull/99998/files#diff-3a5f3035e419b37a194b533132a28c35c2d995c18cdd9ae3223393c2b3770ead
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L210
Objects/codeobject.chttps://github.com/python/cpython/pull/99998/files#diff-6f869eb8beb7cbe4bc6817584b99ad567f88962fa67f7beca25d009dc401234d
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Objects/codeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-6f869eb8beb7cbe4bc6817584b99ad567f88962fa67f7beca25d009dc401234d
https://github.com/python/cpython/pull/99998/files#diff-6f869eb8beb7cbe4bc6817584b99ad567f88962fa67f7beca25d009dc401234d
Objects/funcobject.chttps://github.com/python/cpython/pull/99998/files#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Objects/funcobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/pull/99998/files#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/pull/99998/files#diff-57bc77178b3d6f1010dd924722c87522f224d93bc341f0e46c0945094124d8f2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L216
Objects/typeobject.chttps://github.com/python/cpython/pull/99998/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/99998/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Python/pystate.chttps://github.com/python/cpython/pull/99998/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/itamaro/cpython/blob/80f9519756fa0f48eb8092f4e890a27d6f7fc794/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/99998/{{ revealButtonHref }}
https://github.com/python/cpython/pull/99998/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/99998/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.